Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

fixes #22575 - clean up test report

• Replace deprecated only_path with ignore_query

• Don't log to stdout for skipped tests

~_{* Don't override capture}~

~_{While this code might be helpful for debugging, leaving it in for}~
~_{every test run clutters up the test report.}~...

Fixes #21103 - Replace 'false' AR callback results with throw

Fixes #17874 - Extract contains_erb? from lookup key

Fixes #10957 - Correctly handle to_gb when no unit given

Fixes #16577 - enhance unit detection

fixes #16512 - remove Setting#respond_to_missing?

respond_to_missing? changed how AR handles group_by calls on
collections, causing group_by to be interpreted as a scope on the model.
Rather than adding a database call to determine known setting names,
it's been removed again....

Fixes #16491 - Upgrade rubocop to version 0.42

Fixes #2314 - fine grain for RAM selectors

Refs #3809 - Turning on some rubocop cops

Fixes #14965 - turn off auditing during DB migrations

Move code turning off auditing during db:migrations so that it is
executed earlier than initializers

fixes #14096 - handle MiB style memory units on statistics page

Fixes #12325 - Add to_utf8 method and ensure avatar_path returns in utf-8

Fixes #11924 - Substitute .scoped by .where(nil) to force return relation

On Rails 4 .scoped is deprecated. Calling .all on the model returns the
equivalent ActiveRecord relation object on Rails 4, but on Rails 3 it
returns an Array right away.

A proper replacement we can use is where(nil) - it's ugly but it returns...

Fixes #11188 - EnsureNotUsedBy checks for unscoped associations before destroying

Refs #3809 - Remove semicolon cop

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Fixes #8796 - Fix to_gb size calculation and constentize

Refs #3809 - Remove useless assignments

fixes #7586, #7734, #7172 - user preferences for receiving mail notifications

Adds a framework for user-selectable mail notifications. The work is
still done in ActionMailer classes and launch by rake in cron, however a
wrapper called MailNotification is used to provide RBAC and make the...

fixes #7331 - delete unassigned os default templates

Refs #3809 - Use parentheses in method definitions

Fixes #4976 - ensure the process is really running inside a rake task

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4161: plugin ActiveRecord models that do no define 'name' method no longer throw NoMethodError when to_s is called

Fixes #2632 - extract strings from validation errors

upgrade foreman to rails 3.2.13

This commit updates from rails 3.0.x to 3.2.x, main changes include:

• Asset pipline support
• cleanup of existing assets (javascript, css, images)

Users who uses foreman in production, make sure that you now compile
your assets, e.g...

feature #1906 add Trend information

Signed-off-by: Amos Benari <abenari@redhat.com>
Signed-off-by: Ohad Levy <ohadlevy@gmail.com>

fixed pg db:migration bug that failed on create table media

minor SQL improvments

cherry pick pluck to core extentions, remove it after we upgrade rails.

fixes #1764 changing per_page setting would update only after a restart

this commit changes it back to an area in the code which gets evaluated
everytime instead of upon startup only

fixes #1729 safer migration code.

fixes #1700 audit page performance improved

• Added auditabale name and associated name columns.
• Added username to audit table

don't allow to delete a provisioning template when its assigned to an OS default template

fixes #1676 have memory size use factors of 1024

fixes #1656 add support for systems with terabytes of memory

code smell

Fixes #944 - clear network conflicts

When a network conflict is detected (such as conflicting ip/name dns or
dhcp records), foreman would try to suggest a resolution.

Signed-off-by: Paul Kelly <paul.ian.kelly@googlemail.com>

Revert "Fixes #944 - clear network conflicts"

This reverts commit 117ba92a758e4589ef5fdf1f1b9083402b2d317b.

Fixes #944 - clear network conflicts

When a network conflict is detected (such as conflicting ip/name dns or
dhcp records), foreman would try to suggest a resolution.

Signed-off-by: Paul Kelly <paul.ian.kelly@googlemail.com>

WIP rails3 migration

fixes #1166 - be more liberal in accepted values for to_gb - add better logging message

Signed-off-by: Tim Speetjens <tim.speetjens@gmail.com>

fixes #685 - records per page should be configurable

This patch adds a new setting how many records should be per page.

note that since the code is in the ActiveRecord::Base class, and that
its in lib (e.g. loaded once) you would need to restart foreman everytime you change this value....

fixes #1050 - Foreman settings should not be viewed/edited by non admin user

fixes #777 - this enable auditing of when a host is changing its puppet class assignmetns

one limitation of this patch is that at the moment, each class change
gets its own audit record.