Project

General

Profile

Statistics
| Branch: | Tag: | Revision:

# Date Author Comment
75ba4ecc 05/11/2024 06:03 PM Oleh Fedorenko

Fixes #37436 - Remove TimedCacheStore class

Foreman uses either redis or file store for quite some time.
This class is not being used anywhere.

b0f28c2c 05/10/2024 09:55 AM Archana Kumari

Fixes #37432 - Fix Style/GlobalStdStream cop

f87b1a25 04/15/2024 08:28 AM Leos Stejskal

Fixes #37337 - Fix snapshot task and add Rocky 8 & 9

0085153c 03/26/2024 11:57 AM Ewoud Kohl van Wijngaarden

Fixes #37287 - Iterate on hashes when both key and value are used

This replaces the `hash.keys.each { |k| hash[k] }` and `hash.keys.sort`
patterns with `hash.each { |k, v| }` where it makes sense. This avoids
doing hash lookups when you already know the value anyway.

bbca4738 03/04/2024 10:48 AM Oleh Fedorenko

Fixes #36574 - Update fast_gettext to ~> 2.1

de48fb5b 03/04/2024 10:48 AM Ewoud Kohl van Wijngaarden

Refs #36574 - Avoid patching Fastgettext

The code defines an additional method on Fastgettext but there's no
reason to do so. It can just as well define a method on itself.

89c61045 01/26/2024 10:44 AM Maria Agaphontzev

Fixes #37102 - webpack 5

d0fcacde 09/25/2023 02:34 PM Evgeni Golov

Fixes #36774 - count db:abort_if_pending_migrations as setup task

this avoids loading settings and friends just to check if a migration is
required

414c1c6f 07/13/2023 10:38 AM Ron Lavi

Refs #36219 - remove redundant line

in parameters rake task, key_type_name was assigned twice

dbe4db80 07/13/2023 10:38 AM Ron Lavi

Fixes #36222 - drop unused puppet rake task

c9b82a57 07/13/2023 10:38 AM Ron Lavi

Fixes #36219 - use YAML.safe_load instead of YAML.load

as explained in this rubocop rule https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/YAMLLoad

f7e5525d 05/20/2023 10:25 PM Adam Ruzicka

Fixes #36419 - Generate locale js files as pretty

for smaller diffs on updates

8fd2bf42 05/17/2023 02:17 PM Adam Ruzicka

Refs #36330 - Place assets into plugin dir

e848148a 05/17/2023 11:46 AM Adam Ruzicka

Fixes #36330 - Fix plugin translations in frontend

- Add plugin:po_to_json rake task
- Load js locale files for all plugins
- Make i18n.js do multi-domain lookup

d9e83315 05/10/2023 02:04 PM Adam Ruzicka

Fixes #36331 - Expose translation registration in plugin DSL

f4ceaae3 01/10/2023 01:14 PM Adam Ruzicka

Fixes #35903 - Support extracting logs from journald

d459e62d 01/04/2023 12:56 PM Ben Magistro

Fixes #35797 - libvirt nil network comparison

When libvirt compares networks, it is possible that `network` will be
`nil` resulting in a match instead of continuing on to the bridge
comparison.

Signed-off-by: Ben Magistro <>

34728aee 12/15/2022 04:15 PM Ondřej Ezr

Fixes #35871 - purge trends only when statistics not installed

We instroduced migration to purge trends data in 34709a3781355b63e7afe2864e03c5f663479602.
It forgot to add condition to check if the statistics plugin is not installed.

34709a37 09/21/2022 06:35 PM Ian Ballou

Fixes #35347 - purge old trends and foreman_docker references during upgrade (#9343)

340801f8 09/14/2022 01:05 PM Leos Stejskal

Fixes #35488 - Fix snapshots:generate task

Fixed issues:
  • Generating snapshot for provision/coreos_provision.erb
  • Generating snapshot for PXEGrub2/kickstart_default_pxegrub2.erb
  • Error "undefined method 'include?' for nil:NilClass" when rendering
    'Kickstart default PXEGrub2' on host with empty 'pxe_loader'
207c82c3 09/06/2022 07:05 AM Matěj Mudra

Fixes #31966 - Add warning for foreman-rake permissions:reset task (#9395)

20f48047 08/30/2022 11:48 AM Ewoud Kohl van Wijngaarden

Fixes #29539 - Unbundle websockify

Removing the outdated websockify version means relying on the system
version. This allows independent (security) updates.

It is now expected that websockify lives somewhere in $PATH.

4a49fd01 08/17/2022 08:28 AM Partha Aji

Refs #35359 - cleaner add_ca_bundle_to_store

ee9fe3a7 08/16/2022 07:08 PM Partha Aji

Fixes #35359 - Add cacert to http proxy (#9348)

This PR adds a cacert column to the http proxy and uses to this for
connecting to ec2 and other compute resources. This would also be used
by katello/other plugins when communicating to the CDN over a https...

d7ca221c 06/27/2022 03:41 PM Adam Ruzicka

Fixes #34996 - Ignore http proxies when talking to smart proxies

6f724472 06/27/2022 03:41 PM Adam Ruzicka

Fixes #35014 - Rework Net::HTTP extension

8b3c7c54 06/27/2022 03:41 PM Adam Ruzicka

Fixes #35014 - Fix injection of global HTTP proxy into net/http

We were passing wrong arguments to proxy_http_request?, causing it to
always evaluate to false so no requests were proxied.

55570902 06/08/2022 08:48 AM Ondřej Ezr

Fixes #35013 - config rake uses Setting DSL

config rake was still using obsolete setting access.

1cf4147a 05/24/2022 07:07 AM Leos Stejskal

Fixes #34526 - Switch Rails version to 6.1

Changes overview:
- Set default Rails version to 6.1
- Required dynfow >= 1.6.5
- Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml
- ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter...

0d706b95 05/22/2022 12:28 PM Jeremy Lenz

Fixes #34921 - Fix SettingValueException error message

7e52ff53 05/13/2022 09:47 AM Adam Ruzicka

Fixes #34913 - Take plugins into consideration when checking pending migrations

Also unify migration pending checking

662c4a3a 05/09/2022 08:09 AM Jeremy Lenz

Fixes #34838 - Add errors when setting values are invalid (#9203)

04f9a859 04/11/2022 08:49 AM Ron Lavi

Refs #31147 - fix seed:reports example

f186d646 04/08/2022 05:35 AM Ondřej Ezr

Fixes #34690 - rake printing auditable attributes

Add a rake task that prints out all auditable attributes available in the APP.

8c4d848f 03/23/2022 06:23 AM Leos Stejskal

Fixes #34526 - rescue_from JSON params parse errors

Use rescue_from block instead of the CatchJsonParseErrors middleware
See https://github.com/rails/rails/pull/34341

c56db5d6 03/15/2022 02:37 PM Lukas Zapletal

Refs #34360 - allow host deleting with host_reports plugin

Signed-off-by: Lukas Zapletal <>

af3f1189 03/14/2022 07:49 AM Ondřej Ezr

Fixes #34596 - sanitize default template names

Default boot templates are weirdly interconnected with its settings.

9b83dfe5 03/11/2022 10:58 AM Ondřej Ezr

Fixes #33782 - do not use fixtures for Settings

As we no longer require settings in DB, we may drop the fixtures for settings.

0ed80f45 03/04/2022 11:52 AM Ondřej Ezr

Fixes #34339 - sanitize fqdn in tests

Tests were almost not using the fqdn defined in settings.yaml.test
That is quite confusing at first sight and we should not override this value by fixtures, only if overriden in the same test file.

749e7f2d 03/01/2022 08:25 PM Lukas Zapletal

Fixes #32632 - initial verison of Ubuntu autoinstall templates

Signed-off-by: Lukas Zapletal <>

8e28a45d 02/24/2022 03:38 PM Lukas Zapletal

Fixes #34462 - shorten DNS timeout for primary detection

Signed-off-by: Lukas Zapletal <>

221d255d 02/21/2022 11:00 AM Ondřej Ezr

Fixes #30122 - remove usage of controller level force_ssl

Foreman's use case for HTTP-only is provisioning. Many installers, like Red
Hat's Anaconda or Debian Preseed, either do not support it or make it very hard
to use HTTPS. This is especially hard since often a custom CA is used so the...

cf6c8ed9 02/17/2022 08:03 PM Leos Stejskal

Fixes #34350 - Require 'foreman/telemetry' in ldap initializer

7ccb4f68 02/14/2022 01:10 PM Leos Stejskal

Fixes #34353 - Fix early load of fog_extensions

e31dff60 01/18/2022 09:59 AM Lukas Zapletal

Fixes #31027 - transpiler macros for CoreOS family

2b1a177f 01/10/2022 02:36 PM Ondřej Ezr

Refs #33968 - Telemetry is not autoloadable

a26eb290 01/05/2022 10:01 PM Lukas Zapletal

Fixes #34122 - Report disallowed metric labels as other

Signed-off-by: Lukas Zapletal <>

ddc2b763 12/15/2021 05:52 PM Lukáš Zapletal

Fixes #34091 - add logging helper log_duration

Signed-off-by: Lukas Zapletal <>

e14eace6 12/15/2021 05:39 PM Leos Stejskal

Fixes #34146 - Move services from lib/foreman to app/services/foreman

fec6595b 12/15/2021 10:49 AM Leos Stejskal

Fixes #34138 - Autoload ProxyAPI files from /app/services

642a7df0 12/14/2021 01:43 PM Leos Stejskal

Fixes #34139 - Move Foreman::Renderer from lib/ to app/services

90d83f97 12/10/2021 02:33 PM Evgeni Golov

Refs #26968 - don't disable Katellos MeantimeReporter

katello dropped the relevant code, relying on our implementation now

7fe686a6 12/09/2021 01:46 PM Tomer Brisker

Fixes #34117 - Drop ancient models:consolidate task

This task was written 10 years ago and hasn't seen any updates since. It
is likely broken and useless.

583ae2b6 12/08/2021 01:22 PM Lukas Zapletal

Refs #33968 - Fix the fix of Telemetry initializers

96a6076f 12/06/2021 11:33 AM Leos Stejskal

Fixes #33897 - Puppet Environment in taxonomy ignore_types

b1f03b37 12/02/2021 03:02 PM Ewoud Kohl van Wijngaarden

Fixes #26968 - Switch to minitest-reporters

ci_reporter_minitest is unmaintained and since minitest 5.1 it no longer
shows the class names. minitest-reporters does.

35bc5a33 12/02/2021 08:40 AM Adi Abramovitch

Fixes #33801 - Replace obsolete URI.escape method

935035fe 11/26/2021 10:39 AM Leos Stejskal

Fixes #33991 - Require /lib dependencies in initializers/foreman.rb

638c4be8 11/25/2021 09:54 AM Lukas Zapletal

Fixes #32461 - add endline in save_to_file

Co-authored-by: Ondřej Ezr <>

cc93a200 11/24/2021 01:06 PM Ondřej Ezr

Fixes #33985 - move identifiers to ApplicationRecord

Move identifiers to ApplicationRecord from core_extensions.

0e5fca00 11/24/2021 10:54 AM Ondřej Ezr

Fixes #33984 - removes custom update methods

These archaic methods are not used anymore
These are in Rails for years so noone shoul be using them for a while now.

075b8e29 11/24/2021 10:18 AM Tomer Brisker

Fixes #33992 - drop truncate_bytes method

This method was added in Rails 6 to ActiveSupport.

604dc716 11/24/2021 08:55 AM Ondřej Ezr

Fixes #33986 - moves Callback ensures to separate files

We do not need to define the Ensure classes in core_extensions.
These are better off in separate files.

c8048ae2 11/23/2021 02:29 PM Leos Stejskal

Fixes #33968 - Fix loading of Foreman::Telemetry in initializers

c7a0068f 11/18/2021 02:03 PM Leos Stejskal

Fixes #33890 - Require Foreman::Gettext in initializers

Fix deprecation warning the about initialization of auto-loaded constants

32b7038f 11/14/2021 04:27 PM Oleh Fedorenko

Fixes #33907 - Add current_date macro

f0be3e1e 11/05/2021 01:47 PM Leos Stejskal

Fixes #33853 - demodulize resource type for plugin types

demodulize resource type for permission in Job templates
Plugins have resources usually in the plugin module namespace and that doesnt work well with permissions, which usually do not have this prefix in name.

f94b9c73 11/04/2021 11:26 PM Lukas Zapletal

Fixes #31947 - add grub2/ks validation to jenkins rake task

e2046807 10/26/2021 01:25 PM Ondřej Ezr

Refs #33541 - correct naming of association tables

22780a74 10/26/2021 01:25 PM Ondřej Ezr

Refs #31060 - drop also environment_classes

40818327 10/20/2021 03:03 PM Dominik Matoulek

Fixes #27024 - Adding audit cleanup duration and update rake task

Adding setting 'audit_period' to know how long saved audits user wants.
Also updating rake task for cleanup to reflect this setting

5e14256e 10/17/2021 09:13 AM Tomer Brisker

Refs #31060 - Move environment cleanup to rake task

f0b19a28 10/14/2021 01:00 PM Ondřej Ezr

Refs #32652 - cleanup schema_migrations from dropped migrations

8c3d16e0 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31060 - drop Environments migrations

Drops all migrations related to environments.
Removes all the relations to the environments.
Adds a migration to drop environments from Hostgroup and Host.

Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/41.

a18a518d 10/14/2021 01:00 PM Ondřej Ezr

Fixes #33541 - drop puppetclass migrations

Removes all migrations related to Puppetclass.

Added in plugin https://github.com/theforeman/foreman_puppet/pull/195

17d3fe68 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31096 - remove config group migrations

These migrations had been added to the plugin foreman_puppet_enc.
Details of addition https://github.com/theforeman/foreman_puppet_enc/pull/13

c41f1124 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31732 - drop env from TemplateCombination migration

Drop environment relation from TemplateCombination migrations.

07c6107a 10/14/2021 01:00 PM Ondřej Ezr

Fixes #32652 - task to purge puppet data

Adds rake task to purge all puppet data for users who do not choose to use puppet.

264e4a70 10/12/2021 12:32 PM Lukas Zapletal

Fixes #14854 - connection libvirt leak fixed

608e32be 09/24/2021 11:25 AM Ondřej Ezr

Fixes #32893 - use setting DSL for General category

This uses our new DSL to define the General settings, this showcases how
to use the new DSL and other categories should follow in the same
release.

73a42646 09/07/2021 04:13 PM Lukas Zapletal

Fixes #32837 - drop unwanted URI parsing from extension

76dd50df 09/02/2021 09:05 AM Dominik Matoulek

Fixes #33223 - Improving Job Invocation Report Template

Updating the template to merge outputs lines to one batch to show them
at one line.

1b364dd2 08/12/2021 01:06 PM Ondřej Ezr

Fixes #33180 - add task to migrate Puppet info

Adds task to migrate Puppet provisioning info to Host parameters.

0d08d7a6 08/11/2021 03:22 PM Kamil Szubrycht

Fixes #31049 - Introduce server CA file setting

989e0aad 08/09/2021 03:08 PM Leos Stejskal

Fixes #32822 - Job templates and resource picker

New `resource` user input type for templates with
template macro `input_resource` returning the resource object

cf6de107 08/03/2021 03:00 PM Bernhard Suttner

Fixes #33197 - Show error message if credentials are wrong

9c1b18ff 08/03/2021 09:27 AM Leos Stejskal

Fixes #33033 - shell_escape template macro

New template macro `shell_escape` using
Ruby's `Shellwords.shellescape` for safe shell strings.

Use `shell_escape` for user input variables
in registration templates (`global` & `host_init`)

4c4be749 07/28/2021 08:48 AM Lukas Zapletal

Fixes #33090 - load AIX OS attributes

dffe39af 07/23/2021 12:48 PM Evgeni Golov

Fixes #32540 - host_param_(true|false)? cleanup

let the `default_value` denote what we "read" by default from the host
(in the case the host doesn't have the param) and then compare it with
`true`/`false` (depending on the func) as done with the existing...

92eb6cee 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31235 - drop Puppetclass models

Drops Puppetclass models and their usage.
Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/81
Tests extracted in:
- hostgroup - https://github.com/theforeman/foreman_puppet_enc/pull/85

198040f6 07/16/2021 02:01 PM Leos Stejskal

Fixes #32918 - Host registration - Update packages

New parameter `update_packages` for update of
all packages on the host when registered

76816b9d 06/29/2021 10:13 PM Lukas Zapletal

Fixes #32635 - fix already initialized constant

5051e374 06/16/2021 08:33 AM Dominik Matoulek

Fixes #28221 - Adding passing of template scope for snippet rendering

In current implementation templates can be much complex by snippet.
Reusable pieces of template code that should be in the same scope like
their templates but they are not. This PR tries to solve that.

a41cabb4 06/11/2021 08:47 AM Adam Ruzicka

Fixes #32192 - Override only the relevant parts

a196afb1 06/11/2021 08:47 AM Adam Ruzicka

Fixes #32192 - Monkey patch restclient to unescape proxy credentials

Restclient as of version 2.1.0 uses provided credentials stored in a proxy URI
object verbatim. If the credentials are escaped as they should be, then this
leads to errors when we try to use the credentials because restclient sends the...

b652c4f5 05/21/2021 10:13 AM Lukáš Zapletal

Fixes #32636 - allow relative filename in settings (#8542)

055489b7 05/20/2021 06:29 PM Lukas Zapletal

Fixes #27604 - added Fedora|Redhat CoreOS and IM

b5935f9e 05/12/2021 10:29 PM Lukas Zapletal

Fixes #31407 - prevent spaces for snapshot test files

b6b6ffc0 05/07/2021 01:13 PM Lukáš Zapletal

Fixes #31717 - lazy-load fast_gettext for faster boot (#8275)

It's because we switch over all 20 languages to actually pull language name in the native language into a list of available languages. We use that in three places: settings page, user page and GraphQL....

641c3f4a 05/07/2021 10:34 AM Lukáš Zapletal

Fixes #31370 - multi-host stub template snapshots (#8149)

Our snapshot template render test and generator only supports one host stub (ipv4 single NIC redhat OS). In order to test more ERB codepaths, we need a way to create snapshots against multiple host stubs (e.g. IPv6, dualstack, static IPv4 or IPv6, debian family). In order to do that, template metadata can be extended to define list of host stubs to create and test snapshots against....