Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #23225 - fix vm tab js error in host page

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Fixes #15984 - Avoid escaping overridden parameters (#5126)

Fixes #22721 - Rename setting to trusted_hosts

The setting trusted_puppetmaster_hosts is used to allow hosts to submit
stuff to the facts/reports API endpoint.
The name made sense a long time ago, but these days other plugins and
any user can submit stuff to this API to generate...

Fixes #21999,#22005 - Migrate toasts to pf-react

• Replace Alert and Toasts components with patternfly-react
• Refactor the server side flash-notification
• Allow rails-flah-notification to react-toast-notification with link

Refs #22164 - use cheaper FactoryBot methods

• Refs #22164 - FactoryBot.build -> FactoryBot.build_stubbed

• Refs #22164 - FactoryBot.create -> FactoryBot.build

in
- test/unit/*
- test/models/shared/taxonomies_base_test.rb
- test/controllers/hosts_controller_test.rb

Fixes #5790 - Add compute resource to hostgroup (#4593)

Fixes #21102 - Replace 'xhr' in tests with keyword argument

Fixes #21098 - Use positional args in functional test requests

fixes #21579 - pagelets for host show

Fixes #21424 - use factory_bot_rails

Fixes #20957 - Replace alias_method_chain with Module prepend

Deprecated in Rails 5.0 and will be removed in 5.1. Some instances of
classes overwriting existing methods can be handled with `super`, other
concerns or modules are changed to use prepend instead of include....

Fixes #20098 - Resolve template_used for image provisioning

At the moment, the method Hostext::OperatingSystem#template_kinds is
unable to handle image-based provisioning. If there is an image, it will
not be able to find it as 'self.compute_attributes' does not exist for...

Fixes #20248, #20327 - Respect context in CSV export

Since CSV export is done using an enumerator which is executed by a
different thread to the one that creates it, we need to manually pass in
the context (user, location, organization) to the enumerator.

fixes #16592 - keep consistent for headline capitalization

Based on PatternFly Outline Headline Style, Suggested to
keep consistent in headline capitaliztion.

Fixes #19031 - move to patternfly pagination style

Fixes #16884 - enforce granular filters even during save

fixes #19131 - upgrade minitest to latest 5.x

- override minitest's `_` expectation method with the gettext method
- rename `location` let helper, conflicted with a minitest method name
- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`...

Fixes #16043 - add select all hosts option

Fixes #18001 - Add plugin permissions to core's roles

fixes #12419 - template preview host has typeahead

refs #18264 - remove text order assumption in response body test

Fixes #18264 - change select multiple host actions to POST

When selecting large amount of hosts for bulk action,
url is getting too long and may cause 414 error.
To avoid that, hosts_ids should send via post request
within the body.

fixes #18976 - separate tests with different request formats

When making a JSON format request followed by a request with no explicit
format, Rails 5 is now memorising that it's requesting application/json
instead of resetting to HTML or similar. It shouldn't be assumed that...

fixes #18662 - stop default scope being overridden by association

Ensure the Taxonomix empty default scope isn't overridden by association
scopes which (effectively) calls `.where(:id => ...)` and overrides the
value of :id set in this default scope. This occurs on Rails 5.0 which...

Fixes #16982 - Scope properly when no taxonomies are set

The default scope for hosts and other objects did not restrict
properly by taxonomies. An user without organizations or
locations, could do anything it's permissions allow to.
The list of hosts was unrestricted and showed hosts in...

fixes #18540 - update domain on primary in hosts_count tests

domain/domain_id are not attributes of the host itself, they're
delegated to the primary interface. When using update_attribute on the
host, the model doesn't appear `changed?` so Rails 5 skips the save....

Fixes #18045 - Puppet classes show up choosing only env.

After #3551 was merged, the hosts controller requires both environment
and hostgroup to be set in order to display puppetclasses.

It shouldn't be required to have both, so we should check what's
available and use it. If it's only the hostgroup or the environment, it...

Fixes #17683 - Wrong resource type in HG AJAX permission check

fixes #11127 - show error when rebuild reboot fails

refs #14688 - correct i18n extraction for all new power methods

- HOST_POWER being translated at the class level, not in action context
- messages with variables interpolated prior to i18n lookup
- timeout message being translated without prior extraction

Fixes #14688 - Power status visible on hosts index page

Fixes #14951 - Allow matcher for host turning into managed host

Fixes #16646 - Add ability to plugins to modify index scope

Fixes #6492 - ipmi_boot permission renamed to ipmi_boot_hosts

Authorizer expects permission names to follow a convention
'action'_'controller'. However this permission was not following it, and
this prevented the permission from being applied properly.

Before this fix, only admins could call ipmi_boot. I've also added a...

Fixes #13968 - Add error when no known proxy features found

fixes #16557 - move tests into modern Rails layout

Models, controllers, mailers and helpers are now in test/ subdirs
matching app/ subdirs. Service, miscellaneous and old test/lib/ tests
are now in test/unit/ separated from models, which obsoletes the custom...