Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #22546 - CVE-2018-1097: Bump fog-ovirt for power action fix

Fixes #22990 - Use shoulda-matchers

Fixes #22990 - Port robottelo tier1 compute resources

fixes #22454 - vmware: validate user data for customspec

Fixes #20807 - Remove deprecations for 1.18

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Refs #22164 - use cheaper FactoryBot methods

• Refs #22164 - FactoryBot.build -> FactoryBot.build_stubbed

• Refs #22164 - FactoryBot.create -> FactoryBot.build

in
- test/unit/*
- test/models/shared/taxonomies_base_test.rb
- test/controllers/hosts_controller_test.rb

fixes #22062 - support vmware vmrc console

Fixes #21424 - use factory_bot_rails

Fixes #19326 - create compute-resource - URL optional

fixes #4509 - VMWare: multiple scsi controllers

Fixes #20174 - handle no storage pool gracefully

Fixes #19631 - ComputeResource with KeyPair can be removed

The concern for removing the compute resources with keypairs was trying
to destroy the compute resource too early. Also, this deletion already
happened because of the has_one :dependency => :destroy relation...

fixes #19131 - upgrade minitest to latest 5.x

- override minitest's `_` expectation method with the gettext method
- rename `location` let helper, conflicted with a minitest method name
- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`...

Fixes #19236 - handle situation when host is destroyed oVirt

The issue was introduced in 4269abbd, where we replaced the
`OVIRT::OvirtException` error by `ActiveRecord::RecordNotFound` in
`find_vm_by_uuid method`, but we haven't updated the corresponding...

fixes #18064 - import host from compute resource

fixes #18373 - vmware: do not pass automatic firmware to vm

fixes #18216 - volume size editable for existing VMs one

Fixes #17015 - Adds Key pairs controller

Fixes #5483,#11106 - pass the virtualswitch value to fog

We can't pass the network id directly to the fog, but it accepts the
virtualswitch parameter, that we can use to point to the right value.

Also, it fixes another issue, where we used the vsphere network id to...

fixes #15610 - choose firmware for vsphere vms

Fixes #17535 - Associate host with multiple NICs to VMWare VM

fixes #16557 - move tests into modern Rails layout

Models, controllers, mailers and helpers are now in test/ subdirs
matching app/ subdirs. Service, miscellaneous and old test/lib/ tests
are now in test/unit/ separated from models, which obsoletes the custom...