fixes #22467 - dashboard: list hosts in build mode

Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

Fixes #21007 - new unattended action 'failed'

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #23932 - Fixes failing application job tests for some plugins

The tests were failing with:
Sequel::DatabaseError: PG::DuplicateTable:
ERROR: relation "dynflow_execution_plans" already exists

This failure was probably caused by forcing initialization of the...

Fixes #23857 - Fix Performance/InefficientHashSearch cop

• Fixes #23611 - Provide helper method to run "service" active jobs

The root cause was we were triggering the active jobs too early,
sometimes even before the db was migrated. This led to all sorts of
errors. The provided helper method does not trigger the jobs when in...

Fixes #23843 - Exclude requests to local host from proxying

fixes #23178 - seeded location should be in seeded org

When creating a host in the seeded org and seeded loc, host saves and
then organization becomes invalid: "Locations expecting locations used
by hosts or inherited (check mismatches report)."

Fixes #23550 - add to_hash method to Menu::Manager

Fixes #23487 - support namespaced controllers

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

fixes #21657 - remove facets when host is removed

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #23255 - Speed up seeds test

Every seed run takes about 10s. This combines 6 tests to run on the same
seed action, leading to about 60s saved locally.

Fixes #23215 - Keep original names in webpack bundle

Currently the webpack config is shortening the name of the js bundles
for plugins. E.g, foreman_remote_execution becomes remoteexecution, and
so on.
This becomes hard to deal with when we want to figure out which plugin...

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #22855 - Add full breadcrumbs functionality

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23115 - session is used instead session_safe

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23077 - Fix Style/TrailingCommaInArrayLiteral cop

Refs #22285 - Remove keep_param

This workaround was needed in Rails 5.0, but 5.1 already supports
filtering on arbitrary hash params.

Fixes #19857 - Fix Style/EachWithObject cop

Fixes #22624 - User selectable columns model + api

Adding initial bindings to user selectable columns. This model + api is
going to be used in work related Katello plugin's subscription pages.
The main intesnt of this PR is to provide a basic model where a user can...

Fixes #21120 - orchestration tasks are added only once (#5079)

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

fixes #22575 - clean up test report

• Replace deprecated only_path with ignore_query

• Don't log to stdout for skipped tests

~_{* Don't override capture}~

~_{While this code might be helpful for debugging, leaving it in for}~
~_{every test run clutters up the test report.}~...

Fixes #17316 - templates feature is subnet association

Fixes #21204 - introduced global_setting helper function (#4891)

Fixes #19244 - added clean interfaces rake task

Fixes #22354 - Make SilencedLogger thread safe

Fixes #22310 - Implement report scanner to identify origin (#5186)

Fixes #22379 - Remove pagination from csv export (#5204)

fixes #22411 - unattended: render template macros from plugins

Fixes #22430 - Plugin permissions are cleared on tests

- Some tests are removing all plugins (plugin_test, rabl_test,
belongs_to_proxy_test) from the registry. This has, among others,
one important consequence: the plugin permissions are removed.

- Take an example. Foreman Ansible overrides the Host#form with a...

Fixes #20807 - Remove deprecations for 1.18

Fixes #21317 - graceful handling of VM association error

Instead of immediate failure, just log the issue and proceed with the
import.

Fixes #21465 - load owners from any context

Fixes #17521 - Use short name for hosts

This commit enforces the policy of using short name for hosts
while preserving the fqdn for interface values provided the user has
enabled 'append_domain_name_for_hosts' Setting.

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19838 - Fix Rails/PluralizationGrammar cop

Refs #22164 - use cheaper FactoryBot methods

• Refs #22164 - FactoryBot.build -> FactoryBot.build_stubbed

• Refs #22164 - FactoryBot.create -> FactoryBot.build

in
- test/unit/*
- test/models/shared/taxonomies_base_test.rb
- test/controllers/hosts_controller_test.rb

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

refs #20929 - do not stub settings

Fixes #20929 - Added fact name filtering on import

Added a setting that will filter out fact names, so they won't be
recorded into `fact_names` and `fact_values` tables at all.

fixes #22085 - facet test models have db table

Refs #3763 - fix indentation in rabl_test.rb

Fixes #22054 - Audit resources which lack auditing

Http Proxy, Models(H/W Models)

fixes #3763 - extend rabl templates

Fixes #19771 - Fix Layout/EmptyLineAfterMagicComment cop

Fixes #21851 - Remove deprecations for 1.17

Fixes #19772, #19773, #19774 - Fix some empty line cops

fixes #21823 - adds foreman user agent to RSS loading (#5039)

Fixes #21902 - Replace use_transactional_fixtures setting

Fixes #21776 - Improved fact importing to deal with names

Now the list of fact names will be calculated beforehand and saved
to the database. It will also consider that the name could be added
from other thread.

Fixes #21826 - rss notifications are duplicated (#5042)

From my understanding "item.summary" isn't passed to the created
Notification which made it weird why it is used when checking if
it exists.

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>

fixes #21832 - permission test: do not assume required login

Fixes #18292 - Make notifications from an RSS feed (#4240)

This adds a task to connect to an RSS feed, by default the one from our
community blog. The idea is to make this run every night with 'cron' on
every Foreman installation to keep people updated about changes, and...

Fixes #21584 - set taxonomies for chart requests

Fixes #21718 - Test

Fixes #15402 - Moved puppet to separate api controller

Fixes #21424 - use factory_bot_rails

Fixes #21342 - fix core roles seeding

Core roles should always be up to date based on what's defined in seed
files. Users have no other way to update locked roles in newer Foreman
versions.

Fixes #12216 - support http proxies for compute resources

Fixes #21232 - verify IP sans when authenticating a SP

Fixes #21176 - don't modify strong param filter rules

Fixes #19706 - don't treat DHCP leases as conflicts

Fixes #20559 - print rails log for test failures

Fixes #15409 - Separated puppet facts from core

Fixes #21104 - Recognize br-ex etc as bridge interfaces

Extends the bridge regex pattern to allow bridges named after purpose
like br-ex, br-tun as documented in openstack dvr scenario.

Fixes #20201 - Global HTTP proxy for outgoing requests

This introduce two new settings to proxy outgoing HTTP
requests and one to except certain hosts from it.

The extensions for Excon::Connection and Net::HTTP
allow setting a proxy on their requests.

Fixes #20955 - Remove conditions to {destroy, delete}_all calls

Fixes #20953 - Remove assert_nothing_raised args

fixes #20653 - ui notifications for hosts with usergroup owner

Refs #16740 - migration templates to use param macros

Fixes #20737 - add default description to roles

Fixes #19039 - Lock plugin roles

Fixes #20622 - puppet import does not refresh all statuses

fixes #20645 - stub templates proxy url call

Fixes #20475 - Random DB IPAM with MAC preservation

Refs #16884 - add minitest stubbing to test helper

fixes #10982 - configure RestClient log to 'proxy' logger

Request/response information is sent to the proxy logger, showing the
URLs called, headers, request body etc.

The X-Request-ID header is now also set in the proxy requests to a
random ID stored in the session, to prevent the user's real session ID...

Fixes #20418 - Add taxonomies to newly imported puppet env

Fixes #20312: Use bundler_ext in production for webpack plugin

Fixes #16884 - enforce granular filters even during save

Fixes #19677 - Add settings for local boot templates

fixes #18500 - replace quiet_assets with sprockets-rails flag

• fixes #18512 - support sprockets-rails 3.x

The app.assets environment is no longer always configured, and instead
is only configured when the regular Rails environment is loaded. Loading
only the 'assets' group initializers isn't sufficient....

Fixes #19266 - fix_db_cache crashes Rails initialization

The Filters cache that CacheManager recreates when
fix_db_cache is true, fails when the roles associated with said
filters are locked. To generate the cache, we call `.save` on the filter
object, which is not allowed by Role....

Fixes #19825 - Fix Performance/TimesMap cop

Fixes #18892 - Do not show 'undefined method' in error message

fixes #19977 - Fetch a value for a given subnet parameter name

This code will add a function to lookup a subnet parameter by name,
and returns it's value. It will return `nil` if no value was found.

The function is added to the renderer, so it can be called from...

Fixes #20034 - add Organization admin role

• Fixes #20034 - add Organization admin role
• Refs #20034 - refactor role names

Fixes #20017 - mail notifications work for global admins

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #19728 - set admin user in rake console

Fixes #19588 - Allow setting custom headers in CSV export

Fixes #19585 - Allow csv export of nested attributes

This is required for example to export host facet attributes.