Fixes #37406 - drop upload functionality from foreman-debug

Fixes #35463 - Allow newer rdoc on Ruby 3.1

Ruby 3.1 ships rdoc 6.1 by default.

Fixes #37391 - also use reactExports for core

Fixes #37387 - Drop unused typeToIcon function

Has been unused since d91a0e4d219560000c5cc9c145650bab2039ba3b.

Fixes: d91a0e4d2195 ("fixes #14178 - introduce patternfly toast notifications")

Fixes #37386 - Drop toggleRowGroup and filter_permissions functions

Their last use was dropped in acfbc45886c4d81a2a3ca5af433a6124a0a7191a
and I can't other traces of their usage.

Fixes: acfbc45886c4 ("fixes #812 - new permissions model, user group role and nest support, role filters for better granularity")

Fixes #37385 - Drop (un)check_all_roles event handlers

In acfbc45886c4d81a2a3ca5af433a6124a0a7191a the links with these IDs
were removed, but the JavaScript handler remained. I can't find other
traces of its usage. Originally added in
feacea35f07f362d9e2c694a83516bbc902321a0....

Archive all_react_app_exports.js

Fixes #36830 - transform_vars on preseed_path

Co-Authored-by: quartsize

Fixes #37307 - Add more control over SelectAllCheckbox

Fixes #36691 - use 'connectefi scsi' by default

Co-Authored-by: Shimon Shtein <sshtein@redhat.com>
Co-Authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Fixes #37367 - Switch to 'network' directive instead of ifcfg

include Katello in GHA tests

Fixes #36525 - kickstart's RHSM line only works on RHEL hosts

Fixes #37343 - Fix the ks param deprecation warning for rhel 8

Fixes #36885 - Add Clevis/Tang disk encryption template

For disk encryption Clevis/Tang is often used. This commit introduces
partition templates for Kickstart and Autoinstall taking care of disk
encryption and a snippet responsible for binding the LUKS device via...

Fixes #37353 - always read cached webpack manifest

Fixes #37337 - Fix snapshot task and add Rocky 8 & 9

Fixes #37293 - Add user columns to hosts index
- add column registry
- add plugin documentation
- Make breadcrumb a React link
- Respect display_fqdn_for_hosts setting

Fixes #37344 - enable compression for webpack assets

Fixes #37252 - prevent duplicate foremanReact in plugins

switch container to use CentOS Stream 9 as base

Fixes #37312 - Upgrade foreman-vendor packages to 13.x

Fixes #33664 - Adjust subman_setup snippet for debian

Fixes #37280 - remove typeAheadSelect

Fixes #37215 - Stop reporting CV/LCE if not set to hosts

Pin fog-vsphere to >= 3.6.4

See https://community.theforeman.org/t/problem-with-end-build-on-vmware-esxi-8-0-u2/37139

Fixes #37231 - Handle incorrect domain setting display

Fixes #37247 - refactor HostsIndex to map results directly

Fixes #37287 - Iterate on hashes when both key and value are used

This replaces the `hash.keys.each { |k| hash[k] }` and `hash.keys.sort`
patterns with `hash.each { |k, v| }` where it makes sense. This avoids
doing hash lookups when you already know the value anyway.

Fixes #37282 - Adding the current_time macro

Fixes #37273 - Use delegation syntax for resource_scope

In Ruby 3 you need to explicitly delegate keyword arguments, or if you
don't care about Ruby 2.6 or prior then you can use the new delegation
syntax¹.

It deals with the difference in calling where. When calling `.where([])`...

Fixes #37002 - Add pagelet anchor for user and usergroup tabs

This feature allows plugins to add pagelets for the users/usergroups
edit page.

Refs #37065 - require at least apipie-dsl 2.6.2

It adds the `kwlist` macro

Fixes #37274 - Mark API/params as deprecated

Fixes #37270 - Misspelled OpenStruct class name

Fixes #37069 - Fallback to UTC on invalid timezone

Fixes #37065 - report_row now explicitly accepts kwargs
also adds a test which fails without the fix

Fixes #37244: Add new virtual hw versions for VSphere 8.0 and 8.0U2

See https://kb.vmware.com/s/article/1003746 for reference

Fixes #37248 - make hostsIndexContext a singleton

Fixes #37255 - pin victory-pie ~36.8.6

Fixes #36023: Add missing VMWare GuestOS mappings

Refs #37010 - Ensure correct yaml for netplan

The introduced safe operator returns nil instead of false, but the
snippet expects true/false.

Refs #37034 - Fix ERB syntax for comments

Co-authored-by: Markus Bucher <bucher@atix.de>

Fixes #37236 - Add primaryButton prop to PermissionDenied component

Fixes #37199 - javascript method for webpack_asset_paths

Fixes #37132 - Fix sorting problem in os integration test

Fixes #37241 - Use PostgreSQL 13 in tests

Fix Style/CommentAnnotation cop

Fixes #37150 - Race condition in edit smart proxy test

Refs #37224 - Force all Hosts to have a comment

The previous implementation of the update had two issues:
1) It only operated on ::Host::Managed
2) It silently failed if the host was invalid for any other reason

Fixes 4c7f36edf

Fixes #37043 - Inheritance overrides host facets

Refs #37179 - explicitly include SelectiveClone in facets

That way plugins that try to use Hostgroup.include don't fail with

undefined method `include_in_clone' for Hostgroup

Fixes #37179 - Clone hostgroup facets when cloning hostgroup

Fixes #37233 - Generic table always shows actions

Fixes #37224 - Force Hosts to have a comment

To prevent the nil > empty string transition we would either have to:
check the incoming changes and discard the unwanted ones
- ignore these transitions when creating audits
- just force hosts to always have a comment...

Fixes #37167 - Subscription entitlement report template

Fixes #36574 - Update fast_gettext to ~> 2.1

Refs #36574 - Avoid patching Fastgettext

The code defines an additional method on Fastgettext but there's no
reason to do so. It can just as well define a method on itself.

Refs #37034 - Use apt-key add on Ubuntu 16.04

• On Ubuntu 16.04, which is supported by Canonical until 2026, you
  cannot place a GPG public key in "/etc/apt/trusted.gpg.d/" and use it
  to verify the signature of "Release" files.
• EoL Ubuntu 16.04: https://ubuntu.com/16-04...

sort taxable_ids before comparing them

For some reason, taxable_ids and visible_dummies are sometimes sorted
differently, resulting in failed tests even tho the right taxonomies are
found, just in the wrong order.

Use assert_equal_arrays that sorts the arrays before comparing them.

Fixes #37011 - Apply latest Ubuntu Autoinstall userdata changes

• Add explicit fallback for offline installation
• Replace deprecated lock-passwd with lock_passwd
• Remove empty ssh keys array if none provided

Fixes #37193 - trap ERR not supported on dash

Fixes #37134 - upgrade to node 18 and npm 8

Bump actions/upload-artifact from 3 to 4

• Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)...

Fixes #37184 - Report template generates incorrect kernel version

Refs #36502 - update snapshots after template change

Fixes #36502 - iPXE Discovery Only Works on net0

Fixes #37189 - Registration before & after snippets

before_registration & after_registration snippets allow
users to add their code to the template without directly editing it.

Fixes #36891 - Provide a scope for email-notification-eligible users

Bump develop to 3.11.0-develop

More explicit dev setup instructions

This adds explicit Fedora and Enterprise Linux instructions. It also
adds a section on PostgreSQL. This makes the alternative database.yml
no longer needed. It also sets and explicit admin password instead of
relying on the auto generated value.

Correct the minimum PostgreSQL version

i18n - extracting new, pulling from tx

Fixes #37168 - fix potential for duplicate html-id

Fixes #37173 - duplicate ids from webpack style

Fixes #37142 - Cloud-init breaks due to newline

This fixes cloud-init based deployment to Proxmox for Debian, Ubuntu,
and SUSE Linux Enterprise Server. Previously, deployments failed due to
a newline in the echo command.

Fixes #37039 - Honor permissions and taxonomies for host statuses

Fixes #37092 - Use minitest_reporters_github in GHA

This is a specialized reporter to provide GitHub annotations on failure.
These annotations can be seen in the changes files tab.

Fixes #37156 - Pin victory-core to 36.8.z

Fixes #37154 - run componentRegistry.registerMultiple once

Fixes #37089 - host details - sub tabs are hidden

Refs #37102 - Read real webpack manifest in test

In some test cases (like controller tests) the real manifest isn't
needed, but in integration tests they are.

Rails has deprecated controller tests in favor of integration tests, but
Foreman still has them. This modifies the fake read_webpack_manifest to...

Fixes #37161 - load public/webpack when available

Fixes #37079 - Show current user in nav menu when screen too small

build packit on el9

Fixes #37064 - Login missing background after scrolling

Fixes #37128 - Unpin @adobe/css-tools

Refs #36849 - Enable strict keyword argument matching

Fixes #36849 - Run GHA on Ruby 3.0

Fixes #37127 - Clean up old storybook dependencies

Fixes #37126 - Replace node-sass with sass

sass was already added to package.json for Webpack 5, this just makes it
used across the board and drops node-sass

Remove unused cssnano and css-minimizer-webpack-plugin

Refs #37102 - detect plugins webpack by looking for remoteEntry.js

Since we switched to Webpack 5, there are no more manifest.json in the
plugins webpack folder, but we need some token to detect that we gotta
load webpack stuff.

Fixes #37120 - Fix grammar error in Realm welcome

Fixes #37015 - Refactor OwnerClassifier

- Introduce `classify_owner` class method for owner classification.
- Implement private method for input validation.
- Add error handling to raise the necessary exceptions.
- Add deprecation warning to the `user_or_usergroup` method.

Fixes #37115 - Drop unused react-dnd-test-utils dependency

Fixes: 89b8fc37394b ("Fixes #28488 - consume jest config from env")

Refs #37102 - filter out webpack host argument

Refs #37102 - add back generic node_modules resolve path

Refs #37102 - explicitly depend on buffer

we use it in react_app/common/globalIdHelpers.js
so we should explicitly depend on it

Refs #37102 - don't prefix vendor imports with node_modules