Project

General

Profile

« Previous | Next » 

Revision 64b8c7a4

Added by Ondřej Pražák over 8 years ago

Fixes #11426 - remove puppet class paremeters no longer possible during edit in UI

View differences:

app/controllers/api/v2/puppetclasses_controller.rb
param_group :puppetclass
def update
process_response @puppetclass.update_attributes(params[:puppetclass])
class_params = params[:puppetclass].merge!(:smart_class_parameter_ids => @puppetclass.smart_class_parameters.map(&:id))
process_response @puppetclass.update_attributes(class_params)
end
api :DELETE, "/puppetclasses/:id/", N_("Delete a Puppet class")
app/views/puppetclasses/_form.html.erb
<li data-used-environments=<%= key.environments.map(&:to_s).to_json %> >
<a data-toggle="tab" id="pill_<%= key.to_s.gsub(' ','_') + '_' + key.id.to_s %>" href="#<%= key.to_s.gsub(' ','_') + '_' + key.id.to_s %>" title="<%= key %>">
<div class="clip"><%= icon_text((key.override ? "flag": ""), key.to_s.gsub('_',' ')) %></div>
<span class="close pull-right">&times;</span>
</a>
</li>
<% end %>
test/functional/api/v2/puppetclasses_controller_test.rb
end
assert_response :success
end
test "should not remove puppetclass params" do
klass = FactoryGirl.create(:puppetclass, :environments => [FactoryGirl.create(:environment)])
FactoryGirl.create(:puppetclass_lookup_key, :as_smart_class_param, :puppetclass => klass)
assert_equal 1, klass.class_params.length
put :update, { :id => klass.id, :smart_class_parameter_ids => [] }
klass.reload
assert_equal 1, klass.class_params.length
end
end

Also available in: Unified diff