Project

General

Profile

« Previous | Next » 

Revision 672e0467

Added by Ori Rabin almost 6 years ago

Fixes #24122 - Remove limit from LookupValue value

View differences:

db/migrate/20120607074318_convert_params_to_text.rb
end
def down
change_column 'parameters', :value, :string
change_column 'lookup_values', :value, :string
change_column 'parameters', :value, :string, :limit => 255
change_column 'lookup_values', :value, :string, :limit => 255
end
end
db/migrate/20121218084123_change_smart_variable_length.rb
end
def down
change_column :lookup_keys, :default_value, :string
change_column :lookup_keys, :default_value, :string, :limit => 255
end
end
db/migrate/20180702102759_remove_params_value_limit.rb
class RemoveParamsValueLimit < ActiveRecord::Migration[5.1]
def up
change_column :parameters, :value, :text, :limit => nil
change_column :lookup_values, :value, :text, :limit => nil
change_column :lookup_keys, :default_value, :text, :limit => nil
end
def down
# No need to revert, limit is only returned when converting to string in: 20120607074318_convert_params_to_text.rb
end
end
test/models/lookup_key_test.rb
assert lookup_key.valid?, "Can't update lookup key with valid data #{data}"
end
end
test "can create lookup key with long default_value" do
as_user :one do
lookup_key = FactoryBot.build(:variable_lookup_key, :key_type => 'string', :override => true,
:default_value => 'a' * 280, :puppetclass => puppetclasses(:one))
assert_valid lookup_key
end
end
end
test/models/lookup_value_test.rb
assert_equal value, sv_lookup_value.value
end
end
test "can create lookup value with long value" do
as_user :one do
lookup_value = LookupValue.new({ :match => "os=Common",
:value => 'a' * 280,
:lookup_key_id => lookup_keys(:complex).id
})
assert_difference('LookupValue.count') do
assert lookup_value.save
end
end
end
end

Also available in: Unified diff