/ - Diff - Foreman

« Previous | Next »

Revision 6ebba152

Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

.rubocop.yml

		Style/ConditionalAssignment:
		Enabled: false

		Style/EmptyMethod:
		EnforcedStyle: expanded

     # Offense count: 345
     # Configuration parameters: CountComments, ExcludedMethods.
     Metrics/BlockLength:
       Max: 1342
       Max: 1358
     # Offense count: 14
     # Configuration parameters: CountBlocks.
-...
     Style/DoubleNegation:
       Enabled: false
     # Offense count: 152
     # Cop supports --auto-correct.
     # Configuration parameters: EnforcedStyle.
     # SupportedStyles: compact, expanded
     Style/EmptyMethod:
       Enabled: false
     # Offense count: 48
     # Cop supports --auto-correct.
     Style/ExpandPathArguments:

     class AuthSourceExternal < AuthSource
       include Taxonomix
       def authenticate(login, password); end
       def authenticate(login, password)
       end
       def auth_method_name
         "EXTERNAL"

app/models/auth_sources/auth_source_hidden.rb
		class AuthSourceHidden < AuthSource
		def authenticate(login, password); end
		def authenticate(login, password)
		end

		def auth_method_name
		"HIDDEN"

             pretty_machine_type
           end
           def volumes_attributes=(attrs); end
           def volumes_attributes=(attrs)
           end
           def volumes
             disks

             name
           end
           def nics_attributes=(attrs); end
           def nics_attributes=(attrs)
           end
           def volumes_attributes=(attrs); end
           def volumes_attributes=(attrs)
           end
           # Libvirt expect units in KB, while we use bytes
           def memory

             status
           end
           def interfaces_attributes=(attrs); end
           def interfaces_attributes=(attrs)
           end
           def volumes_attributes=(attrs); end
           def volumes_attributes=(attrs)
           end
           def poweroff
             service.vm_action(:id => id, :action => :shutdown)

             power_state
           end
           def interfaces_attributes=(attrs); end
           def interfaces_attributes=(attrs)
           end
           def volumes_attributes=(attrs); end
           def volumes_attributes=(attrs)
           end
           def poweroff
             stop(:force => true)

         end
       end
       def delComputeDetails; end
       def delComputeDetails
       end
       def setComputeIP
         attrs = compute_resource.provided_attributes
-...
         failure _("Failed to get IP for %{name}: %{e}") % { :name => name, :e => e }, e
       end
       def delComputeIP; end
       def delComputeIP
       end
       def setComputeIPAM
         set_ip_address
-...
         failure _("Failed to set IP for %{name}: %{e}") % { :name => name, :e => e }, e
       end
       def delComputeIPAM; end
       def delComputeIPAM
       end
       def delCompute
         logger.info "Removing Compute instance for #{name}"

       end
       # Empty method for rollbacks - maybe in the future we would support creating the certificates directly
       def setCertificate; end
       def setCertificate
       end
       # Adds the host's name to the autosign.conf file
       def setAutosign
-...
       # we don't perform any actions upon create
       # PuppetCA is set only when a provisioning script (such as a kickstart) is being requested.
       def queue_puppetca_create; end
       def queue_puppetca_create
       end
       def queue_puppetca_update
         # Host has been built --> remove auto sign

                      :action => [self, :setSSHProvision])
       end
       def queue_ssh_provision_update; end
       def queue_ssh_provision_update
       end
       def setSSHProvisionScript
         logger.info "About to start post launch script on #{name}"
-...
         self.template_file = unattended_render_to_temp_file(template)
       end
       def delSSHProvisionScript; end
       def delSSHProvisionScript
       end
       def setSSHWaitForResponse
         logger.info "Starting SSH provisioning script - waiting for #{provision_ip} to respond"
-...
         failure _("Failed to login via SSH to %{name}: %{e}") % { :name => name, :e => e }, e
       end
       def delSSHWaitForResponse; end
       def delSSHWaitForResponse
       end
       def setSSHCert
         self.handle_ca
-...
         failure _("Failed to launch script on %{name}: %{e}") % { :name => name, :e => e }, e
       end
       def delSSHProvision; end
       def delSSHProvision
       end
       def validate_ssh_provisioning
         return unless ssh_provision?

app/services/filters_helper_overrides.rb

		private

		def initialize; end
		def initialize
		end
		end

       end
       context "without automatic login" do
         def login_admin; end
         def login_admin
         end
         test "login" do
           visit "/"

         include BelongsToProxies
         class << self
           def belongs_to(name, options = {}); end
           def belongs_to(name, options = {})
           end
           def validates(name, options = {}); end
           def validates(name, options = {})
           end
         end
         belongs_to_proxy :foo, :feature => 'Foo'

     class ExpirableTest < ActiveSupport::TestCase
       class SampleModel
         class << self
           def scope(name, opts); end
           def scope(name, opts)
           end
         end
         include Expirable

     module Awesome
       module Provider; class MyAwesome < ::ComputeResource; end; end
       def self.register_smart_proxy(name, options = {}); end
       def self.register_smart_proxy(name, options = {})
       end
     end
     module Awesome; class FakeFacet; end; end

Also available in: Unified diff