Project

General

Profile

« Previous | Next » 

Revision 80692275

Added by Ori Rabin over 8 years ago

Fixes #11663 - Empty lookup value not validated when use_puppet_default is checked

(cherry picked from commit baa21c791a8b8a3cbbc9f1a21a1cfe2448730800)

View differences:

app/models/lookup_value.rb
scoped_search :in => :lookup_key, :on => :key, :rename => :lookup_key, :complete_value => true
def value_present?
if value.nil?
if value.nil? && !use_puppet_default
self.errors.add(:value, :blank)
end
end
test/unit/lookup_value_test.rb
refute value.valid?
end
test "boolean lookup value should allow nil value if use_puppet_default is true" do
#boolean key
key = lookup_keys(:three)
value = LookupValue.new(:value => nil, :match => "hostgroup=Common", :lookup_key_id => key.id, :use_puppet_default => true)
assert_valid value
end
context "when key is a boolean and default_value is a string" do
def setup
@key = FactoryGirl.create(:lookup_key, :as_smart_class_param,

Also available in: Unified diff