Project

General

Profile

« Previous | Next » 

Revision d849076e

Added by Leos Stejskal about 3 years ago

Fixes #32313 - Bookmarks menu enhancements

- New link 'Manage bookmarks' leading to /bookmarks
page with search query set to current controller
- Documentation link moved to the end of the menu
- Added icon to 'Bookmark this search' link

View differences:

webpack/assets/javascripts/react_app/components/Bookmarks/Bookmarks.js
import PropTypes from 'prop-types';
import EllipisWithTooltip from 'react-ellipsis-with-tooltip';
import { Dropdown, MenuItem, Spinner, Icon } from 'patternfly-react';
import { PlusIcon } from '@patternfly/react-icons';
import SearchModal from './components/SearchModal';
import Bookmark from './components/Bookmark';
import DocumentationUrl from '../common/DocumentationLink';
import { STATUS } from '../../constants';
import { noop } from '../../common/helpers';
import { sprintf, translate as __ } from '../../../react_app/common/I18n';
import history from '../../history';
import { stringifyParams } from '../../common/urlHelpers';
const Bookmarks = props => {
const loadBookmarks = () => {
......
}
};
const manageBookmarks = controller => {
const query = stringifyParams({ searchQuery: `controller=${controller}` });
history.push({ pathname: '/bookmarks', search: query });
};
const {
controller,
url,
......
<Dropdown.Menu className="scrollable-dropdown">
{canCreate && (
<MenuItem key="newBookmark" id="newBookmark" onClick={setModalOpen}>
{__('Bookmark this search')}
<PlusIcon /> {__('Bookmark this search')}
</MenuItem>
)}
<DocumentationUrl href={documentationUrl} />
<MenuItem divider />
<MenuItem header>{__('Saved Bookmarks')}</MenuItem>
{status === STATUS.PENDING && (
......
</EllipisWithTooltip>
</MenuItem>
)}
<MenuItem divider />
{canCreate && (
<MenuItem
key="manageBookmarks"
id="manageBookmarks"
onClick={() => manageBookmarks(controller)}
>
{__('Manage Bookmarks')}
</MenuItem>
)}
<DocumentationUrl href={documentationUrl} />
</Dropdown.Menu>
</Dropdown>
</React.Fragment>

Also available in: Unified diff