Fixes #28161: Convert Bookmarks modal to ForemanModal
-Convert Bookmarks modal to ForemanModal -Update integration tests to account for ForemanModals in Redux store -Update ForemanForm to throw non-form-related JS errors and not swallow them (needed to do this to discover why some tests were failing) -Utilize useForemanModal hook for SearchModal -Refactor SearchModal to add index.js so that I could add the hook and still separate Redux dispatches from presentational logic -For BookmarkForm, pass down setModalClosed as prop -Refactor BookmarkForm index.js to be explicit about naming of mapStateToProps and mapDispatchToProps -update snapshots after Patternfly updates -rebase; remove old commits; update snapshots -add Show Modal button to Storybook story -refactor BookmarkForm inline function
Added by Jeremy Lenz about 4 years ago
Fixes #28161: Convert Bookmarks modal to ForemanModal
-Convert Bookmarks modal to ForemanModal
-Update integration tests to account for
ForemanModals in Redux store
-Update ForemanForm to throw non-form-related
JS errors and not swallow them (needed to do this
to discover why some tests were failing)
-Utilize useForemanModal hook for SearchModal
-Refactor SearchModal to add index.js so that
I could add the hook and still separate Redux
dispatches from presentational logic
-For BookmarkForm, pass down setModalClosed as prop
-Refactor BookmarkForm index.js to be explicit about
naming of mapStateToProps and mapDispatchToProps
-update snapshots after Patternfly updates
-rebase; remove old commits; update snapshots
-add Show Modal button to Storybook story
-refactor BookmarkForm inline function