Revision eb03be92
Added by Leos Stejskal almost 3 years ago
| app/controllers/concerns/foreman/controller/registration_commands.rb | ||
|---|---|---|
|
end
|
||
|
|
||
|
def registration_args
|
||
|
args = registration_params.except(*ignored_query_args)
|
||
|
args['setup_insights'] = registration_params['setup_insights']
|
||
|
args['setup_remote_execution'] = registration_params['setup_remote_execution']
|
||
|
|
||
|
args.delete_if { |_, v| v.blank? }
|
||
|
.permit!
|
||
|
registration_params.except(*ignored_query_args)
|
||
|
.transform_values! { |v| v == false ? v.to_s : v }
|
||
|
.delete_if { |_, v| v.blank? }
|
||
|
.permit!
|
||
|
end
|
||
|
|
||
|
def insecure
|
||
| test/controllers/api/v2/registration_commands_controller_test.rb | ||
|---|---|---|
|
location_id: taxonomies(:location1).id,
|
||
|
hostgroup_id: hostgroups(:common).id,
|
||
|
operatingsystem_id: operatingsystems(:redhat).id,
|
||
|
setup_insights: 'false',
|
||
|
setup_remote_execution: 'false',
|
||
|
setup_insights: false,
|
||
|
setup_remote_execution: false,
|
||
|
packages: 'pkg1',
|
||
|
update_packages: true,
|
||
|
}
|
||
Also available in: Unified diff
Fixes #33121 - Registration command API & params with false values
Registration API for generating registration command
incorrectly ignores parameters with `false` boolean value.