Project

General

Profile

« Previous | Next » 

Revision edd5310f

Added by Dominic Cleal about 7 years ago

fixes #19131 - upgrade minitest to latest 5.x

- override minitest's `_` expectation method with the gettext method
- rename `location` let helper, conflicted with a minitest method name
- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`

Contains fixes for tests that leak data or behavioral changes between
tests, as the ordering of test cases is now randomised:

- remove Host/Nic class modifications in orchestration concern test
- move NotificationBlueprint seeding into test transaction, preventing
DB truncation in integration tests from removing the records
- ensure DBCleaner.start is called when in transaction mode to prevent
records leaking out of integration tests
- sort records for reliable comparisons in TaxonomyTest
- move IPs of BMC NIC factory objects to 1.0.0.0/8 to avoid duplicates
- remove duplicate SettingTest cache clear, missing rescue

View differences:

test/models/orchestration/dns_test.rb
assert_valid @host
assert !@host.dns?
assert @host.reverse_dns?
assert_equal nil, @host.dns_record(:a)
assert_nil @host.dns_record(:a)
assert_not_nil @host.dns_record(:ptr4)
end

Also available in: Unified diff