Foreman » Installer

Add retry to foreman reporting script

• Try tree times before giving up when sending report to Foreman.
• Add retry tests to the report processor

closes GH-534
closes GH-535

remove old report specs and add a recent one

Improve formatting of foreman_smartproxy feature lists

Originally:
change from ["Logs", "Puppet CA", "TFTP"] to Puppet Puppet CA TFTP Logs failed

Now:
change from ["Logs", "Puppet CA", "TFTP"] to ["Logs", "Puppet", "Puppet CA", "TFTP"] failed

Validate feature list on foreman_smartproxy refresh

When refreshing the feature list on foreman_smartproxy via a notify,
validate it against the expected features to ensure they're all
configured correctly still.

The cached proxy data is replaced with the refresh response where...

Add features property to foreman_smartproxy to check enabled features

Implemented on the rest_v3 provider to validate that the enabled
features found by Foreman include all of the features listed in the
'features' property on the resource.

This should detect configuration errors on the smart proxy, or missing...

Remove YAML.load_file stubbing, preset $settings_file

Internally Puppet uses YAML.load_file to load the Hiera config (set to
/dev/null under rspec-puppet), but 4.9.0 uses Pathnames instead of
Strings causing the existing stub for "/dev/null" to fail.

Setting the value of $settings_file prior to evaluating the ENC/report...

Refs #4151 - Use new report API introduced in Foreman 1.11

node.rb: skip facts upload on nodes missing facts file

Don't bail out on nodes for which facts haven't been recorded yet; just
ignore the request.

Closes GH-474

Revert default rest_v3 request data to nil (#439)

Fixes refreshing of smart proxies against Foreman, since the PUT
request data defaulted to `{}`. This causes the oauth gem to form
encode the empty hash data, overriding the Content-Type to application/
x-www-form-urlencoded and the request is rejected by Foreman with a 415...

Fixes #14852 - do not pass in "data" param unless needed (#436)

Previously, the "data" param was passed to all oauth requests. This caused
issues with `GET` requests, since `data` and `headers` gets mashed into
`*arguments`, and then the oauth gem will `shift` off the first argument if...