Foreman » Smart Proxy

fixes #17262 - verify the JSON request body contains a hash

The json 2.x gem now parses strings and other non-hash root nodes, so
the data type need to be checked when parsing JSON bodies.

Fixes #10250 - simple SSH BMC provider

Fixes #14618 - refactored module initialization

to allow for:
    - support for multiple simultaneous providers
    - programmatically defined settings
    - custom validators
    - ability to customize module loading

Also includes support for constructor-based dependency injection

Fixes #12715 - simple log buffer and API

Fixes #10116 - BMC is not able to use parameters passed in through body

• adds new helper method to parse body as json and return hash
• protects against bad data being passed into options hash

Fixes #7543 - allow additional rubyipmi connection options to be passed
through

• replaces some stubs with mock in other tests

Fixes #9852 - REST API violation in BMC smart proxy API * authentication errors now return 401 and proper message

Fixes #9840 - BMC providers should return 501 error code when they don't implement the api call

• catches the NotImplementedError properely and returns 501 http code
• fixes rubocop warnings

Fixes #9711 - bmc module does not full implement its api * adds additional logic around providers * implements /providers, /providers/installed, /host, / * the / returns a list of resources to use to help the user * catches a case where if the provider is nil, we can default to a provider and warn the user...

Fixes #9710 - add rubyipmi test_connection api call

• updates rubyipmi to 0.9.1
• adds new bmc api call /bmc/:host/test that tests the connection
• adds test method to shell provider