Fixes #34353 - Fix early load of fog_extensions

Fixes #34146 - Move services from lib/foreman to app/services/foreman

Fixes #34138 - Autoload ProxyAPI files from /app/services

Fixes #34139 - Move Foreman::Renderer from lib/ to app/services

Fixes #33589 - use setting DSL for Authentication category

Fixes #30504 - Remove trends and statistics endpoints

These have been extracted to a plugin in 2.3 and can be dropped by now.

Refs #30925 - Rubocop autogenerated config with the gem

Fixes #30925 - use the organization style gem

Use `theforeman-rubocop` gem to share common RuboCop rules with plugins.
It serves as base for our rubocop styles and rules.

Fixes #29350 - Disable Layout/EmptyLineAfterGuardClause cop

Refs #29388 - Fix Minitest/GlobalExpectations cop

Fixes #29388 - Add rubocop-minitest

Fixes #29349 - Fix Layout/SpaceInsideArrayLiteralBrackets cop

Fixes #19892 - Fix Style/Proc cop

Fixes #19896 - Fix Style/RedundantSelf cop

Fixes #19904 - Configure Style/SymbolArray cop

Refs #29163 - Fix newly detected Rubocop violations

Fixes #29163 - Update Rubocop to 0.80

Fixes #19792 - Fix Layout/SpaceInsideBlockBraces cop

Fixes #28575 - Disable Performance/RegexpMatch cop

Fixes #28561 - Configure and fix Layout/AlignArguments cop

Fixes #19884 - Disable Style/NumericPredicate cop

Fixes #28576 - Fix Style/RedundantBegin cop

Fixes #28572 - Bump TargetRubyVersion to 2.5 for Rubocop

Fixes #19779 - Fix Layout/IndentHeredoc cop

Fixes #28511 - Fix Lint/SendWithMixinArgument cop

Fixes #28512 - Disable Layout/ClosingHeredocIndentation cop

Fixes #28225 - Update Rubocop to 0.75

Fixes #27263 - Fix Naming/UncommunicativeBlockParamName cop

Fixes #26782 - Update Rubocop to 0.71.0

Fixes #26546 - Update Rubocop to 0.64.0

Fixes #19768 - Fix Layout/ClosingParenthesisIndentation cop

Fixes #25365 - Disable Rails/RefuteMethods cop

Fixes #19875 - Disable Style/MultipleComparison cop

Fixes #25326 - Fix Lint/SafeNavigationConsistency cop

Disable Metrics cops

Refs #25300 - update rubocop_todo.yml

Fixes #25720 - Fix Style/CommentedKeyword cop

Refs #25300 - update rubocop_todo.yml

Fixes #20118 - return error message

• Fixes #20118 - display error instead of NilClass

In some scenarios when editing a host in Foreman, the VM may not
exist in VMware anymore, e.g. was deleted or uuid is missing.
The host is handled as a new VM, but cannot be saved....

Fixes #19891 - Disable Style/PreferredHashMethods cop

Fixes #19860 - Fix Style/For cop

Fixes #25327 - Fix Style/UnneededCondition cop

Fixes #25324 - Fix Performance/UnneededSort cop

Fixes #25325 - Fix Layout/RescueEnsureAlignment cop

Fixes #25300 - Update Rubocop to 0.59.2

Refs #24259 - Raise Metrics/MethodLength for Rubocop to pass

Fixes #19886 - Disable Style/ParallelAssignment cop

Fixes #19869 - Disable Style/LineEndConcatenation cop

Fixes #19790 - Fix Layout/SpaceBeforeBlockBraces cop

Fixes #19867 - Fix Style/IfUnlessModifierOfIfUnless cop

Refs #3809 - regenerate .rubocop_todo.yml

Fixes #19887 - Disable Style/ParenthesesAroundCondition cop

Fixes #23962 - Fix Style/ExpandPathArguments cop

Refs #20891 - fix for new rubocop rules

fixes #22467 - dashboard: list hosts in build mode

Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #22058 - refresh rubocop config and apply autofixes

Fixes #19855 - Disable Style/ConditionalAssignment cop

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23235 - Disable Style/IfUnlessModifier cop

Fixes #19770 - Disable Layout/DotPosition cop

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19848 - Set Style/Alias cop to prefer_alias_method

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Fixes #19840 - Fix Rails/ReadWriteAttribute cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Refs #23011 - set TargetRubyVersion: to 2.3

Fixes #23080 - Fix Style/EvalWithLocation cop

Fixes #23079 - Fix Naming/HeredocDelimiterCase cop

Fixes #19909 - Fix Style/TrivialAccessors cop

Fixes #23077 - Fix Style/TrailingCommaInArrayLiteral cop

Fixes #23076 - Fix Style/TrailingCommaInHashLiteral cop

Fixes #23075 - Fix Rails/HttpStatus cop

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #22849 - update rubocop to 0.54

[ci skip]

Fixes #19910 - Fix Style/UnlessElse cop

Fixes #19905 - Fix Style/SymbolLiteral cop

Fixes #19901 - Fix Style/SpecialGlobalVars cop

Fixes #19874 - Fix Style/MultilineMemoization cop

Fixes #19857 - Fix Style/EachWithObject cop

Fixes #19793 - Fix Layout/SpaceInsideReferenceBrackets cop

Fixes #19801 - Enable Lint/AssignmentInCondition cop

refs #22107 - subnet host count: permissions and n+1

Fixes #19763 - Disable Bundler/OrderedGems cop

Fixes #19889 - Fix Style/PerlBackrefs cop

Fixes #22329 - Fix Style/RandomWithOffset cop

Fixes #22328 - Fix Lint/InterpolationCheck cop

Fixes #22327 - Fix Lint/MissingCopEnableDirective cop

Fixes #22273 - update rubocop to 0.52.1

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19868 - Disable Style/InverseMethods cop

Fixes #19907 - Configure Style/TernaryParentheses cop