foreman/.rubocop_todo.yml @ develop
| a9d8cde5 | David Davis | # This configuration was generated by
|
|
| 11346a09 | Ondřej Ezr | # `rubocop --auto-gen-config`
|
|
# on 2020-11-30 14:34:25 UTC using RuboCop version 0.89.1.
|
|||
| 7ebd35e7 | David Davis | # The point is for the user to remove these configuration records
|
|
# one by one as the offenses are removed from the code base.
|
|||
# Note that changes in the inspected code, or installation of new
|
|||
# versions of RuboCop, may require this file to be generated again.
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 169
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: case, end
|
|
Layout/CaseIndentation:
|
|||
Enabled: false
|
|||
| 8823aa3a | Michael Moll | # Offense count: 194
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: symmetrical, new_line, same_line
|
|
Layout/MultilineHashBraceLayout:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 84
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: symmetrical, new_line, same_line
|
|
Layout/MultilineMethodCallBraceLayout:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 106
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: aligned, indented, indented_relative_to_receiver
|
|
Layout/MultilineMethodCallIndentation:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 87
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, IndentationWidth.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: aligned, indented
|
|
Layout/MultilineOperationIndentation:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 3656
|
|
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: space, no_space, compact
|
|
# SupportedStylesForEmptyBraces: space, no_space
|
|||
Layout/SpaceInsideHashLiteralBraces:
|
|||
Enabled: false
|
|||
| 8823aa3a | Michael Moll | # Offense count: 58
|
|
| aa7637bb | Tomer Brisker | Lint/AmbiguousBlockAssociation:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 134
|
|
# Cop supports --auto-correct.
|
|||
| aa7637bb | Tomer Brisker | Lint/AmbiguousRegexpLiteral:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 108
|
|
# Cop supports --auto-correct.
|
|||
| ce761fd9 | Tomer Brisker | Lint/BooleanSymbol:
|
|
Enabled: false
|
|||
| 43773332 | Michael Moll | # Offense count: 5
|
|
| ce761fd9 | Tomer Brisker | Lint/DuplicateMethods:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
| 7ccb4f68 | Leos Stejskal | - 'lib/fog_extensions/openstack/server.rb'
|
|
| 11346a09 | Ondřej Ezr | - 'app/registries/foreman/plugin/report_scanner_registry.rb'
|
|
- 'app/services/report_importer.rb'
|
|||
- 'test/models/concerns/exportable_test.rb'
|
|||
| aa7637bb | Tomer Brisker | ||
| 66d9e79a | Michael Moll | # Offense count: 9
|
|
| aa7637bb | Tomer Brisker | Lint/NonLocalExitFromIterator:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/api/base_controller.rb'
|
|||
- 'app/models/concerns/facets/model_extensions_base.rb'
|
|||
- 'app/services/compute_resource_host_importer.rb'
|
|||
- 'app/services/foreman/deprecation.rb'
|
|||
- 'app/services/interface_merge.rb'
|
|||
- 'db/migrate/20170223161638_lock_seeded_roles.rb'
|
|||
- 'test/models/provisioning_template_test.rb'
|
|||
| aa7637bb | Tomer Brisker | ||
| 11346a09 | Ondřej Ezr | # Offense count: 61
|
|
# Cop supports --auto-correct.
|
|||
| aa7637bb | Tomer Brisker | Lint/ParenthesesAsGroupedExpression:
|
|
Enabled: false
|
|||
| 49f17215 | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 4
|
|
| ce761fd9 | Tomer Brisker | Lint/ShadowingOuterLocalVariable:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/api/v2/mail_notifications_controller.rb'
|
|||
- 'app/graphql/resolvers/domain/subnets.rb'
|
|||
- 'app/helpers/audits_helper.rb'
|
|||
- 'test/models/template_test.rb'
|
|||
| ce761fd9 | Tomer Brisker | ||
| 11346a09 | Ondřej Ezr | # Offense count: 4
|
|
| 8823aa3a | Michael Moll | # Configuration parameters: AllowComments.
|
|
Lint/SuppressedException:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/concerns/find_common.rb'
|
|||
- 'app/models/concerns/audit_extensions.rb'
|
|||
- 'app/models/concerns/orchestration/compute.rb'
|
|||
- 'test/models/hostgroup_test.rb'
|
|||
| 8823aa3a | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 122
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| e7e5ef3e | Tomer Brisker | # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
|
|
| 7ebd35e7 | David Davis | Lint/UnusedBlockArgument:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 141
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| 11346a09 | Ondřej Ezr | # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
|
|
| 7ebd35e7 | David Davis | Lint/UnusedMethodArgument:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 13
|
|
| ce761fd9 | Tomer Brisker | Lint/UriEscapeUnescape:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/helpers/application_helper.rb'
|
|||
- 'app/helpers/compute_resources_vms_helper.rb'
|
|||
- 'test/unit/tasks/interfaces_test.rb'
|
|||
# Offense count: 2
|
|||
# Cop supports --auto-correct.
|
|||
Lint/UriRegexp:
|
|||
Exclude:
|
|||
- 'app/models/http_proxy.rb'
|
|||
- 'app/validators/url_schema_validator.rb'
|
|||
| ce761fd9 | Tomer Brisker | ||
| 49f17215 | Michael Moll | # Offense count: 4
|
|
| 7386f11b | Michael Moll | # Configuration parameters: CheckForMethodsWithNoSideEffects.
|
|
| ce761fd9 | Tomer Brisker | Lint/Void:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/compute_resources/foreman/model/openstack.rb'
|
|||
- 'app/models/concerns/audit_extensions.rb'
|
|||
- 'app/models/nic/base.rb'
|
|||
- 'app/services/name_generator.rb'
|
|||
| ce761fd9 | Tomer Brisker | ||
| 17b5c3c6 | Michael Moll | # Offense count: 28
|
|
# Cop supports --auto-correct.
|
|||
Minitest/AssertEmpty:
|
|||
Enabled: false
|
|||
# Offense count: 26
|
|||
# Cop supports --auto-correct.
|
|||
Minitest/AssertEqual:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/controllers/api/v2/hosts_controller_test.rb'
|
|||
- 'test/controllers/api/v2/registration_controller_test.rb'
|
|||
- 'test/controllers/api/v2/template_inputs_controller_test.rb'
|
|||
- 'test/controllers/api/v2/users_controller_test.rb'
|
|||
- 'test/controllers/audits_controller_test.rb'
|
|||
- 'test/controllers/common_parameters_controller_test.rb'
|
|||
- 'test/controllers/domains_controller_test.rb'
|
|||
- 'test/controllers/environments_controller_test.rb'
|
|||
- 'test/controllers/hosts_controller_test.rb'
|
|||
- 'test/controllers/realms_controller_test.rb'
|
|||
- 'test/controllers/users_controller_test.rb'
|
|||
- 'test/models/architecture_test.rb'
|
|||
- 'test/models/compute_resources/compute_resource_test_helpers.rb'
|
|||
- 'test/models/operatingsystem_test.rb'
|
|||
- 'test/models/shared/taxonomies_base_test.rb'
|
|||
# Offense count: 159
|
|||
| 17b5c3c6 | Michael Moll | # Cop supports --auto-correct.
|
|
Minitest/AssertIncludes:
|
|||
Enabled: false
|
|||
# Offense count: 11
|
|||
# Cop supports --auto-correct.
|
|||
Minitest/AssertMatch:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/controllers/api/v2/autosign_controller_test.rb'
|
|||
- 'test/controllers/compute_resources_controller_test.rb'
|
|||
- 'test/controllers/hostgroups_controller_test.rb'
|
|||
- 'test/controllers/hosts_controller_test.rb'
|
|||
- 'test/controllers/provisioning_templates_controller_test.rb'
|
|||
- 'test/controllers/unattended_controller_test.rb'
|
|||
- 'test/helpers/pagelets_helper_test.rb'
|
|||
| 17b5c3c6 | Michael Moll | ||
# Offense count: 1
|
|||
# Cop supports --auto-correct.
|
|||
Minitest/AssertNil:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/graphql/queries/personal_access_token_query_test.rb'
|
|||
| 17b5c3c6 | Michael Moll | ||
# Offense count: 3
|
|||
# Cop supports --auto-correct.
|
|||
Minitest/AssertRespondTo:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/models/hostgroup_test.rb'
|
|||
- 'test/models/orchestration_test.rb'
|
|||
- 'test/unit/fact_importer_test.rb'
|
|||
| 17b5c3c6 | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 49
|
|
| 17b5c3c6 | Michael Moll | # Cop supports --auto-correct.
|
|
Minitest/AssertTruthy:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 13
|
|
# Cop supports --auto-correct.
|
|||
Minitest/GlobalExpectations:
|
|||
Exclude:
|
|||
- 'test/unit/net/validations_test.rb'
|
|||
| 17b5c3c6 | Michael Moll | # Offense count: 14
|
|
# Cop supports --auto-correct.
|
|||
Minitest/RefuteEmpty:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/controllers/api/v2/bookmarks_controller_test.rb'
|
|||
- 'test/controllers/api/v2/environments_controller_test.rb'
|
|||
- 'test/controllers/api/v2/hostgroups_controller_test.rb'
|
|||
- 'test/controllers/api/v2/hosts_controller_test.rb'
|
|||
- 'test/controllers/api/v2/os_default_templates_controller_test.rb'
|
|||
- 'test/controllers/api/v2/roles_controller_test.rb'
|
|||
- 'test/controllers/api/v2/template_combinations_controller_test.rb'
|
|||
- 'test/models/template_test.rb'
|
|||
- 'test/unit/net/dhcp_test.rb'
|
|||
# Offense count: 240
|
|||
| 17b5c3c6 | Michael Moll | # Cop supports --auto-correct.
|
|
Minitest/RefuteFalse:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 40
|
|
| 17b5c3c6 | Michael Moll | # Cop supports --auto-correct.
|
|
Minitest/RefuteIncludes:
|
|||
Enabled: false
|
|||
# Offense count: 1
|
|||
# Cop supports --auto-correct.
|
|||
Minitest/RefuteMatch:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/helpers/pagelets_helper_test.rb'
|
|||
| 17b5c3c6 | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 51
|
|
| ce761fd9 | Tomer Brisker | Naming/AccessorMethodName:
|
|
Enabled: false
|
|||
# Offense count: 2
|
|||
Naming/BinaryOperatorParameterName:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/host/base.rb'
|
|||
- 'app/registries/foreman/plugin.rb'
|
|||
| ce761fd9 | Tomer Brisker | ||
| effd2370 | Michael Moll | # Offense count: 21
|
|
| 11346a09 | Ondřej Ezr | # Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, Regex, IgnoreExecutableScripts, AllowedAcronyms.
|
|
| ce761fd9 | Tomer Brisker | # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
|
|
Naming/FileName:
|
|||
Enabled: false
|
|||
| 17b5c3c6 | Michael Moll | # Offense count: 15
|
|
| 8823aa3a | Michael Moll | # Configuration parameters: ForbiddenDelimiters.
|
|
# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
|
|||
| ce761fd9 | Tomer Brisker | Naming/HeredocDelimiterNaming:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/api/v2/hosts_controller.rb'
|
|||
- 'app/controllers/api/v2/media_controller.rb'
|
|||
- 'lib/foreman/silenced_logger.rb'
|
|||
- 'lib/tasks/model.rake'
|
|||
- 'lib/tasks/webpack_compile.rake'
|
|||
- 'test/benchmark/benchmark_helper.rb'
|
|||
- 'test/models/lookup_key_test.rb'
|
|||
- 'test/models/lookup_value_test.rb'
|
|||
- 'test/models/parameter_test.rb'
|
|||
- 'test/models/report_template_test.rb'
|
|||
- 'test/models/template_test.rb'
|
|||
- 'test/unit/foreman/renderer/safe_mode_renderer_test.rb'
|
|||
- 'test/unit/foreman/renderer/unsafe_mode_renderer_test.rb'
|
|||
# Offense count: 31
|
|||
| 8c84f5b5 | Michael Moll | # Configuration parameters: EnforcedStyleForLeadingUnderscores.
|
|
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
|
|||
| 7386f11b | Michael Moll | Naming/MemoizedInstanceVariableName:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 49
|
|
| 49f17215 | Michael Moll | # Configuration parameters: EnforcedStyle, IgnoredPatterns.
|
|
| ce761fd9 | Tomer Brisker | # SupportedStyles: snake_case, camelCase
|
|
Naming/MethodName:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/hosts_controller.rb'
|
|||
- 'app/helpers/form_helper.rb'
|
|||
- 'app/models/concerns/orchestration/compute.rb'
|
|||
- 'app/models/concerns/orchestration/puppetca.rb'
|
|||
- 'app/models/concerns/orchestration/ssh_provision.rb'
|
|||
- 'app/models/concerns/orchestration/tftp.rb'
|
|||
- 'app/models/environment.rb'
|
|||
- 'app/models/host/managed.rb'
|
|||
- 'app/models/hostgroup.rb'
|
|||
| fec6595b | Leos Stejskal | - 'app/services/proxy_api/tftp.rb'
|
|
| 11346a09 | Ondřej Ezr | - 'lib/net/dhcp/record.rb'
|
|
- 'test/controllers/api/v2/table_preferences_controller_test.rb'
|
|||
- 'test/helpers/fact_values_helper_test.rb'
|
|||
- 'test/models/orchestration_test.rb'
|
|||
- 'test/models/setting_test.rb'
|
|||
# Offense count: 152
|
|||
| 8823aa3a | Michael Moll | # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
|
|
| 11346a09 | Ondřej Ezr | # AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
|
|
| 8823aa3a | Michael Moll | Naming/MethodParameterName:
|
|
Enabled: false
|
|||
| 17b5c3c6 | Michael Moll | # Offense count: 39
|
|
| 8823aa3a | Michael Moll | # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
|
|
| ce761fd9 | Tomer Brisker | # NamePrefix: is_, has_, have_
|
|
| 8823aa3a | Michael Moll | # ForbiddenPrefixes: is_, has_, have_
|
|
# AllowedMethods: is_a?
|
|||
| ce761fd9 | Tomer Brisker | # MethodDefinitionMacros: define_method, define_singleton_method
|
|
Naming/PredicateName:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 60
|
|
| 43773332 | Michael Moll | # Cop supports --auto-correct.
|
|
# Configuration parameters: PreferredName.
|
|||
Naming/RescuedExceptionsVariableName:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 42
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| ce761fd9 | Tomer Brisker | # SupportedStyles: snake_case, normalcase, non_integer
|
|
Naming/VariableNumber:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'test/controllers/api/v2/domains_controller_test.rb'
|
|||
- 'test/controllers/api/v2/hostgroups_controller_test.rb'
|
|||
- 'test/controllers/api/v2/locations_controller_test.rb'
|
|||
- 'test/controllers/api/v2/operatingsystems_controller_test.rb'
|
|||
- 'test/controllers/api/v2/organizations_controller_test.rb'
|
|||
- 'test/controllers/api/v2/subnets_controller_test.rb'
|
|||
- 'test/integration/org_admin_js_test.rb'
|
|||
- 'test/models/host_test.rb'
|
|||
- 'test/unit/plugin/rbac_registry_test.rb'
|
|||
- 'test/unit/ui_notifications/rss_notifications_checker_test.rb'
|
|||
# Offense count: 18
|
|||
# Configuration parameters: MinSize.
|
|||
Performance/CollectionLiteralInLoop:
|
|||
| ce761fd9 | Tomer Brisker | Enabled: false
|
|
| 9645d895 | David Davis | ||
| 11346a09 | Ondřej Ezr | # Offense count: 1
|
|
# Cop supports --auto-correct.
|
|||
# Configuration parameters: SafeMultiline.
|
|||
Performance/DeletePrefix:
|
|||
Exclude:
|
|||
- 'app/services/puppet_fact_parser.rb'
|
|||
| 8823aa3a | Michael Moll | # Offense count: 3
|
|
# Cop supports --auto-correct.
|
|||
Rails/ApplicationController:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/api/base_controller.rb'
|
|||
- 'app/controllers/api/graphql_controller.rb'
|
|||
- 'test/controllers/concerns/application_shared_test.rb'
|
|||
| 8823aa3a | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 184
|
|
| 8c84f5b5 | Michael Moll | # Cop supports --auto-correct.
|
|
# Configuration parameters: Include.
|
|||
# Include: **/test/**/*
|
|||
Rails/AssertNot:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 101
|
|
# Cop supports --auto-correct.
|
|||
Rails/ContentTag:
|
|||
Enabled: false
|
|||
| 1b276e91 | Michael Moll | # Offense count: 28
|
|
# Configuration parameters: Include.
|
|||
# Include: db/migrate/*.rb
|
|||
Rails/CreateTableWithTimestamps:
|
|||
Enabled: false
|
|||
| 49f17215 | Michael Moll | # Offense count: 10
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: strict, flexible
|
|
| a9d8cde5 | David Davis | Rails/Date:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/concerns/foreman/controller/csv_responder.rb'
|
|||
- 'app/models/report_composer.rb'
|
|||
- 'app/models/report_template.rb'
|
|||
- 'app/services/host_fact_importer.rb'
|
|||
- 'app/services/ui_notifications/clean_expired.rb'
|
|||
- 'test/controllers/concerns/csv_responder_test.rb'
|
|||
- 'test/controllers/report_templates_controller_test.rb'
|
|||
- 'test/models/report_template_test.rb'
|
|||
| a9d8cde5 | David Davis | ||
| 17b5c3c6 | Michael Moll | # Offense count: 557
|
|
| 0c774a3a | Shlomi Zadok | # Cop supports --auto-correct.
|
|
| 11346a09 | Ondřej Ezr | # Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
|
|
| 0c774a3a | Shlomi Zadok | # Whitelist: find_by_sql
|
|
| 11346a09 | Ondřej Ezr | # AllowedMethods: find_by_sql
|
|
# AllowedReceivers: Gem::Specification
|
|||
| 0c774a3a | Shlomi Zadok | Rails/DynamicFindBy:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 41
|
|
| 8c84f5b5 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: slashes, arguments
|
|||
| aa7637bb | Tomer Brisker | Rails/FilePath:
|
|
Enabled: false
|
|||
| 66d9e79a | Michael Moll | # Offense count: 12
|
|
| 7ebd35e7 | David Davis | # Configuration parameters: Include.
|
|
| f0091ac8 | Dominic Cleal | # Include: app/models/**/*.rb
|
|
| 7ebd35e7 | David Davis | Rails/HasAndBelongsToMany:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/architecture.rb'
|
|||
- 'app/models/medium.rb'
|
|||
- 'app/models/operatingsystem.rb'
|
|||
- 'app/models/provisioning_template.rb'
|
|||
- 'app/models/ptable.rb'
|
|||
- 'app/models/puppetclass.rb'
|
|||
- 'app/models/taxonomies/location.rb'
|
|||
- 'app/models/taxonomies/organization.rb'
|
|||
# Offense count: 43
|
|||
| ce761fd9 | Tomer Brisker | # Configuration parameters: Include.
|
|
# Include: app/models/**/*.rb
|
|||
Rails/HasManyOrHasOneDependent:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 100
|
|
| 43773332 | Michael Moll | # Configuration parameters: Include.
|
|
# Include: app/helpers/**/*.rb
|
|||
Rails/HelperInstanceVariable:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 6
|
|
# Cop supports --auto-correct.
|
|||
Rails/IndexBy:
|
|||
Exclude:
|
|||
- 'app/controllers/concerns/foreman/controller/smart_proxy_auth.rb'
|
|||
- 'app/models/concerns/audit_search.rb'
|
|||
- 'app/models/feature.rb'
|
|||
- 'app/models/setting.rb'
|
|||
- 'app/services/facets.rb'
|
|||
- 'app/services/structured_fact_importer.rb'
|
|||
# Offense count: 5
|
|||
# Cop supports --auto-correct.
|
|||
Rails/IndexWith:
|
|||
Exclude:
|
|||
- 'app/controllers/hosts_controller.rb'
|
|||
- 'app/models/concerns/audit_associations.rb'
|
|||
- 'app/models/smart_proxy.rb'
|
|||
- 'test/active_support_test_case_helper.rb'
|
|||
- 'test/factories/smart_proxy.rb'
|
|||
| 49f17215 | Michael Moll | # Offense count: 52
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: Include.
|
|
# Include: app/models/**/*.rb
|
|||
Rails/InverseOf:
|
|||
Enabled: false
|
|||
| 49f17215 | Michael Moll | # Offense count: 13
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: Include.
|
|
# Include: app/controllers/**/*.rb
|
|||
Rails/LexicallyScopedActionFilter:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/api/base_controller.rb'
|
|||
- 'app/controllers/api/v2/auth_sources_controller.rb'
|
|||
- 'app/controllers/api/v2/base_controller.rb'
|
|||
- 'app/controllers/api/v2/operatingsystems_controller.rb'
|
|||
- 'app/controllers/concerns/api/v2/lookup_keys_common_controller.rb'
|
|||
- 'app/controllers/concerns/api/v2/taxonomies_controller.rb'
|
|||
- 'app/controllers/concerns/foreman/controller/auto_complete_search.rb'
|
|||
- 'app/controllers/concerns/foreman/controller/set_redirection_path.rb'
|
|||
- 'app/controllers/concerns/foreman/controller/users_mixin.rb'
|
|||
- 'app/controllers/lookup_keys_controller.rb'
|
|||
# Offense count: 17
|
|||
| 9645d895 | David Davis | # Configuration parameters: Include.
|
|
| f0091ac8 | Dominic Cleal | # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
|
|
| 7ebd35e7 | David Davis | Rails/Output:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/helpers/puppetclasses_and_environments_helper.rb'
|
|||
- 'app/models/concerns/encrypt_value.rb'
|
|||
- 'config/initializers/2_rbvmomi.rb'
|
|||
- 'config/initializers/apipie.rb'
|
|||
- 'config/initializers/sig_ttin_trap.rb'
|
|||
- 'config/puma/production.rb'
|
|||
- 'db/seeds.d/035-admin.rb'
|
|||
- 'db/seeds.d/050-taxonomies.rb'
|
|||
# Offense count: 82
|
|||
| e7e5ef3e | Tomer Brisker | Rails/OutputSafety:
|
|
Enabled: false
|
|||
| 8823aa3a | Michael Moll | # Offense count: 14
|
|
| 11346a09 | Ondřej Ezr | # Cop supports --auto-correct.
|
|
| 8823aa3a | Michael Moll | # Configuration parameters: Include.
|
|
# Include: **/Rakefile, **/*.rake
|
|||
Rails/RakeEnvironment:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'lib/capistrano/tasks/**/*.rake'
|
|||
- 'lib/tasks/apipie.rake'
|
|||
- 'lib/tasks/encrypt.rake'
|
|||
- 'lib/tasks/fix_cache.rake'
|
|||
- 'lib/tasks/gettext.rake'
|
|||
- 'lib/tasks/jenkins.rake'
|
|||
- 'lib/tasks/pkg.rake'
|
|||
- 'lib/tasks/plugin_apipie.rake'
|
|||
- 'lib/tasks/security.rake'
|
|||
# Offense count: 8
|
|||
# Cop supports --auto-correct.
|
|||
Rails/RedundantForeignKey:
|
|||
Exclude:
|
|||
- 'app/models/concerns/facets/hostgroup_facet.rb'
|
|||
- 'app/models/fact_value.rb'
|
|||
- 'app/models/operatingsystem.rb'
|
|||
- 'app/models/provisioning_template.rb'
|
|||
- 'app/models/ptable.rb'
|
|||
- 'app/models/template.rb'
|
|||
- 'app/models/usergroup.rb'
|
|||
| 8823aa3a | Michael Moll | ||
| 66d9e79a | Michael Moll | # Offense count: 3
|
|
Rails/ReflectionClassName:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/concerns/facets/model_extensions_base.rb'
|
|||
- 'app/models/provisioning_template.rb'
|
|||
- 'app/models/ptable.rb'
|
|||
| 66d9e79a | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 11
|
|
| aa7637bb | Tomer Brisker | # Configuration parameters: Include.
|
|
# Include: db/migrate/*.rb
|
|||
Rails/ReversibleMigration:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'db/migrate/20130908170524_add_keys.rb'
|
|||
- 'db/migrate/20140219183342_change_label_to_title.rb'
|
|||
- 'db/migrate/20180715202514_optimize_indices.rb'
|
|||
# Offense count: 196
|
|||
# Configuration parameters: ForbiddenMethods, AllowedMethods.
|
|||
# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
|
|||
| aa7637bb | Tomer Brisker | Rails/SkipsModelValidations:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 24
|
|
| 43773332 | Michael Moll | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| aa7637bb | Tomer Brisker | # SupportedStyles: strict, flexible
|
|
Rails/TimeZone:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/jobs/template_render_job.rb'
|
|||
- 'app/models/host_facets/reported_data_facet.rb'
|
|||
- 'app/models/stored_value.rb'
|
|||
- 'app/models/upgrade_task.rb'
|
|||
- 'app/services/ping.rb'
|
|||
- 'test/controllers/api/v2/personal_access_tokens_controller_test.rb'
|
|||
- 'test/controllers/api/v2/report_templates_controller_test.rb'
|
|||
- 'test/controllers/unattended_controller_test.rb'
|
|||
- 'test/factories/stored_values.rb'
|
|||
- 'test/graphql/queries/host_query_test.rb'
|
|||
- 'test/models/hosts/managed_test.rb'
|
|||
- 'test/models/stored_value_test.rb'
|
|||
- 'test/models/upgrade_task_test.rb'
|
|||
- 'test/subscribers/foreman/base_subscriber_test.rb'
|
|||
- 'test/unit/host_fact_importer_test.rb'
|
|||
# Offense count: 42
|
|||
# Configuration parameters: Include.
|
|||
# Include: app/models/**/*.rb
|
|||
Rails/UniqueValidationWithoutIndex:
|
|||
| aa7637bb | Tomer Brisker | Enabled: false
|
|
| 66d9e79a | Michael Moll | # Offense count: 8
|
|
| 0c774a3a | Shlomi Zadok | # Cop supports --auto-correct.
|
|
# Configuration parameters: AutoCorrect.
|
|||
Security/JSONLoad:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/lookup_keys/lookup_key.rb'
|
|||
- 'app/services/foreman/importer_puppetclass.rb'
|
|||
- 'app/services/foreman/parameters/caster.rb'
|
|||
- 'lib/tasks/parameters.rake'
|
|||
- 'test/unit/rabl_test.rb'
|
|||
| 0c774a3a | Shlomi Zadok | ||
| 11346a09 | Ondřej Ezr | # Offense count: 21
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| aa7637bb | Tomer Brisker | Security/YAMLLoad:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/compute_resources/foreman/model/vmware.rb'
|
|||
- 'app/models/lookup_keys/lookup_key.rb'
|
|||
- 'app/models/report.rb'
|
|||
- 'app/models/setting.rb'
|
|||
- 'app/services/foreman/importer_puppetclass.rb'
|
|||
- 'app/services/foreman/parameters/caster.rb'
|
|||
- 'config/boot_settings.rb'
|
|||
- 'config/settings.rb'
|
|||
- 'db/migrate/20101019183859_convert_reports.rb'
|
|||
- 'db/migrate/20140219183343_migrate_permissions.rb'
|
|||
- 'db/migrate/20150312144232_migrate_websockets_setting.rb'
|
|||
- 'db/migrate/20190801143210_convert_dns_conflict_timeout_setting.rb'
|
|||
- 'lib/tasks/parameters.rake'
|
|||
- 'lib/tasks/puppet.rake'
|
|||
- 'test/factories/reports_related.rb'
|
|||
| 7ebd35e7 | David Davis | ||
| 11346a09 | Ondřej Ezr | # Offense count: 1
|
|
# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
|
|||
| 8c84f5b5 | Michael Moll | # SupportedStyles: inline, group
|
|
Style/AccessModifierDeclarations:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
| e14eace6 | Leos Stejskal | - 'app/services/foreman/observable.rb'
|
|
| 8c84f5b5 | Michael Moll | ||
| 11346a09 | Ondřej Ezr | # Offense count: 203
|
|
| 7386f11b | Michael Moll | # Cop supports --auto-correct.
|
|
# Configuration parameters: AutoCorrect, EnforcedStyle.
|
|||
| f0091ac8 | Dominic Cleal | # SupportedStyles: nested, compact
|
|
| 7ebd35e7 | David Davis | Style/ClassAndModuleChildren:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 11
|
|
| 7ebd35e7 | David Davis | Style/ClassVars:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/helpers/templates_helper.rb'
|
|||
- 'app/models/concerns/encrypt_value.rb'
|
|||
- 'app/models/setting.rb'
|
|||
- 'app/models/template_kind.rb'
|
|||
- 'test/active_support_test_case_helper.rb'
|
|||
| 7ebd35e7 | David Davis | ||
| 49f17215 | Michael Moll | # Offense count: 8
|
|
| a9d8cde5 | David Davis | # Cop supports --auto-correct.
|
|
| 7ebd35e7 | David Davis | # Configuration parameters: Keywords.
|
|
| f0091ac8 | Dominic Cleal | # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
|
|
| 7ebd35e7 | David Davis | Style/CommentAnnotation:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/models/environment_class.rb'
|
|||
- 'app/models/lookup_value.rb'
|
|||
- 'app/models/smart_proxy.rb'
|
|||
- 'app/services/facets.rb'
|
|||
- 'config/initializers/apipie.rb'
|
|||
- 'lib/core_extensions.rb'
|
|||
- 'test/models/usergroup_test.rb'
|
|||
- 'test/unit/compute_resource_host_importer_test.rb'
|
|||
| 7ebd35e7 | David Davis | ||
| 11346a09 | Ondřej Ezr | # Offense count: 21
|
|
# Configuration parameters: EnforcedStyle.
|
|||
# SupportedStyles: allowed_in_returns, forbidden
|
|||
| 7ebd35e7 | David Davis | Style/DoubleNegation:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/helpers/form_helper.rb'
|
|||
- 'app/jobs/template_render_job.rb'
|
|||
- 'app/models/auth_sources/auth_source_ldap.rb'
|
|||
- 'app/models/host/base.rb'
|
|||
- 'app/models/template.rb'
|
|||
| 233068a8 | Ondřej Ezr | - 'app/registries/foreman/settings/auth.rb'
|
|
| 11346a09 | Ondřej Ezr | - 'app/services/foreman/render_templates_from_folder.rb'
|
|
| 642a7df0 | Leos Stejskal | - 'app/services/foreman/renderer/scope/variables/base.rb'
|
|
| 11346a09 | Ondřej Ezr | - 'config/application.rb'
|
|
- 'db/migrate/20110301154453_add_managed_to_hosts.rb'
|
|||
- 'db/migrate/20150312144232_migrate_websockets_setting.rb'
|
|||
- 'lib/foreman/telemetry.rb'
|
|||
- 'test/controllers/api/v2/report_templates_controller_test.rb'
|
|||
- 'test/controllers/report_templates_controller_test.rb'
|
|||
- 'test/factories/disable_auditing.rb'
|
|||
| 7ebd35e7 | David Davis | ||
| 11346a09 | Ondřej Ezr | # Offense count: 1
|
|
# Cop supports --auto-correct.
|
|||
Style/ExpandPathArguments:
|
|||
Exclude:
|
|||
- 'config.ru'
|
|||
# Offense count: 162
|
|||
| aa7637bb | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: format, sprintf, percent
|
|
| 7ebd35e7 | David Davis | Style/FormatString:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 393
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: annotated, template, unannotated
|
|||
| aa7637bb | Tomer Brisker | Style/FormatStringToken:
|
|
| 1b276e91 | Michael Moll | Enabled: false
|
|
| aa7637bb | Tomer Brisker | ||
| 11346a09 | Ondřej Ezr | # Offense count: 5
|
|
| aa7637bb | Tomer Brisker | # Configuration parameters: AllowedVariables.
|
|
Style/GlobalVars:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'lib/tasks/errors.rake'
|
|||
- 'lib/tasks/exports.rake'
|
|||
| aa7637bb | Tomer Brisker | ||
| 11346a09 | Ondřej Ezr | # Offense count: 186
|
|
| 7ebd35e7 | David Davis | # Configuration parameters: MinBodyLength.
|
|
Style/GuardClause:
|
|||
Enabled: false
|
|||
| aa7637bb | Tomer Brisker | # Offense count: 2
|
|
Style/IdenticalConditionalBranches:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/services/puppet_fact_parser.rb'
|
|||
| aa7637bb | Tomer Brisker | ||
| 86fa34ae | Michael Moll | # Offense count: 11
|
|
| 49f17215 | Michael Moll | # Configuration parameters: AllowIfModifier.
|
|
| f0091ac8 | Dominic Cleal | Style/IfInsideElse:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/concerns/application_shared.rb'
|
|||
- 'app/controllers/concerns/foreman/controller/smart_proxy_auth.rb'
|
|||
- 'app/controllers/concerns/foreman/controller/taxonomy_multiple.rb'
|
|||
- 'app/controllers/puppetclasses_controller.rb'
|
|||
- 'app/controllers/users_controller.rb'
|
|||
- 'app/models/concerns/audit_extensions.rb'
|
|||
- 'app/models/concerns/puppet_host_extensions.rb'
|
|||
- 'app/models/host_status/build_status.rb'
|
|||
- 'app/models/template.rb'
|
|||
- 'config/application.rb'
|
|||
| f0091ac8 | Dominic Cleal | ||
| 11346a09 | Ondřej Ezr | # Offense count: 58
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| 8c84f5b5 | Michael Moll | # Configuration parameters: IgnoredMethods.
|
|
| aa7637bb | Tomer Brisker | Style/MethodCallWithoutArgsParentheses:
|
|
| 7ebd35e7 | David Davis | Enabled: false
|
|
| 11346a09 | Ondřej Ezr | # Offense count: 150
|
|
| f0091ac8 | Dominic Cleal | # Cop supports --auto-correct.
|
|
| 43773332 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
# SupportedStyles: literals, strict
|
|||
| f0091ac8 | Dominic Cleal | Style/MutableConstant:
|
|
Enabled: false
|
|||
| 49f17215 | Michael Moll | # Offense count: 22
|
|
| a9d8cde5 | David Davis | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, MinBodyLength.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: skip_modifier_ifs, always
|
|
| 7ebd35e7 | David Davis | Style/Next:
|
|
Enabled: false
|
|||
| e7e5ef3e | Tomer Brisker | # Offense count: 1
|
|
# Cop supports --auto-correct.
|
|||
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedOctalStyle.
|
|
| e7e5ef3e | Tomer Brisker | # SupportedOctalStyles: zero_with_o, zero_only
|
|
Style/NumericLiteralPrefix:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'config/initializers/secret_token.rb'
|
|||
| e7e5ef3e | Tomer Brisker | ||
| 11346a09 | Ondřej Ezr | # Offense count: 47
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| aa7637bb | Tomer Brisker | # Configuration parameters: Strict.
|
|
| 7ebd35e7 | David Davis | Style/NumericLiterals:
|
|
MinDigits: 15
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 202
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
# Configuration parameters: PreferredDelimiters.
|
|||
Style/PercentLiteralDelimiters:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 85
|
|
| e7e5ef3e | Tomer Brisker | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: compact, exploded
|
|
| 7ebd35e7 | David Davis | Style/RaiseArgs:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 67
|
|
| a9d8cde5 | David Davis | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: slashes, percent_r, mixed
|
|
| 7ebd35e7 | David Davis | Style/RegexpLiteral:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 64
|
|
| a9d8cde5 | David Davis | # Cop supports --auto-correct.
|
|
| 7ebd35e7 | David Davis | Style/RescueModifier:
|
|
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 184
|
|
| 1b276e91 | Michael Moll | # Cop supports --auto-correct.
|
|
# Configuration parameters: EnforcedStyle.
|
|||
# SupportedStyles: implicit, explicit
|
|||
Style/RescueStandardError:
|
|||
Enabled: false
|
|||
| 11346a09 | Ondřej Ezr | # Offense count: 8
|
|
| 7ebd35e7 | David Davis | # Cop supports --auto-correct.
|
|
| 1b276e91 | Michael Moll | # Configuration parameters: EnforcedStyle.
|
|
| f0091ac8 | Dominic Cleal | # SupportedStyles: only_raise, only_fail, semantic
|
|
| 7ebd35e7 | David Davis | Style/SignalException:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/controllers/concerns/foreman/controller/registration.rb'
|
|||
- 'app/models/concerns/orchestration.rb'
|
|||
- 'app/services/facets/entry.rb'
|
|||
- 'lib/foreman/logging.rb'
|
|||
| 7ebd35e7 | David Davis | ||
| 43773332 | Michael Moll | # Offense count: 8
|
|
# Cop supports --auto-correct.
|
|||
Style/StderrPuts:
|
|||
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'lib/tasks/config.rake'
|
|||
- 'lib/tasks/seed.rake'
|
|||
- 'script/plugin_webpack_directories.rb'
|
|||
| 43773332 | Michael Moll | ||
| 66d9e79a | Michael Moll | # Offense count: 2
|
|
| 11346a09 | Ondřej Ezr | # Cop supports --auto-correct.
|
|
| a9d8cde5 | David Davis | Style/StructInheritance:
|
|
| 11346a09 | Ondřej Ezr | Exclude:
|
|
- 'app/services/jwt_token.rb'
|
|||
- 'test/models/host_status/global_test.rb'
|
|||
| a9d8cde5 | David Davis | ||
| 11346a09 | Ondřej Ezr | # Offense count: 100
|
|
| 9645d895 | David Davis | # Cop supports --auto-correct.
|
|
# Configuration parameters: IgnoredMethods.
|
|||
| e7e5ef3e | Tomer Brisker | # IgnoredMethods: respond_to, define_method
|
|
| 9645d895 | David Davis | Style/SymbolProc:
|
|
Enabled: false
|