Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #19874 - Fix Style/MultilineMemoization cop

Fixes #7451 - Review whitespace in extracted strings

Fixes #20807 - Remove deprecations for 1.18

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #11389 - Remove API v1

API v1 has been deprecated since Foreman 1.9 - over 2 years ago.
This is more then enough time for anyone needing to migrate to v2.
Even though the original issue requests extraction to a plugin, I do not
see any point in investing the time and effort to maintain a long...

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #15402 - Moved puppet to separate api controller

Fixes #21119 - set taxonomies in API

With this we correctly set the default taxonomy for non-admin users
in API calls. Admins are not touched at all, their context remains
"any context" for API calls. This also refactors various places
where tried to set the right taxonomy and combines them into single...

Fixes #17087 - default and overrides values converted to string

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

fixes #18982 - replace AC::Params#each using one-arg block

ActionController::Parameters#each works differently in Rails 5.0: it no
longer yields an array of [key, value] entries for hashes, only the
key when given a block with arity of one. This method now iterates over...

Fixes #18582 - add missing id params to taxonomy apidoc

Fixes #12294 - Update existing params using API

Refs #15779 - make background processing unavailable for now (#4217)

The original PR got vetted in the packaging phase and including
foreman-task as dependency of Foreman was refused. We need to rethink
our approach for getting the foreman-tasks functionality available...

Refs #17653 - fix typo in show_hidden_parameters and add tests

Refs #17653 - add show_hidden to apidoc

Fixes #6502 - List ignored classes and environments on import

When importing environments and classes from puppet, ignored
environments and classes defined in ignored_environments.yml
aren't aparent.

This will add them to the list to import as ignored and...

Fixes #15779 - make background processing available

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

fixes #16798 - move scoped_search definitions to STI subclasses

scoped_search doesn't support class inheritance with STI, so registering
definitions on the subclass fixes various issues. This fixes an issue
where scoped_search on CommonParameter calls Parameter.all and is...

Fixes #17104 - ignore resource via API

Fixes #15703 - Singularize media in api doc for orgs

Fixes #15833 - remove duplicities in smart params listings

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

fixes #15720 - rename *_filter to *_action

The older 'filter' name is changing in Rails to 'action' and is being
deprecated.

Fixes #15268 - limit user taxonomies using my scopes

Fixes CVE-2016-4475

Fixes #15182 - limit user taxonomies in API (CVE-2016-4451)

Fixes #14546 - ability to restrict *_external_variables
Fixes #14535 - corrects permissions for smart class parameters

Fixes #15174 - make sure to return 404 when taxonomy not found

Refs #3809 - Turning on some rubocop cops

Fixes #13257 - nested locations can be created via api

Fixes #12566 - host_parameters_attributes accepts nested flag

Fixes #7230, #12021 - Upgrade to Rails 4.1.5

This commits upgrades Rails to Rails 4.1.5. See a description of the
changes included here, and go to the pull request in GitHub to see more
detailed explanations:

• Update gems to a Rails 4 compatible version, including dependencies...

Fixes #10988 - Remove 1.11 deprecations

fixes #10832 - separating lookup keys into puppet and variable

fixes #11175 - [API] Add taxonomies to ptables, display ptables in taxonomies

fixes #11018 - correct syntax error in version number

Fixes #10635 - Formalize deprecation warning

Fixes #10853 - add config_template_ids back to organization

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Fixes #10715 - api build_pxe_default returns non-JSON message

The fix adds a new method `render_message` for responding with a status
text.

Fixes #7378 - fixed API lookup keys filters

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

Fixes #8838 - Replace HTTP error codes with human-readable symbols

Fixes #8764 - adds description to taxonomies

Refs #3809 - Remove useless assignments

fixes #3492 - API v2 nested routes for each controller

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

fixes #6856 - API v2 - more efficient import puppetclasses for single environment

fixes #4386 - gem friendly_id to simplify find by id, name, label, etc

Fixes #2524 - adding taxonomy scope parameters

Fixes #5088 - adding location_ids and organizations_ids to apidocs of taxable resources

Fixes #7261 - API v2 - mark wrapped params hash for POST/PUT as required instead of optional

Fixes #7028 - completing api docs for taxonomies

Fixes #6929 - Rephrase description string for api import_puppetclasses

Fixes #6786 - Handle error when no taxonomy params get sent

Basically, no organization params are getting sent as the bug reporter is not
using json and not using wrapped params. You can also test this by doing:

curl -X POST http://localhost:3000/api/v2/organizations...

Refs #4478 - API doc strings marked for translation

fixes #1809 - foreman realm integration

Fixes #4851: a SmartProxy.with_features scope replaces feature-specific scopes generated during class loading

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4393 - rename ancestry label to title

fixes #3912 - add inheritance for locations / organizations

fixes #3553 - add "except" option to prevent puppet class import to select types of import

fixes #3925 - create apipie param_groups for API v2 to DRY documentation

fixes #3760 - API v2 define metadata @total for each controller

fixes #3515 - API handles not found objects with 404

fixes #3853 - allow rabl template override to be specified

3853-taxonomy-rabl - changed style of override

fixes #3018 - API v2 metadata for pagination, search, order in index collection json response

fixes #3011 - default root node name for api collections json response to :results but make it configurable

fixes #3577 - do not treat `params[:dryrun]` with value `false` as true

fixes #3550 - correct HTTP method for puppet class import API

fixes #3538 - workaround for broken #pluck on lower Rails versions

fixes #3140 continue - apipie params fix

fixes #3140 - API to allow importing of puppet classes

fixes #2810 - more restful API v2 JSON responses in puppetclasses

NOTE: breaking changes to API v2 api/lookup_keys does not exist, replaced by api/smart_variables and api/smart_class_parameters

fixes #2869 - refactor method find_nested_obj into API::BaseController

fixes #2838 - taxonomies controller - fix in params and finder

fixes #2411 - move to controller/concerns

fixes #2525 - apipie documentation of actions defined in a concern

Apipie now supports defining actions defined in module by including
`Apipie::DSL::Concern`. Some substitutions are preformed while
including the documentation in each controller, so that instead of...

upgrade foreman to rails 3.2.13

This commit updates from rails 3.0.x to 3.2.x, main changes include:

• Asset pipline support
• cleanup of existing assets (javascript, css, images)

Users who uses foreman in production, make sure that you now compile
your assets, e.g...

fixes #2275 - include ThreadSession::Cleaner only once

Foreman::ThreadSession::Cleaner was included in Taxonomy concern,
which postponed the session clearing (that should be the first thing
to happen in filters) to phase after :authorize filter, effectively...

fixes #2239 API v2 CRUD for locations and organizations and added nested loc/org