Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #23976 - Add Quota to oVirt API (#5715)

Fixes #21007 - new unattended action 'failed'

Fixes #20891 - Remove hostname from /hosts/x/facts results

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #22058 - refresh rubocop config and apply autofixes

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Refs #23776 - correct deprecation for notice

Fixes #23776 - Remove deprecations for 1.18

Fixes #23769 - consistency in docs for foreman/katello

Fixes #22778 - disableable bruteforce protection

fixes #23357 - Refactor Notification Drawer from patternfly-react

Fixes #23487 - support namespaced controllers

Fixes #23646 - Remove storeconfig leftovers

In Foreman 1.1 sharing the database with Puppet's storeconfigs was
deprecated. We've given users sufficient time to migrate away from it
and possibly broke it along the way. I haven't checked.

Fixes #23426 - support default flag in templates import

Fixes #22847 - Use pf-react donut chart in facts page

Fixes #18429 - Add foreman API support for trends

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Refs #23177 - id is not used for unattended order

fixes #23335 - normalize scsi attributes in rails 5 (#5475)

Fixes #23177 - unattended warning on multiple MACs

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Fixes #23225 - fix vm tab js error in host page

Fixes #22855 - Add full breadcrumbs functionality

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #21055 - use _id attributes for host taxonomy validator

Otherwise, the error messages are not visible.

Also log the host error messages as `error` instead of `info`, as it
should be more appropriate for this case.

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #22893 - Specify taxonomies on template import (#5323)

fixes #21694 - Add MTU to subnet and interface API

fixes #21694 - Add MTU to subnet

Fixes #23079 - Fix Naming/HeredocDelimiterCase cop

Fixes #23075 - Fix Rails/HttpStatus cop

Fixes #23064 - log log in and log out activities

Fixes #19895 - Fix Style/RedundantReturn cop

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Refs #22285 - Correct parameter filtering for strong params

- Allow $resource_id param on parameters controller
- Permit user_id on access token controller
- Allow params in templete combination controller
Allows `config_template_id` and `:provisioning_template_id`...

Refs #22285 - Remove keep_param

This workaround was needed in Rails 5.0, but 5.1 already supports
filtering on arbitrary hash params.

Fixes #19874 - Fix Style/MultilineMemoization cop

Fixes #19857 - Fix Style/EachWithObject cop

Fixes #22236 - Adds breadcrumbs to foreman UI

Fixes #23046 - gateway parameter for subnet corrected

Fixes #23028 - Properly escape params passed to where (CVE-2018-1096) (#5363)

Fixes #22624 - User selectable columns model + api

Adding initial bindings to user selectable columns. This model + api is
going to be used in work related Katello plugin's subscription pages.
The main intesnt of this PR is to provide a basic model where a user can...

Fixes #22869 - support template locking on import

Fixes #2828 - Report an error when trying to save ovirt resource

On both create and update, there was no exception handler to captured
given exception. That resulted in having an exception screen instead of
an error message.
The fix capture all of the given exceptions, and report them as an...

Fixes #15984 - Avoid escaping overridden parameters (#5126)

Fixes #15286 - New API for auth sources (#4865)

Fixes #22096 - Make Audits taxable (#5269)

Fixes #22891 - add log for failed login attempt

Fixes #22756 - Allow provisioning based on MAC address

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #22358 - add templates importing

Fixes #22753 - add apipie validator for multiple allowed types

Fixes #22721 - Rename setting to trusted_hosts

The setting trusted_puppetmaster_hosts is used to allow hosts to submit
stuff to the facts/reports API endpoint.
The name made sense a long time ago, but these days other plugins and
any user can submit stuff to this API to generate...

Fixes #22747 - vet puppetclass_id on addition

Fixes #21999,#22005 - Migrate toasts to pf-react

• Replace Alert and Toasts components with patternfly-react
• Refactor the server side flash-notification
• Allow rails-flah-notification to react-toast-notification with link

Fixes #22615 - template rendering is kept inline

Fixes #18675 - telemetry foreman API

Fixes #22403 - every API endpoint can set current context

Fixes #22069 - Add proxy version mismatch warning

Fixes #22557 - use correct type for 'provision_method' param

Fixes #22379 - Remove pagination from csv export (#5204)

fixes #22411 - unattended: render template macros from plugins

fixes #22444 - do not serve templates with expired token

Fixes #7451 - Review whitespace in extracted strings

Refs #20800 - Move session timed out warning inline

Fixes #22424 - Update Apipie doc for hostgroup

Fixes #17964 - Add list of search fields in api docs (#4735)

Fixes #21871 - Fix searching by locations

Fixes #19889 - Fix Style/PerlBackrefs cop

Fixes #22327 - Fix Lint/MissingCopEnableDirective cop

Fixes #20807 - Remove deprecations for 1.18

Fixes #22359 - Don't rely on default taxonomy in API for any user (#5202)

Fixes #21317 - graceful handling of VM association error

Instead of immediate failure, just log the issue and proceed with the
import.

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #11389 - Remove API v1

API v1 has been deprecated since Foreman 1.9 - over 2 years ago.
This is more then enough time for anyone needing to migrate to v2.
Even though the original issue requests extraction to a plugin, I do not
see any point in investing the time and effort to maintain a long...

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #5790 - Add compute resource to hostgroup (#4593)

fixes #22062 - support vmware vmrc console

Fixes #19878 - Fix Style/NestedModifier cop

Fixes #19782 - Fix Layout/MultilineArrayBraceLayout cop

Fixes #19788 - fix Layout/SpaceAroundBlockParameters cop

Fixes #19769 - Fix Layout/CommentIndentation cop

Fixes #19780 - fix Layout/IndentationWidth cop

fixes #20839 - new react implementation for bookmarks dropdown

Refs #11153 - rescue from ldap errors

Fixes #21760 - Fix tests on Rails 5.1

Fixes #21343 - support multiple orgs supported for non-admin users

• Fixes #21343 - support multiple orgs supported for non-admins

This adds a full support for taxonomies in API for non-admin users. It
fixes the issue with dirty associations module that only track _ids...

Fixes #19772, #19773, #19774 - Fix some empty line cops

fixes #21825 - external nodes html content type