Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

Fixes #12216 - support http proxies for compute resources

Fixes #20952 - Replace AC::Parameters Hash methods

Replaces any methods that used to be from Hash with the more limited
ActionController::Parameters API.

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #17015 - Adds Key pairs controller

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

Fixes #16619 - Set EC2 VPC instance private IP from primary NIC

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

Refs #3809 - Turning on the AndOr cop

fixes #14415 - check CR availability with Fog, not SETTINGS

Simplifies the code for checking compute resource availability, which
can easily be determined with the registered Fog providers instead of
being stored in SETTINGS in app initialisation. Plugins should always be...

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

Fixes #3650, #11600 - Compute Resource availability_zones, flavors, security_groups API v2 endpoints

Refs #3809 - Enable Rails delegate cop

Fixes #10248 - cloning volume information for virtual machines

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

fixes #9240 - in case of hash with indifferent access, serialize as hash

fixes #9249 - associated_host fixed for all compute resources

fixes #6098 - ec2 compute resources now check image validity.

Fixes #5999 - vpc + pub ip -> attach pub ip

Refs #3809 - Remove useless assignments

Fixes #8258 - CR provider errors with correct log level

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

fixes #4111 - Add image user data flag to API

Fixes #6099 - Bubble Fog::Errors up to Host

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4023 - API v2 - compute resources partials should should attribute alias names and not database column names

fixes #2741 - rails 3 syntax

fixes #1871, #1879 - add VPC support to EC2 compute resource

Based on patch from Romain Vrignaud <romain@yakaz.com>

fixes #1923 - matches vms on a compute resource to hosts

fixes #2411 - move STI models in /models and /lib/foreman/models to sub-folders