Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Fixes #22079 - Fix Lint/UriRegexp cop

Fixes #21675 - OpenStack create host tab fails to load

Currently the tab is not loading as there are a few methods that are not
being overridden properly by the FogExtension.

After fixing that and adding the metadata key the tab loads

Fixes #12054 - Openstack v3 support

Fixes #19326 - create compute-resource - URL optional

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19459 - improve vm boot failure feedback

To be able to override the wait for vm ready we need to move
it to compute resource definition. Also improve Openstack one

Fixes #19377 - available_flavors for OpenStack

fixes GET /api/v2/compute_resources/:id/available_flavors resulting in
"Not implemented for OpenStack".

Fixes #17015 - Adds Key pairs controller

fixes #16091 - Fixed association Foreman host with Compute VM

Fixes #15924 - Implement server groups and scheduler hints

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

Refs #3809 - Turning on some rubocop cops

fixes #14415 - check CR availability with Fog, not SETTINGS

Simplifies the code for checking compute resource availability, which
can easily be determined with the registered Fog providers instead of
being stored in SETTINGS in app initialisation. Plugins should always be...

Fixes #13356 - OpenStack volumes API v2 needs :name

Our code in uses :display_name as the name attribute to create
Openstack volumes.

Notice volume v2 API requires :name, while v1 just needs :display_name
https://github.com/fog/fog/blob/master/lib/fog/openstack/models/volume_v1/volume.rb...

Fixes #12949 - Allow selection of external networks as main network in Openstack

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

fixes #11341 - update fog to 1.34.0

fixes #10130 - availability zones should be available in open stack

fixes #10997 - update fog to 1.33.0

Fixes #11023 - Pass identity_endpoint to Openstack Fog 1.32.0

Fixes #10867 - OpenStack boot_from_volume is true only when checked

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

refs #4521 - Openstack Compute Resource: Boot from Volume on new Host

Refs #3809 - Remove cops for empty lines

fixes #9249 - associated_host fixed for all compute resources

Refs #3809 - Remove useless assignments

fixes #8302 - only return active images for openstack compute resources

Refs #3809 - Use parentheses in method definitions

fixes #3902 - [Openstack] allow selection of internal networks

This patch allows the user to select the internal network when deploying
a new instance in openstack.

In Grizlly, this was done automaticilly, with a nasty side effect, that
all internal networks would get assigned (didnt see that as i had only...

fixes #4111 - Add image user data flag to API

fixes #4612 show friendly CR names, fix typo in oVirt name

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4125 [Openstack] - host with auto assigned IPs can't be deleted

fixes #3867 - Wrong Compute Resource type shown on overview

Fixes #3927 - Allow VMs to provision via user-data

fixes #3178 - add feature for compute profiles for hostgroups and hosts

fixes #2741 - rails 3 syntax

fixes #1923 - matches vms on a compute resource to hosts

Fixes #2169 Openstack uses tenants

fixes #2411 - move STI models in /models and /lib/foreman/models to sub-folders