Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #21007 - new unattended action 'failed'

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #23913 - Stop auditing host status updates

Fixes #23800 - i18n for exceptions fixed

Fixes #23646 - Remove storeconfig leftovers

In Foreman 1.1 sharing the database with Puppet's storeconfigs was
deprecated. We've given users sufficient time to migrate away from it
and possibly broke it along the way. I haven't checked.

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23331 - grouped permissions for host disabled (#5468)

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Fixes #19840 - Fix Rails/ReadWriteAttribute cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #22918 - Audit all taxonomies assignments

We need to move all audited definitions to top of models because all
concerns can use audit_associations call which relies on audit being
already activated.

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #5790 - Add compute resource to hostgroup (#4593)

Fixes #21851 - Remove deprecations for 1.17

Fixes #21760 - Fix tests on Rails 5.1

fixes #21947 - host scopes include table name

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #21103 - Replace 'false' AR callback results with throw

Fixes #21565 - Orchestration on fact import

This adds the enable_orchestration_on_fact_import setting, which allows
a user to make Foreman perform host orchestration operations when a
host is updated from puppet fact upload

Fixes #21037 - use Host::Base as auditable_type

Otherwise, we are hitting "Invalid single-table inheritance type:
Host::Discovered is not a subclass of Host::Managed" when converting the
host from discovered to managed.

Fixes #15409 - Separated puppet facts from core

Fixes #20955 - Remove conditions to {destroy, delete}_all calls

Fixes #20950 - Use 'distinct' in AR finders

Fixes #20516 - GET hosts API displays owner_name attribute

Fixes #20622 - puppet import does not refresh all statuses

Fixes #20248, #20327 - Respect context in CSV export

Since CSV export is done using an enumerator which is executed by a
different thread to the one that creates it, we need to manually pass in
the context (user, location, organization) to the enumerator.

Fixes #20401 - Allow pxe_loader in the Jail

Fixes #19826 - Fix Rails/ActiveSupportAliases cop

Fixes #19828 - Fix Rails/Blank cop

I disabled the default UnlessPresent value since sometimes it's clearer
to use `unless attribute.present?` instead of `if attribute.blank?`.

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #18381 - PXE loader show inherited value in host/hostgroup

Fixes #16082 - Associate FactValues with Host::Base

To prevent regression in existing search functionality, this also
requires that the hostgroup relation will be moved to the base class as
well. Since Host::Managed inherits from Host::Base, this should not...

fixes #19087 - create host built notification from Host#built

Comparing the host's installed_at timestamp is unreliable on MySQL
databases, as the timestamp field has a limited granularity. Under Rails
5 in a sub-second test, this field will not be changed....

Fixes #15374 - move progress_report_id to Host::Base

fixes #18476 - users have ssh keys

Fixes #18800 - strong params no longer breaks inherited attrs

fixes #18681 - moves polymorphic subject into notification object

also adds host build, destroyed and missing owner UI notifications

Fixes #14013 - add a setting for default owner of new hosts

fixes #17533 - provision dhcp for bond child macs

fixes #18102 - a host cannot be backed by the same vm

fixes #18208 - replace audited-activerecord with audited (#4218)

Fixes #16752 - Extract template code from Host::Managed

Host::Managed contains a lot of code related with determining the
template that a host should have. Other Host objects such as
Host::Discovered might need that logic, without becoming a
Host::Managed....

Fixes #6952 - Set hostgroup after provisioning from pxe

After hostgroup provisioning, when the machine has registered
with foreman, it should be in the same hostgroup.
to achieve this behavier, the fact foreman_hostgroup should be
added to hostgroup provisioning template

Fixes #17680 - templates_used host helper

templates_used contains the names of all of the provisioning templates
kickstart used during a host build. This allows users to be able to
show the name of a provisioning template during PXEBoot, for example

Fixes #16740 - Access host params through macro

Fixes #17886 - move config groups under parameters

fixes #17853 - resolve ips in interface scope

Fixes #17257 - Allow specific configs to be recreated

fixes #15610 - choose firmware for vsphere vms

Fixes #6006 - Add options to disable updates from facts

Add option ignore_facts_for_operatingsystem:
    do not update system's operating system based on facts
  Add option ignore_facts_for_domain:
    do not update system's domain based on facts

Fixes #16987 - Added ability to apply facet attributes

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

Fixes #17006 - added SSH BMC provider

fixes #17071 - set ip after acquiring compute details

Fixes #17103 - search ignored taxonomies

When searching for ProvisioningTemplate we should respect also host
taxonomies ignore list.

fixes #16866 - don't call orchestration skip if unattended is off

Fixes #6492 - ipmi_boot permission renamed to ipmi_boot_hosts

Authorizer expects permission names to follow a convention
'action'_'controller'. However this permission was not following it, and
this prevented the permission from being applied properly.

Before this fix, only admins could call ipmi_boot. I've also added a...

Fixes #12864 - verify host owner taxonomies

Fixes #12535 - expose config_groups in ENC

fixes #16545 - correctly search for classes from YAML import

Prevents a full class hash of name => parameters being passed to the AR
finder when using a parameterized (hash-style) YAML format.

Fixes #16125 - add owner type validation

fixes #15590 - ipv6 tftp orchestration

Fixes #14771 - Show corresponding os list for arch

Fixes #12634 - New HW Model flag pxe_loader

Implementation of

https://github.com/theforeman/rfcs/blob/master/text/0001-PXE-Booting-UEFI.md

In short, new host/hostgroup flag PXE loader is added to specify TFTP
DHCP filename and Foreman now orchestrates all PXE-capable templates...

fixes #16243 - make Host::Managed.new's options arg optional

The options argument no longer exists on Rails 5 as it was part of the
support for protected_attrs. The argument list to .new should be handled
more defensively, like Host::Base.

Fixes #16197 - Host#smart_proxies returns only the host proxies

Doing the following:
- Create 2 smart proxies, one for dhcp/dns/tft/puppetca/puppet, another
for realms. Let's keep the realms proxy off, so it's unreachable.
- Create a hostgroup A that sets domain, subnet, realm, puppet_proxy,...

fixes #16199 - always run build related callbacks

Fixes #16061 - auto ip assignment for non-primary interfaces

Squashed commit with a test case and the changes Timo suggested thanks
for the help also tried to decrease complexity of my change.

fixes #15787 - update shoulda-matchers to 3.x

Contains changes to models for the new behaviour of the uniqueness
validation test, which saves a model with one value and then attempts
to validate a second.

NestedAncestryCommon's validation now doesn't fail when the specified...

fixes #15977 - change enc output in a compatible way

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Fixes #14518, #14516 - status change ignores validations

Refs #3809 - Using defaults for AndOr cop

Fixes #15773 - disambiguate table name

Refs #12193 - Remove remaining cached counters

Fixes #12193 - Stop using counter_cache for host[group] counts

This is aimed to prevent deadlocks caused by Rails' implementation of
counter_cache that is hit when multiple hosts are created or updated at
the same time. An added benefit is that the counters will now display...

fixes #14666 - support IPv6 in UI

Fixes #15644 - Move enable/skip_orchestration to Host::Managed

skip_orchestration and enable_orchestration were called in Host::Base
when importing facts. These two methods could not be called there
because they come from the Orchestration mixin which Host::Base does not...

Refs #3809 - Turning on the AndOr cop

Fixes #15601 - to_ip_address cannot retrieve PTR4 record

After some changes on the DNS orchestration, we removed `dns_ptr_record`
in favor of `dns_record(:ptr4)`. However, `host.to_ip_address` still
calls the old API. We should change that method to use the new API,...

fixes #13845 - remove 1.13 deprecations

fixes #14663 - support IPv6 DNS orchestration

Fixes #13164 - Add view_params permission

A new view_params permission was added for parameters inheriting from
Parameter object. The only exception is global parameters, which are
already handled by filter for CommonParameter resource.

This new permissions is also automatically added to viewer and site...

fixes #14664 - support IPv6 in Nic, Hosts and Hostgroups models

Fixes #6539 - missing templates error is now descriptive

fixes #14509 - refactor enc_output to be a generic exporter

Fixes #15046 - Add bmc_nic related attributes to jail

Refs #3809 - Turning on some rubocop cops

Fixes #14575 - fix domain ENC info

Fixes #14401 - Refreshing Host's global status not persisting to the database

fixes #14434 - refactor tokens into concern from observer

rails-observers is still required via audited, but this removes the
usage in Foreman itself and unifies token-related code.

Fixes #14102 - Full location and organization passed as YAML to the ENC

Fixes #5707 - disassociate does not appear for physical host

Fixes #13984 - inherit subnet from hostgroup even for image-based provisioning

Fixes #13913 - split importing of host and facts