fixes #10832 - separating lookup keys into puppet and variable

Refs #3809 - Stabby lambda syntax for oneliners

I started by spotting log.rb which didn't have a lambda wrapping its
default scope, as needed by Rails 4. Since the style guide and most
Rails 4 documents used the stabby lambda, I turned on the cop so that we...

Fixes #10656 - Prevent audits on counter cache update

Fixes #10583 - perform uniq in database instead of in memory when possible

Fixes #10288 - prevent audits on update of puppetclass total hosts counter

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

Fixes #5723 - Show host groups inherited via config groups in puppetclass index

Fixes #8414 - extracts validators from models

Also cleans up some unused validators looking for trailing whitespace
that is stripped by the StripWhitespaces concern.
Tried to make some sense from unmatching regexps and validation error
messages. Some validations might need a different regexp to check for what...

Fixes #844 #5725 - correct hosts count in puppetclass

Fixes #6710 - unicode characters in url parameters

Original methods to_param defined on resources called name.parameterize
to get rid of url-unsafe characters. This function unfortunately also
stripped off unicode characters.

Changes:
- parameterization extracted into a separate module Parameterizable...

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

fixes #7569 - add lambda to scopes that are missing callable object (lambda or Proc)

fixes #4386 - gem friendly_id to simplify find by id, name, label, etc

fixes #6636, #6657, #6694 - add field length validations, extend audit field length

fixes #6432 - add validation for attributes missing :presence => true and remove duplicate validation messages 'can't be blank'

fixes #5173 - sortable counters on list of config_groups for number of hosts, hostgroups and puppetclasses

fixes #4204 - add config groups feature - assign multiple config groups to a host or hostgroup

Fixes #4976 - ensure the process is really running inside a rake task

fixes #4682 - smart variable for a puppet class not showing in UI

fixes #4256 - makes columns sortable in the UI

fixes #4565 - puppet class free-text search is now significantly faster

fixes #3001 - Facts searchable by both host id and name

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #3693 - API v2 - accept GET json format of object in PUT/POST requests to add/remove has_many associations

fixes #3018 - API v2 metadata for pagination, search, order in index collection json response

fixes #2741 - rails 3 syntax

fixes #2985 - remove #as_json method from AR models since rabl views used for API

fixes #2550 Puppetclass search_by_host doesn't return all classes for an unknown host

Tests for puppetclass API searches on nonexistent hosts

Puppetclass search_by_host does not fail if Host does not belong to any Hostgroup

Puppetclass search_by_host query looks for distinct puppetclasses instead of pruning them afterwards...

fixes #2422 Rails 3.2: before_destroy / dependent => :destroy ordering

fixes #2421 added missing has_many :hostgroups and missing :dependent => destroy

fixes #2393 - Couple of models broken with audited 3.0.0

this is not a fix for the mass assignment problem, rather just to solve immedient packaing issue upstream.

a follow up on mass assignment should be done via another commit.

refs #2254 - STI Host relationships

Do not use :class_name in has_many :through, missed on for class_params

Fix Foreman SQL injection through search mechanism CVE-2012-5648

Fixes bug in Puppetclass search_for by host

fixes #1907 - audit log should contain puppet class assignments within a hostgroup

removed lower() on default_scope to get tests to pass in postgresql

fixes #1887
fixes #1839

fixes #832 - adds parameterized class support

Credits:
This patch is based on the original work of Olivier Favre
<olivier@yakaz.com> many many thanks!

• import class parameters, and try to understand their types
• support a complex matrix of environments, puppet classes and their...

refs #1556 Removed .id2name from env variable.

wip audits upgrade

Fixes puppetclasses search with pg database

The request is sorting the results on a field that isn't in the DISTINCT
SELECT'ed columns and pg doesn't like it.
Fixes #1607

added classes-filter to the puppet classes selection page. fixed the selected classes sort.

also fixes #1675

fixes #1609 - REST API calls /hosts/:id/puppetclasses fails for hosts with same class assigned directly and through host group

code smell

fixes #1509 - Foreman should use the proxy to import puppet classes

WIP rails3 migration

fixes #1309 - add dashes '-' to allowed class names

Signed-off-by: Florian Koch <florian.koch1981@googlemail.com>

fixes #1299 foreman don't remove the () from puppet class names

Signed-off-by: Florian Koch <florian.koch1981@googlemail.com>

fixes #1148 - CRUD on lookup values via the API

Fixes #954 - rdoc:generate continues if a single puppetdoc fails

Signed-off-by: Paul Kelly <paul.ian.kelly@googlemail.com>

fixes #777 - this enable auditing of when a host is changing its puppet class assignmetns

one limitation of this patch is that at the moment, each class change
gets its own audit record.

fixes #322 Ability to add custom variables and multiple values resovled
in a dynamic Hierarchally order

This commits introduces the ability to define variables per puppet
class.

additionally, each class can have multiple values, depends on the host
which is requesting that variable....

fixes #100 - Setting is now a ActiveRecord object

This allows users to manage foreman settings via the UI.

the UI is a bit ugly, but works :)

fixes #968 - cannot search a puppetclass by name

fixes #899 - There are numerous typos and formatting issues with the code

fixes #827 add support for retrieving classes per host via the api

This allows queries like
/hosts/fqdn/puppetclasses
/puppetclasses/klass/hosts

it also changes the puppetclasses urls to include the class name instead of its ID.

added search to puppet classes page #refs 719

fixed broken tests

added default order and paginations which
fixes #721
fixes #688

fixes #698 - Searching for puppetclass in json format gives 500 error

Fixes #450 - Environment imports lose their puppetclass associations

Fixes #366 - Redmine authorization port

This is a major feature which provides RBAC authorization within Foreman
a mental note to myself - never ever work on large commits

fixes #325 - Retrieve a list of all puppet classes using the REST API

Fixes #351 - puppet rdocs need a link to the class browser for that environment

Fixes #239 - Erases environments and puppetclasses

The fix also includes a page in which the use selects the additions
and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

fixes #365 - puppet rdoc generation fails with puppet 2.6

fixes #302 and all references to_label and to_s
removed references to all per_page settings as they are common now

Fixes #101 - Generate rdoc files and html links on the puppetclasses page

Rewite rdocs if required by the prepare phase
Incorporate Fank Sweetser's :: patch
Incorporate a url_helper suggested by Ohad
Added a new interface via links on the supported environments list

fixes #277 - add search options to puppet classes page

• added better module detection to properly show the module list
• Add sorting to module class lists
• Add description to each link

fixes #200 - Remove activescaffold from the puppet groups page

fixes #199 - adds a search functionality to puppetclass page

fixes #199 - Remove activescaffold from the puppetclasses page, search functionality will follow

added audting on architecture, hostgroup, operatingsystem and puppetclass

finished tests for environment

added test for pupetclass

Puppetclasses tests on green

fixes #119 - Recurse into module directories when looking for classes

fixes #89 - this adds basic graphs and charts for your inventory, it
also includes minor changes to the dashboard graphs

Added Groups to puppet classes, now its possible to associate a host with a group of classes
it also allowed to setup parameters per group and override them in the host level

I've done it late at night, so who knows :)

added import of puppet classes

Add support for multiple puppet classes per host / operating system / environment etc
this should enable a proper dropdowns when creating the gui part that shows possible puppet class / operating system / env combinations

fix external nodes to actully work with multiple puppet classes...