Fixes #36547 - Fix parsing of Ubuntu version in fact parsers

Fixes #36830 - transform_vars on preseed_path

Co-Authored-by: quartsize

Fixes #37367 - Switch to 'network' directive instead of ifcfg

Fixes #37231 - Handle incorrect domain setting display

Fixes #37244: Add new virtual hw versions for VSphere 8.0 and 8.0U2

See https://kb.vmware.com/s/article/1003746 for reference

Fixes #36023: Add missing VMWare GuestOS mappings

Fix Style/CommentAnnotation cop

Fixes #37043 - Inheritance overrides host facets

Refs #37179 - explicitly include SelectiveClone in facets

That way plugins that try to use Hostgroup.include don't fail with

undefined method `include_in_clone' for Hostgroup

Fixes #37179 - Clone hostgroup facets when cloning hostgroup

Fixes #37184 - Report template generates incorrect kernel version

Fixes #36891 - Provide a scope for email-notification-eligible users

Fixes #37015 - Refactor OwnerClassifier

- Introduce `classify_owner` class method for owner classification.
- Implement private method for input validation.
- Add error handling to raise the necessary exceptions.
- Add deprecation warning to the `user_or_usergroup` method.

Fixes #37087 - STI preparations for Ruby 3.0

Some of our STI models (host and subnet) have redefined initialization
method signature, which cause failures in code logic due to Ruby 3.0
more strict way of dealing with keyword arguments. As a first step
we must to comply with Rails' model initialization method signature....

Fixes #36741 - Check Ubuntu version more explicitly

If no minor version is defined, the function minor.to_i makes it a "0".
Accordingly, Ubuntu 20.04 is interpreted as "no subiquity/Autoinstall" - but,
if no minor version is given, Foreman should implicitly assume "latest"...

Fixes #36711 - Fix searching in settings

Fixes #36575 - Use apipie-dsl default model descriptions

fixes #36160 - Redefine append domain names setting

This PR aims to unify the format of host names stored in the database and the way they are displayed.
With this change, the name of the host is always going to be stored with the domain name appended.
The setting formerly named `append_domain_name_for_hosts` is now renamed to `display_fqdn_for_hosts`...

Refs #36575 - Avoid i18n during startup in owner_type validation

Fixes: 535d232934a5 ("Fixes #14013 - add a setting for default owner of new hosts")

Refs #36575 - Avoid i18n during startup in host name validation

Fixes: 060d2004d786 ("Fixes #20119 - Be more descriptive when validating hostname")

Refs #36575 - Avoid i18n during startup in hg root_pass

Fixes: 9c30b63eb1d2 ("fixes #6067 - UI inconsistency around root password limit 8 characters")

Refs #36575 - Avoid translations during startup on root_pass

Fixes: c4bfd47fc285 ("fixes #3725, #4167 - root password validations, remove default password")

Fixes #36796 - Make host_facts_updated event visible

Refs #36715 - Update fact_names description for facts_hash

Fixes #36786 - Permit Symbol for YAML.safe_load report parser

Fixes #36715 - Speed up host fact retrieval

Fixes #36466 - Allow gathering information on deleted records

Fixes #36699 - Reject invalid expiration dates for PATs

Previously invalid dates were silently discarded, resulting into PATs being
created without expiration dates.

Fixes #36104 - Distinguish host events

Refs #36537 - Drop description from setting search

The description is no longer a field so it can't be searched anymore. This is
not a real fix, but prevents internal server errors on the settings search.

Fixes: de56ffb28064

Refs #36219 - allow loading HashWithIndifferentAccess from YAML

Fixes: c9b82a573f64fe54e61d55f079adeb1df3d0cae8

Fixes #36219 - use YAML.safe_load instead of YAML.load

as explained in this rubocop rule https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/YAMLLoad

Fixes #35942 - pass from settings not encrypted

Fixes #36426 - Introduce human-readable host statuses

Fixes #36394 - Add infra facet search validators

Fixes #36309 - Increase LDAP auth source password length limit

The database field is 255 characters long, but the encryption adds quite
a lot of fluff. From my testing, 69 characters is the longest password
than can fit in.

Both FreeIPA and openldap cli tools seem to support passwords...

Fixes #36017 - Remove spacing for array type settings

Fixes #35846 - allow Host searching by PXE loader

Fixes #36107 - Suppress warnings from accessing undefined settings

When Foreman is installed without puppet plugin, it still receives
puppet report from installer run. Visiting dashboard then emits a lot of
warning into logs as Foreman tries to access various puppet_* settings.

Fixes #35845 - Searching hosts should be possible by all reported data

When bios information was introduced in PR #9497, the searching was
not added. This make all host reported data searchable.

Fixes #29939 - drop category column from settings

Settings table was holding category column to support old style of
settings, but it is now ready to be decomissioned as plugins were given
enough time.

Fixes #35843 - add alias for configuration_status searching

Historically, the configuration status was the only status users can
search hosts by. When sub-statuses were introduced we kept "status" as
the search term representing the configuration status. However with many...

Fixes #35326 - Rename hostname/fqdn ENC vars to avoid conflicts

Fixes #35642 - update the message in the new UI to display the host's creator

Add `creator_id` property to the Host model to save the user who created each host.
This property is used in the new host details UI to display the user who created the host.

Fixes #35733 - Add network category to selectable columns

Fixes #35673 - Do not allow create empty table preference

Fixes #35088 - Remove GCE Compute resource code

All code related to GCE compute resource
is now in Foreman Google plugin

https://github.com/theforeman/foreman_google

Fixes #35708 - Avoid multiple %s placeholders in i18n

Fixes: 662c4a3a3a1749846f5fc6c114dd3363c7a3bcf1

Fixes #35696 - add bios info to reported data facet

Refs #35300 - Pass arguments as keyword arguments

Fixes #35619 - Add kernel_version to reported data facet for new host UI

refs #35069 - ApplicationRecord.<=> undefined method 'name'

Fixes #35569 - set correct icons

Refs #35300 - Pass options as keyword arguments (#9441)

In 9089087ed7b2a7da33b73711aa5f457fe06adfc2 various keyword arguments
were fixed, but some remained.

Fixes: 9089087ed7b2a7da33b73711aa5f457fe06adfc2

Fixes #34764 - refactor filters page (#9186)

• Fixes #34764 - refactor filters page

• Refs #34764 - manage spaces in resource_type

• Refs #34764 - fix routes

• Refs #34764 - hide locked roles

• Refs #34764 - fix search disable on load

Fixes #35300 - Pass keyword arguments correctly (#9332)

In Ruby 3.0 keyword arguments are handled separate from positional
arguments¹. This uses kwargs and passes it along.

[1]: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

Fixes #35480 - Host provisioning & OS without family

Raise an error with message about missing OS family.

fixes #35377 - allow upper case letter in device identifiers

Fixes #35359 - Add cacert to http proxy (#9348)

This PR adds a cacert column to the http proxy and uses to this for
connecting to ec2 and other compute resources. This would also be used
by katello/other plugins when communicating to the CDN over a https...

Fixes #35132 - Make audits host detection regex more strict

Fixes #35127 - migrate discovery and bootdisk templates to Foreman (#9314)

Fixes #4007 - updating users email to be optional (#9279)

Fixes #35035 - set VNC password length to 8 chars.

VNC passwords have a maximum length of 8 characters, Foreman uses 16.
Newer versions of libvirt enforce the 8 character limit.
Improve strength of generated passwords by increasing the character pool.

Fixes #35069 - ApplicationRecord.<=> undefined method 'name'

After 6.1 upgrade some tests (eg. Foreman Discovery)
are failing with following error:

NoMethodError: undefined method `name' for 0:Integer
app/models/application_record.rb:43:in `<=>'

Support != and ~ search on os_minor and ~ on os_major (#9243)

• Fixes #34989 - Support != and ~ search on os_minor

• Refs #34989 - Support ~ search on os_major

Fixes #28810 - changes to Any organization & Any location taxonomy's names

- Added unique name validations (English only)
- Added icons
- Fixed capitalization

Fixes #34942 - Adapt installation media search path for Ubuntu 20.04.3+

Fixes #34305 - stop creating settings in DB (#9050)

With the setting DSL, we hold all the necessary values for settings in the memory.
We can now stop creating records for the settings in the database.

Fixes #34526 - Switch Rails version to 6.1

Changes overview:
- Set default Rails version to 6.1
- Required dynfow >= 1.6.5
- Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml
- ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter...

Fixes #34921 - Fix SettingValueException error message

Fixes #34838 - Add errors when setting values are invalid (#9203)

Fixes #34866 - Settings - Like operator for name

• Allow ~ operator for name
• Fix issue with double quote in search
• Raise exception for unsupported operators :and / :or

Fixes #34603 - deprecate non-DSL setting definitions

This allows conversion to Zeitwerk by moving the non-DSL setting to only
to_prepare phase. We no longer require the Setting classes manually.
If the plugins want to continue using the old way,
plugins need to require the Setting classes manually.

Fixes #34689 - bootfile should be useable in Jail

Fixes #32572 - PBKDF2 password hashing support

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #34569 - postpone LookupValue#match validations

Validation for presence of foreign_key has to be postponed because of Rails internals.

association.build() filters out foreign_key for given association because it assigns the value for that key after the main record gets saved....

Fixes #31965 - make bmc_credentials_accessible disabled by default

Also remove the settings check as that would be pretty useless with this new value.

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Refs #34360 - allow host deleting with host_reports plugin

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #30861 - keep setting collections in registry

Move Setting collection registry into the setting registry.

Fixes #34565 - fix installation media for Ubuntu versions with autoinstall (20.04.3+)

The new Ubuntu autoinstall uses vmlinux and kernel initrd instead of linux and initrd.gz respectively.

• Adapt pxe_file_names to return (vmlinux,initrd) if autoinstall subiquity is used

Fixes #34596 - sanitize default template names

Default boot templates are weirdly interconnected with its settings.

Refs #33937 - improve setting usage

Settings should not be accessed through DB.

Fixes #33937 - Use local boot template setting

Currently when booting with iPXE, the `iPXE default local boot`
regardless of the configured option in settings. This shifts to looking
up the configured template and falling back to the default if not found....

Refs #10413 - Drop unattended mode checks from models

Fixes #34573 - encrypt DSL setting values

DSL setting values were not properly encrypted as the encryption flag has not been propagated into DB model.

Refs #34323 - explicit value for Rails 6.1

In c693cd9 we have worked around an issue for distinguishing between value explicitly set by user and not set.
This workaround doesn't work properly in Rails 6.1 and we should improve it to work properly.

Fixes #34498 - added RHEL9 and CentOS9 Guest OSes

Fixes #34328 - GraphQL use directly SettingRegistry

GraphQL was reading the settings from DB, but now we have the registry, it needs to read it from there instead.

Mutation needs to set the value through the SettingRegistry as well.

Fixes #34346 - support Openstack URI with paths

The Keystone URI is processed before we pass it's base form to the fog.
If Keystone is deployed under a sub-uri e.g. /identity like Devstack
does, the path is always ommited. This preserves the path.

Fixes #34499 - new h/w versions for vSphere 7.0 U2 & U3

Fixes #34416 - taxonomy title in ForemanContext

When creating new org/loc we did not save the title there.
In the app_metadata for the frontend we were taking these directly from db, so it disallowed the calculation on runtime.

This was wrong from b0d5a6c9b882fa078379ed90f8610ff021978e6b, but only when we switched to using these in the TaxonomySwitcher it started to exhibit in this bug....

Fixes #34353 - Fix early load of fog_extensions

Fixes #34375 - allow passing empty attributes for facets (#9083)

Facets were rejecting empty attributes to not create empty facet.
Originally this was to fix an issue in 5d64eef2cba8e56ad39510c3bd1d724bd52762eb
Tho we want to pass empty attributes to facets that already exists....

Refs #34360 - Use Plugin's API

Fixes #34360 - prepare for Host Reports migration

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #34351 - Allow Site manager role to be extended from plugins

Fixes #34198 - Registration and host_init_config templates previews

• Make Global registration template previewable
• Do not require host selection for registration templates
• Show managed & unmanaged hosts for host_init_config template preview

Fixes #34299 - allow input deletion during seeding

Refs #33418 - Make last_report.origin interval parametrizable fixup

Refs #33418 - Make last_report.origin interval parametrizable