Fixes #23479 - Enhance OpenStack VM Creation

• Fixes #23479 - Enhance OpenStack VM Creation

• Fixes #23479 - check property exists before access

Fixes #23918 - Find correct scope when updating taxonomy

Fixes #23961 - Update Foreman Fog-Vsphere select_nic method.

Fixes #24125 - Show error when libvirt not reachable

Fixes #24017 - Add scrollbar in org/log dropdown (#5722)

Fixes #23965 - Only save ids for association audits (#5753)

Otherwise, we have issues when trying to check revisions of the audit
since it will fail trying to assign a string to an attribute that
expects an object id.

Fixes #24192 - Clean up auth_source_selected action leftovers

The `UsersController#auth_source_selected` action was removed in commit
feacea35f07f362d9e2c694a83516bbc902321a0 but a few leftovers remain in
the code. This commit removes them.

Fixes #23290 - Unmount components before dom-update

• provide core `tfm.reactMounter.unmountComponents` function
• unmount components before saving host and manually update the dom with
  jquery

Fixes #23382 - Hashes in arrays are shown properly on ENC

When defining smart class parameter values with type YAML and submitted
in GUI an Ruby error message gets prepended for each array entry.

Defining an YAML-Array like:

---
- name: foo
mount_point: /bar...

fixes #24186 - improve vsphere error handling

Fixes #23705 - Do not associate ptable snippets

Fixes #24167 - Remove legacy_puppet_hostname setting

Fixes #23896 - Update taxonomies when refreshing metadata

Fixes #24158 - fix cloning of roles

Roles that contains filters without permissions could not be cloned. In
UI, user did not even get any error message, API responded with 422 at
least.

Fixes #23933 - consider associated object in set_taxonomies

Fixes #23782 - restore login disabling

Fixes #23162 - Fix path for tabs on smart-proxy page

Fixes #21883 - improved user context switch logging

Fixes #24072 - freeip with compute resource via hostgroup

In #5790, we added an option to set the compute resource via hostgroup.
There was one thing missed though: the freeip not getting assigned
automagically, when the compute resource was selected this way....

Refs #24072 - fix compute profile with CR set via HG

When compute resource is set via compute profile, we're not sending it
via the form (as it's disabled). Therefore, we need to search for in via
hostgroup.

Refs #24072 - fix selecting hostgroup with compute resource

Without this fix, the 'Virtual Machine' tab was giving:

'mybox' not found on 'libvirt (Libvirt)' 'mybox' could
   be deleted or 'libvirt (Libvirt)' is not responding.

Fixes #24022 - unattended error input is UTF-8 friendly (#5761)

Fixes #24109 - common kernelcmd param for all OSes

Fixes #23196 - Add default values for cores and socket in VM

Fixes #23808 - monotonic timer to measure durations

Fixes #23920 - add missing header in welcome pages

Fixes #24057 - Email subject prefix accepts long strings (#5742)

Fixes #23994 - Do not update templates out of scope

Fixes #23991 - rephrase RSS setting description

Fixes #18765 - finish script use FQDN when IP is missing

This is resurrect of

https://github.com/theforeman/foreman/pull/2171/files

The old patch did not pass review because I was unable to explain the
motivation. The reason for the fallback is that only cloud compute...

Fixes #24071 - Adding locked state (#5741)

Fixes #23536 - No errors when unattended=false

fixes #24046 - return id as str for name as last resort

Foreman HasManyCommon concern uses 'id' as a value of last resort for
the name of an attribute. But Rails expects this value to a return a
string. This causes a problem for Katello. Take a look at the output...

Fixes #24053 - Remove oVirt specific error

fixes #23862 - scoped search audit comment

Fixes #24025 - Pass full_name attribute for settings in API

Fixes #23951 - fix searching by config group

Fixes #23962 - Fix Style/ExpandPathArguments cop

Fixes #23626 - Move autosign to build queue

fixes #22467 - dashboard: list hosts in build mode

Fixes #23599 - fix subtotal value in API call with thin=true

Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #23976 - Add Quota to oVirt API (#5715)

Fixes #21007 - new unattended action 'failed'

Fixes #22117 - Add support for number of sockets for ovirt

Fixes #23930 - PXELinux loader is now preferred

Fixes #23768 - keep_subnet flag to prevent subnet override (#5635)

Fixes #20891 - Remove hostname from /hosts/x/facts results

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #22058 - refresh rubocop config and apply autofixes

fixes #23909 - vsphere: prefer network search by key

Creating a new VMware image fails during provisioning with
"Could not match network interface". Searching for distributed
virtual switch via key BEFORE searching with the nic_attrs structure
resolves a false positive match when vCenter contains VDS migrated...

Fixes #23913 - Stop auditing host status updates

Fixes #23857 - Fix Performance/InefficientHashSearch cop

fixes #23232 - fix error when domain not in taxonomy

This ensures that if domain_id is set, but domain not found (for example
when domain is in another taxonomy), the shortname still removes the
domain from the host's FQDN.

• Fixes #23611 - Provide helper method to run "service" active jobs

The root cause was we were triggering the active jobs too early,
sometimes even before the db was migrated. This led to all sorts of
errors. The provided helper method does not trigger the jobs when in...

Fixes #23848 - template import should use taxonomies title

Fixes #23843 - Exclude requests to local host from proxying

Fixes #23859 - Fix vm_exists? method

Fix related tests

Fixes #23859 - Queue orchestration compute

Fixes #23598 - move report metrics chart to c3

Fixes #23377 - audit external group membership changes (#5555)

Fixes #13749 - Handle Base64 and binary LDAP avatars

Before this change, we would always try to Base64.decode absolutely any
avatar. This resulted in broken images, as sometimes the avatars are
automatically turned into binary by net/ldap. In such cases, we want to...

Refs #21580 - require rbvmomi

The compute resource for VMware was using rbvmomi classes wihout
explicitly requiring rbvmomi. That can cause issues in tests.

Fixes #23826 - model class logger is now app

Fixes #23800 - i18n for exceptions fixed

Fixes #23813 - Allow searching audits by type=auth_source

Refs #23776 - correct deprecation for notice

Fixes #23775 - exposed random name generator

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #23776 - Remove deprecations for 1.18

Fixes #23769 - consistency in docs for foreman/katello

Fixes #22778 - disableable bruteforce protection

Fixes #19990 - VMWare allow save vm w/o size_gb attr

Sync templates from community-templates

fixes #23686 - filter audits by settings type

fixes #23357 - Refactor Notification Drawer from patternfly-react

refs #22847 - remove unused charts code.

fixes #23681 - move auth_source_ldap js to webpack (#5607)

Fixes #23550 - add to_hash method to Menu::Manager

Fixes #23635 - Centralize use of facter

We have a bundler group for facter. That implies it's optional but
before this change it wasn't With this change it's only required if no
domain and fqdn are set. This is still the default so in most cases it's
no difference, but at least we have centralized all use of facter to one...

Rename method that does not cache

Fixes #23608 - Only calculate lookup values once

Fixes #23487 - support namespaced controllers

fixes #23573 - add pagelets for cr show page

Fixes #23646 - Remove storeconfig leftovers

In Foreman 1.1 sharing the database with Puppet's storeconfigs was
deprecated. We've given users sufficient time to migrate away from it
and possibly broke it along the way. I haven't checked.

fixes #23621 - passwords can be md5 hashed

Fixes #23629 - Fix redirect parameters on hosts page

Fixes #22983, #22010 - ignore persistence authz for relations

Fixes #23601 - switch org/loc button ordering in vertical nav

Fixes #23576 - Fix the 'webpacked_plugins_js_for' helper (#5552)

Fixes #23559 - fix breadcrumbs switcher in trends page

Fixes #23602 - Remove statisticsHelper file (dead code)

Fixes #23169 - Orders settings alphabetically

Fixes #23426 - support default flag in templates import

Fixes #22847 - Use pf-react donut chart in facts page

Fixes #23527 - enable breadcrumbs switcher in trends

Fixes #23248 - disable switcher in compute attributes

Fixes #18429 - Add foreman API support for trends