Fixes #19789 - fix Layout/SpaceAroundOperators cop
Fixes #19781 - Fix Layout/LeadingCommentSpace cop
Fixes #19787 - Fix Layout/SpaceAfterComma cop
Fixes #23123 - Fix Rails/ActiveRecordAliases cop
Fixes #21999,#22005 - Migrate toasts to pf-react
Refs #20800 - Move session timed out warning inline
Fixes #21343 - support multiple orgs supported for non-admin users
This adds a full support for taxonomies in API for non-admin users. Itfixes the issue with dirty associations module that only track _ids...
Fixes #21098 - Use positional args in functional test requests
Fixes #21424 - use factory_bot_rails
Fixes #19031 - move to patternfly pagination style
Fixes #16884 - enforce granular filters even during save
fixes #19479, #10587, #19500 - two pane notifications are visible
- notification is now inside the content div, allowing two-pane serverresponses to include it.- refactored all notifications to use notification helpers (notice,warning and error) instead of direct flash manipulation...
fixes #19131 - upgrade minitest to latest 5.x
- override minitest's `_` expectation method with the gettext method- rename `location` let helper, conflicted with a minitest method name- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`...
refs #16982 - check _ids getters as admin user in taxonomy tests
After a request and User.current is back to nil, the ids getters willnot return any results as the default taxonomix scopes don't permit it.The clone test was instead testing that _no records were associated.
Fixes #16982 - Scope properly when no taxonomies are set
The default scope for hosts and other objects did not restrictproperly by taxonomies. An user without organizations orlocations, could do anything it's permissions allow to.The list of hosts was unrestricted and showed hosts in...
fixes #18155 - add string to empty form-encoded arrays in test
This test attempts to send an empty `:smart_proxy_ids => []` parameteremulating the UI to unset smart_proxy_ids on a taxonomy, but Rails 5filters this empty parameter out when converting it internally to a form...
Fixes #17343 - set deep munge config off
deep_munge was introduced as a solution to keepRails secure by default which results in'empty array becomes nil in params'.Thats why, set deep_munge config off in application.rb.Also, added changes which will cast param argument to string...
fixes #16557 - move tests into modern Rails layout
Models, controllers, mailers and helpers are now in test/ subdirsmatching app/ subdirs. Service, miscellaneous and old test/lib/ testsare now in test/unit/ separated from models, which obsoletes the custom...