Refs #24072 - fix compute profile with CR set via HG

When compute resource is set via compute profile, we're not sending it
via the form (as it's disabled). Therefore, we need to search for in via
hostgroup.

Refs #24072 - fix selecting hostgroup with compute resource

Without this fix, the 'Virtual Machine' tab was giving:

'mybox' not found on 'libvirt (Libvirt)' 'mybox' could
   be deleted or 'libvirt (Libvirt)' is not responding.

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #23629 - Fix redirect parameters on hosts page

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Fixes #22236 - Adds breadcrumbs to foreman UI

Fixes #22880 - Move to Minitest::Retry for integration tests

Since our integration tests are quite flaky, at times because of DNS
problems or similar, I suggest we move away from minitest-optional_retry
(unmaintained) to minitest-retry which seems more maintained and...

Fixes #21425 - host selection alert refers to param per_page

Multiple host selection alert only mention settings[:per_page],
though pagination has been changed,
now the user can change per_page via select box

Refs #20049 - Retry some integration tests

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Fixes #21424 - use factory_bot_rails

Refs #20049 - Retry various integration tests

New breakages found that could be fixed by retrying (timeouts, DNS
errors...)

Fixes #19583 - reworded blank label for subnet

Fixes #19217 - update the close icon to remove icon

In "Add Parameters" and "Add Combinations", we noticed
there are "Remove" icons, but currently using the Close
icon, based on the icon guideline, we suggest to use the
right icon for correct meaning.

Fixes #18722 - fix host parameters in host form

Fixes #17872 - Update button label from New to Create

Based on PatternFly Terminology and Wording suggestions
Don't recommend to use New, so update New to Create.

Fixes #14714 - Make inherited Puppet Classes more apparent

To better recognize which Puppet Classes are inherited for Host
or Hostgroup they are under a sub-heading as a seperated list.

Fixes #17238 - Validates lookup value match exists in key path

fixes #17170 - use strong params in InterfacesController

fixes #16900 - ensure interface mac address is unicast

fixes #16805 - reload host parameters on host group change

On Rails 4.2, `Host#type_changed?` may return nil due to bug #24220
causing data-type-changed to be missing from the host form and the JS
in handleHostgroupChangeEdit to assume host#edit is a hostgroup form....

fixes #15894 - retry intermittently failing integration tests

fixes #15762 - move flash testing out of integration test

The flash div is only present momentarily before jnotify removes the
element and re-displays it as a popup, so only check that it's set in
the response from functional tests.

fixes #15761 - wait for domain and unused_ip AJAX calls

fixes #14666 - support IPv6 in UI

Fixes #15134 - wait for ajax in interface test

Otherwise the form changes during the 'Ok' button click and causes
intermittent issues.

fixes #14865 - use waiting selector to search for checked boxes

Also changes the click on the select all checkbox to trigger a DOM click
event, making it more reliable when the element moves slightly during
page loading.

Refs #3809 - Turning on some rubocop cops

Fixes #14790 - reloads puppetclass parameters when choosing os and domain

fixes #14202 - enable select2 in interfaces modal

Reverts commit 44723b9 and re-enables select2 in the interfaces modal,
instead fixing the issue with the NIC table detail lines to read the
network information out of select2 dropdown menus correctly.

fixes #14041 - don't call select2 on CR form templates

select2 must be called only when the select becomes visible, not for
hidden template elements. add_child_node() already does when adding a
new set of fields from the template. without_select2 is removed from...

Fixes #14067 - Host#edit integration tests should wait for tasks

When you click on Host#edit Submit button, a few orchestration tasks
will be created. After that, the show page will call (via AJAX) a few
URLS to fetch 'overview', 'resources', 'nics', etc... to fill up the...

Fixes #14097 - Only run DatabaseCleaner truncation on JS tests

Problem:
DatabaseCleaner runs after all integration tests, on truncation mode.
However, for tests where we use rack-test instead of poltergeist, this
is not necessary and slows down the test suite....