Refs #24057 - fixed broken email test

Fixes #24057 - Email subject prefix accepts long strings (#5742)

Fixes #23994 - Do not update templates out of scope

Fixes #23951 - fix searching by config group

Fixes #23626 - Move autosign to build queue

Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

Fixes #23930 - PXELinux loader is now preferred

Fixes #23953 - Port robottelo tests for settings

Fixes #23768 - keep_subnet flag to prevent subnet override (#5635)

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Refs #23132 - stabilize bookmark test

Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #23857 - Fix Performance/InefficientHashSearch cop

fixes #23232 - fix error when domain not in taxonomy

This ensures that if domain_id is set, but domain not found (for example
when domain is in another taxonomy), the shortname still removes the
domain from the host's FQDN.

Fixes #23859 - Fix vm_exists? method

Fix related tests

Fixes #23377 - audit external group membership changes (#5555)

Fixes #13749 - Handle Base64 and binary LDAP avatars

Before this change, we would always try to Base64.decode absolutely any
avatar. This resulted in broken images, as sometimes the avatars are
automatically turned into binary by net/ldap. In such cases, we want to...

fixes #23178 - seeded location should be in seeded org

When creating a host in the seeded org and seeded loc, host saves and
then organization becomes invalid: "Locations expecting locations used
by hosts or inherited (check mismatches report)."

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #22601 - Update Rails to 5.1.6

fixes #23686 - filter audits by settings type

Fixes #23609 - Port robottelo tests for classparameters

Fixes #23605 - Port robottelo tests - smart_proxy

Fixes #23586 - Port robottelo tests for template

Fixes #23169 - Orders settings alphabetically

Fixes #23426 - support default flag in templates import

Fixes #23565 - Port robottelo test for smart variables

Refs #23485 - Fix interface test

Fixes #23485 - Port robottelo tests for interfaces

Fixes #23419 - Port robottelo tests for hostgroup

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23195 - Audit associations on creation and destruction (#5455)

Also includes a bit of refactoring to the AuditAssociations module.

Fixes #23331 - grouped permissions for host disabled (#5468)

Fixes #23339 - Port robottelo tests for hosts

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #23132 - Fix seeds tests

Fixes #23132 - Fix seeds tests

Fixes #23132 - Port robottelo tests for bookmarks

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23157 - Enable Performance/FixedSize cop

Fixes #21055 - use _id attributes for host taxonomy validator

Otherwise, the error messages are not visible.

Also log the host error messages as `error` instead of `info`, as it
should be more appropriate for this case.

Fixes #23106 - Fix MySQL tests

Fixes #23106 - Port robottelo tests for usergroups

Fixes #23113 - Allow disabling of out of sync status

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #22893 - Specify taxonomies on template import (#5323)

fixes #21694 - Add consistency validation for MTU and VLAN

fixes #21694 - Add MTU to subnet

Fixes #23077 - Fix Style/TrailingCommaInArrayLiteral cop

Fixes #23098 - Allow searching on all audited models by type (#5395)

This automatically adds all the audited models in an after_initilize
block so that models defined in plugins are also included. All the
search related definitions for audit have been extracted to a seperate...

Refs #15634 - Fix OS test (#5397)

Fixes #23095 - Port robottelo tests for subnets and parameters

Fixes #22546 - CVE-2018-1097: Bump fog-ovirt for power action fix

Fixes #23066 - Port robottelo tests for users and user roles

Fixes #23045 - Port Robottelo PTables tests

Fixes #23004 - Port robottelo tier1 media tests

Fixes #22922 - Port robottelo tier1 compute profiles tests (#5333)

Fixes #22990 - Use shoulda-matchers

Fixes #22990 - Port robottelo tier1 compute resources

Fixes #23007 - renew certs used in oVirt model test

Fixes #22979 - Port Robottelo OperatingSystems tests

Fixes #22910 - Port robottelo tier1 environment tests (#5329)

Fixes #22869 - support template locking on import

Fixes #22796 - fact importing telemetry

Fixes #22930 - Port robottelo Architectures tests (#5335)

Fixes #22927 - method in audit_associations to get class

With this commit, we can override association_class method
in other plugins like Katello.

Fixes #22800 - Port robottelo tier1 location tests

Fixes #22788 - host compute attributes reload after error

Fixes #22096 - Make Audits taxable (#5269)

Fixes #22793 - Port robottelo tests for organization (#5295)

Fixes #21120 - orchestration tasks are added only once (#5079)

Fixes #6504 - refactoring host tests regarding taxonomies

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #22358 - add templates importing

Fixes #22721 - Rename setting to trusted_hosts

The setting trusted_puppetmaster_hosts is used to allow hosts to submit
stuff to the facts/reports API endpoint.
The name made sense a long time ago, but these days other plugins and
any user can submit stuff to this API to generate...

Fixes #22199 - Audit has_many associations (#5187)

Fixes #22676 - domain checking should ignore scoping

Fixes #22104 - adapt to Rails 5.1 change tracking

Fixes #22616 - Allow searching hosts by status as integer

Fixes #22556 - Correct host search for parent hostgroup

Currently, searching on a non-existant parent fails due to
`hostgroup.subtree_ids` throwing a NoMethodError when no matching
hostgroup is found. This is rescued by scoped search, causing the
search to run with no conditions instead....

fixes #22454 - vmware: validate user data for customspec

Fixes #22328 - Fix Lint/InterpolationCheck cop

Fixes #22382 - Remove ldap_filter 255 chars limit

Fixes #22355 - Make stripping a setting value optional

Fixes #22430 - Plugin permissions are cleared on tests

- Some tests are removing all plugins (plugin_test, rabl_test,
belongs_to_proxy_test) from the registry. This has, among others,
one important consequence: the plugin permissions are removed.

- Take an example. Foreman Ansible overrides the Host#form with a...

Fixes #22339 - normalize empty values for User.timezone

Otherwise, we would need to deal with two values for the browser's
timezone. Less variants is better in this case.

Fixes #20807 - Remove deprecations for 1.18

Refs #19777 - Fix Layout/IndentAssignment cop

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Fixes #19838 - Fix Rails/PluralizationGrammar cop

Fixes #1916 - Subnet vlan id should be integer

Refs #22164 - use cheaper FactoryBot methods

• Refs #22164 - FactoryBot.build -> FactoryBot.build_stubbed

• Refs #22164 - FactoryBot.create -> FactoryBot.build

in
- test/unit/*
- test/models/shared/taxonomies_base_test.rb
- test/controllers/hosts_controller_test.rb

Fixes #22208, #21920 - Refactor password auditing (#5162)

Recent changes in Rails 5.1 and audited gem cause our method of auditing
passwords to break. This PR refactors password auditing, so that instead
of recording a change to attribute `password_changed`, we will now...

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #21926 - Ensure uniqueness on image names and uuids (#5081)

Image names should be unique per CR and OS. UUID uniqueness is already
enforced by ActiveRecord but not in the DB, which could cause conflicts
in multi-proccess environments. Also cleaned up a bit of the image tests...

Fixes #5790 - Add compute resource to hostgroup (#4593)