Fixes #37432 - Fix Style/GlobalStdStream cop

Refs #37102 - Read real webpack manifest in test

In some test cases (like controller tests) the real manifest isn't
needed, but in integration tests they are.

Rails has deprecated controller tests in favor of integration tests, but
Foreman still has them. This modifies the fake read_webpack_manifest to...

Refs #36849 - Enable strict keyword argument matching

Fixes #37102 - webpack 5

Fixes #32848 - Support linking to docs.theforeman.org

An effort is under way to use docs.theforeman.org as the primary
documentation source. It is already the official documentation source
for Katello, but until now it wasn't easily possible to (correctly) link...

Fixes #36867 - Add host delete & create
Add bulk modal with bulk params
add register/create buttons; fix links
address UX comments
Remove icon from delete action in the toolbar’s kebab
In the delete modal as a primary button use just “Delete”
(not delete host)...

Fixes #36715 - Speed up host fact retrieval

Fixes #36661 - remove restore_plugins from test_helper

Fixes #36651 - Support Minitest 5.19+

• This reverts commit 1c3a4155f286352e0abbf0d0b298e47e81c2d6c5.
  Thus un-pinning minitest again
• update minitest-spec-rails to 7.1+
  This contains a fix required for minitest 5.19+
• Update mocha to 2.1+ for minitest 5.19+ compat...

Refs #32685 - Keep modulized model name in Global ID

Fixes #32685 - update graphql to 1.13.x

GrapQL 1.13.x is a large update and can break plugins, but it is Ruby 3
compatible.

Co-authored-by: Oleh Fedorenko <ofedoren@redhat.com>

Fixes #26968 - Switch to minitest-reporters

ci_reporter_minitest is unmaintained and since minitest 5.1 it no longer
shows the class names. minitest-reporters does.

Fixes #31016 - refresh registries after plugin testing (#8055)

Fixes #31016 - refresh registries after plugin testing

Introduce mechanisms to refresh the plugin registries.
We pollute these during plugin mechanisms testing and it never gets cleaned up.
This makes sure we clean mocks and stubs from the registries.

Fixes #29524 - association preloading in testing

Fixes #29349 - Fix Layout/SpaceInsideArrayLiteralBrackets cop

Fixes #19896 - Fix Style/RedundantSelf cop

Fixes #28363 - Drop lookup key matcher length limit

Fixes #29248 - add DNS stubs for all tests

Fixes #19792 - Fix Layout/SpaceInsideBlockBraces cop

Fixes #28154 - random name/description test failure fixed

Fixes #27249 - flip the comma cop

fixes #26548 - graphql: support namespaced modules

Fixes #26875 - update factory_bot_rails to 5.x

fixes #26495 - graphql: properly auth resources

Fixes #26297 - graphql: add Host queries

fixes #23678 - add graphql scaffolding

Fixes #23336 - env variables for test retry and logs

Fixes #24886 - fixed audit in seeds test (#6058)

Fixes #24293 - Fix ability to run single tests

Fixes #23962 - Fix Style/ExpandPathArguments cop

Refs #23295 - Robottelo tests reporting (#5586)

Fixes #23295 - Robottelo tests reporting (#5464)

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #22930 - Port robottelo Architectures tests (#5335)

Fixes #22793 - Port robottelo tests for organization (#5295)

fixes #22575 - clean up test report

• Replace deprecated only_path with ignore_query

• Don't log to stdout for skipped tests

~_{* Don't override capture}~

~_{While this code might be helpful for debugging, leaving it in for}~
~_{every test run clutters up the test report.}~...

Fixes #22430 - Plugin permissions are cleared on tests

- Some tests are removing all plugins (plugin_test, rabl_test,
belongs_to_proxy_test) from the registry. This has, among others,
one important consequence: the plugin permissions are removed.

- Take an example. Foreman Ansible overrides the Host#form with a...

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #21776 - Improved fact importing to deal with names

Now the list of fact names will be calculated beforehand and saved
to the database. It will also consider that the name could be added
from other thread.

Fixes #21424 - use factory_bot_rails

Fixes #20559 - print rails log for test failures

Refs #16884 - add minitest stubbing to test helper

fixes #19131 - upgrade minitest to latest 5.x

- override minitest's `_` expectation method with the gettext method
- rename `location` let helper, conflicted with a minitest method name
- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`...

fixes #18681 - moves polymorphic subject into notification object

also adds host build, destroyed and missing owner UI notifications

Fixes #16982 - Scope properly when no taxonomies are set

The default scope for hosts and other objects did not restrict
properly by taxonomies. An user without organizations or
locations, could do anything it's permissions allow to.
The list of hosts was unrestricted and showed hosts in...

Refs #15779 - make background processing unavailable for now (#4217)

The original PR got vetted in the packaging phase and including
foreman-task as dependency of Foreman was refused. We need to rethink
our approach for getting the foreman-tasks functionality available...

Fixes #17487 - support sessions for api calls

- authenticated api calls save user to session and set
flag api_authenticated_session
- sessions with such flag allow posting requests without CSRF token
- api sessions exipre the same way as UI sessions
- api sessions don't store any additional data to keep the requests...

Fixes #15779 - make background processing available

fixes #16557 - move tests into modern Rails layout

Models, controllers, mailers and helpers are now in test/ subdirs
matching app/ subdirs. Service, miscellaneous and old test/lib/ tests
are now in test/unit/ separated from models, which obsoletes the custom...

fixes #15787 - update shoulda-matchers to 3.x

Contains changes to models for the new behaviour of the uniqueness
validation test, which saves a model with one value and then attempts
to validate a second.

NestedAncestryCommon's validation now doesn't fail when the specified...

Fixes #12364 - Use NPM+Webpack to handle external assets

This commit introduces NPM and Webpack to handle external assets.
It also provides ES6 support and a live reload dev server that can be
used by running `foreman start` instead of `rails start`.
Do not forget to run `npm install` before starting the server....

fixes #15751 - replace spork with spring in development

To make use of it, run bin/rails and bin/rake rather than plain
rails or rake commands, and run `spring status` or `spring stop` to
check and stop current background processes.

Test log removal has moved to the logging framework as the file would...

Fixes #14228 - requiring fileutils in test_helper

Fixes #14097 - Only run DatabaseCleaner truncation on JS tests

Problem:
DatabaseCleaner runs after all integration tests, on truncation mode.
However, for tests where we use rack-test instead of poltergeist, this
is not necessary and slows down the test suite....

Fixes #14191 - remove simplecov test coverage reporting

fixes #14155 - fix leaks between tests with random ordering

- A test for the Rabl use_controller_name_as_json_root extension was
leaking as the old value was only reset in `setup` methods. When the
test was last in the test case, the configuration wasn't reset....

Fixes #13545 - STI permission checking always using base class

This fixes permission checks on STI objects. Due to these methods existing
in Procs and being included in the base class at run time resource_class was
returning the base class. I can only presume this is related to a ruby or rails 4...

Fixes #13896 - Rename Anonymous role to Default role

fixes #13879 - load mocha/minitest integration explicitly

rails/rails@fd6aaaa removed automatic loading of mocha in Rails 4.2
from rails/test_help.

Fixes #13557 - Rubocop enforce specifying a timezone

Rubocop can enforce what timezone to store in the database ,
so we can ensure everything is stored using UTC and we don't
miss these things in code reviews. When objects are displayed,
they must use the time provided by set_timezone in the...

fixes #13355 - facet test tables get created when tests run

moving the require to the test helper ensures that the code gets
evaluated before Spork.prefork, thus, the tables get created.

fixes #13111 - use negated Capybara lookups to wait for JS handlers

Various integration tests failed intermittently as they didn't wait for
asynchronous JS to run when clicking buttons. Instances of refuting
existence of an element after a click were changed to negated Capybara...

fixes #13131 - plugin tests to skip is back

Fixes #11618 - Replace validation tests by shoulda-matchers

A good chunk of our unit tests are testing whether a validation is
working or not by testing it actively. For the validations we've
added ourselves I would say it's fine. However for validations that...

fixes #12954 - config status is relevant if reports exist or via setting

For a host that has config management reports, but no Puppet proxy set,
consider the config status relevant. This helps in an environment with
reports but no proxy, but has the side effect of considering the status...

Fixes #12794 - Defined logic when properties should be sent to server

If hostgroup is not set - always send the parameters.
On hostgroup change - remove inherited parameters from the request, so the values from the hostgroup will take place.
On save - send the values according to the state of the "inherit" button.

Fixes #7230, #12021 - Upgrade to Rails 4.1.5

This commits upgrades Rails to Rails 4.1.5. See a description of the
changes included here, and go to the pull request in GitHub to see more
detailed explanations:

• Update gems to a Rails 4 compatible version, including dependencies...

Fixes #12452 - Enable non admin users to do bulk actions on hosts

Fixes #7567 - Substitute find_or_create_by by first_or_create

Rails 3 and 4 both support the syntax 'where(args).first_or_create'.
find_or_create_by is no longer valid on Rails 4 so we should remove it
here already

Fixes #11912 - Remove deprecated assert_present assert_blank

Rails 4.1 deprecates assert_present and assert_blank as per
http://guides.rubyonrails.org/4_1_release_notes.html . We don't use
these extensively, so we can afford to remove them and use the
recommended assert object.present? and assert object.blank?...

Fixes #11813 - Use new engines listing syntax

Fixes #11025: Allow skip test runner to run through Jenkins test task.

The Jenkins CI gem implements its own custom test runner. When trying
to use a custom test runner in the jenkins environment, this test
runner needs to be inherited from and included as the last argument....

fixes #10627 - apply host taxonomy scope to facts/report joins

Previous changes to perform a join onto hosts with authorisation result
in a query such as Report.joins(:hosts), which ignores any
default_scope on Host::Base. This commit explicitly passes taxonomy...

Fixes #7096 - Adds STI to templates

This commit converts Ptables to be just another type of Template so it
gets the same features as ConfigTemplate. ConfigTemplate was renamed to
ProvisioningTemplate to reflect UI and the name under it's commonly known.

fixes #10020 - add next-server/filename attrs to provision NIC DHCP record

A host's DHCP record used to be constructed with PXE attributes in
Orchestration::DHCP, but moved to Nic::Managed during 43c4bd7. Nic::Managed
didn't add PXE attributes, so this commit adds these when provision? is set....

Fixes #9967 - make sure User.current is isolated

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Refs #3809 - Remove cops for empty lines

fixes #9212 - using headless browser in order to run Capybara tests

Fixes #9044 - fixes invalid mac in tests

Also do not reset invalid mac address to nil so we can propagate proper
validation error.

Fixes #7233 - Drop Ruby 1.8.7 and revert Ruby 1.8.7 specifics

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

Fixes #6549 - Add :tests_to_skip to plugin registration block

Fixes #5929 - Taxonomy filter obey permissions

With this patch you can assign permissions like assign_organizations and
assign_locations to particular user so that they can then assign
taxonomies
only from set of taxonomies granted by their filters.

Global users would be still able to assign any taxonomy to a resource as...

Fixes #6446 - Forbidding non-json POST/PUT requests in v2

Fixes #6620: Allow plugins to define a file to be included in test_helper.

For some plugins additions to the test_helper are needed to allow
the test suite to pass. This checks if a file test/support/foreman_support
exists and requires it after all the Foreman test setup is done.

Fixes #6537: Entering a very large number for idle_timeout is unchecked, crashes UI

fixes #3272 - allow 'admin' account to be removed and replaced

fixes #6112 - log/test.log disappears when running under spork

fixes #5246 - remove second host/class lookup impl so config groups are included in ENC output

Fixes #5180 - in_taxonomy clears out Taxonomy.current

fixes #4457 - Session fixation, new session IDs are not generated on login (CVE-2014-0090)

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4349 - API v2 - add location and organization child nodes to user, domain, subnet, etc show json templates

fixes #4198 - API v2 - add child nodes to show responses. Ex. architecture should show operating systems node

Fixes #4341: Adds a new organization taxonomy that is labeled empty.

fixes #3597 - removing rr gem, make tests consistent by using just mocha