Project

General

Profile

Statistics
| Branch: | Tag: | Revision:

# Date Author Comment
bf03a259 04/17/2024 06:15 AM Pat Riehecky

Fixes #36525 - kickstart's RHSM line only works on RHEL hosts

98d3bf5b 04/15/2024 12:09 PM Jan Loeser

Fixes #36885 - Add Clevis/Tang disk encryption template

For disk encryption Clevis/Tang is often used. This commit introduces
partition templates for Kickstart and Autoinstall taking care of disk
encryption and a snippet responsible for binding the LUKS device via...

f87b1a25 04/15/2024 08:28 AM Leos Stejskal

Fixes #37337 - Fix snapshot task and add Rocky 8 & 9

05f60ce3 03/14/2024 01:05 PM Jeremy Lenz

Fixes #37065 - report_row now explicitly accepts kwargs
also adds a test which fails without the fix

3a55f468 03/11/2024 01:42 PM Alexander Olofsson

Fixes #37043 - Inheritance overrides host facets

a488cd20 03/10/2024 11:55 AM Jeremy Lenz

Fixes #37179 - Clone hostgroup facets when cloning hostgroup

2836e938 03/01/2024 09:47 AM Bastian Schmidt

Fixes #37011 - Apply latest Ubuntu Autoinstall userdata changes

  • Add explicit fallback for offline installation
  • Replace deprecated lock-passwd with lock_passwd
  • Remove empty ssh keys array if none provided
459f70c4 02/26/2024 09:53 AM Hao Yu

Fixes #37184 - Report template generates incorrect kernel version

1935cea4 02/26/2024 08:11 AM Evgeni Golov

Refs #36502 - update snapshots after template change

47288398 02/01/2024 09:23 PM Oleh Fedorenko

Refs #36849 - Enable strict keyword argument matching

f1313e54 01/30/2024 09:39 AM Nofar Alfassi

Fixes #37015 - Refactor OwnerClassifier

- Introduce `classify_owner` class method for owner classification.
- Implement private method for input validation.
- Add error handling to raise the necessary exceptions.
- Add deprecation warning to the `user_or_usergroup` method.

89c61045 01/26/2024 10:44 AM Maria Agaphontzev

Fixes #37102 - webpack 5

75017ef2 01/03/2024 12:26 PM Oleh Fedorenko

Refs #36849 - Remove deprecated URI.{encode,decode}

These are dropped in Ruby 3.0

2198394b 01/03/2024 12:26 PM Oleh Fedorenko

Refs #36849 - Fix Ruby 3 kwargs handling

9e427bdc 01/03/2024 11:14 AM Ewoud Kohl van Wijngaarden

Fixes #37019 - Correct release names in OS factories

a406cf2b 10/09/2023 09:42 AM Matěj Mudra

fixes #36160 - Redefine append domain names setting

This PR aims to unify the format of host names stored in the database and the way they are displayed.
With this change, the name of the host is always going to be stored with the domain name appended.
The setting formerly named `append_domain_name_for_hosts` is now renamed to `display_fqdn_for_hosts`...

001a7ffc 10/05/2023 02:50 PM Oleh Fedorenko

Fixes #36796 - Make host_facts_updated event visible

4e205ba1 10/04/2023 07:06 AM Ewoud Kohl van Wijngaarden

Fixes #36723 - Remove Fedora/Red Hat Atomic related code

As far as I can see this has been EOL for a few years now. Red Hat
Atomic went EOL in 2021.

d430f3fb 09/28/2023 10:19 AM Evgeni Golov

Fixes #36759 - only call allowed transpilers

CVE-2022-3874: OS command injection via ct_command and fcct_command

Instead of allowing to call any command by changing a setting, only
allow specific paths to ct/fcct. If the user needs a different path,
they can set it via settings.yaml.

b9986c96 09/01/2023 06:27 PM Oleh Fedorenko

Fixes #36466 - Allow gathering information on deleted records

0f1d1426 08/23/2023 06:41 AM Jonas Trüstedt

Fixes #35124 - Fix preseed_kernel_options to work with full-host-bootdisk deployments

Update corresponding template snapshots.

Co-authored-by: Bastian Schmidt <>

70c0992a 08/22/2023 07:03 PM Bernhard Suttner

Refs #36677 - fix tests

6340ec56 08/09/2023 09:33 AM Evgeni Golov

Fixes #36660 - drop value from settings dsl

also update plugin docs to use a seed instead of a migration if they
need a value

fb76d77a 08/08/2023 12:16 PM Ewoud Kohl van Wijngaarden

Fixes #36639 - Use Templates feature on IPv6

This now looks at, and prefers, the IPv6 subnet on the
provision_interface to determine the template proxy. This allows using
the Templates feature in pure IPv6 provisioning setups.

2cadaaaa 08/08/2023 10:13 AM Evgeni Golov

Fixes #36651 - Support Minitest 5.19+

  • This reverts commit 1c3a4155f286352e0abbf0d0b298e47e81c2d6c5.
    Thus un-pinning minitest again
  • update minitest-spec-rails to 7.1+
    This contains a fix required for minitest 5.19+
  • Update mocha to 2.1+ for minitest 5.19+ compat...
68bacee5 06/09/2023 01:44 PM wlma please_edit_me

Fixes #36490 - Remove redundant ERB closing tag in coreos template

Refs #36490 - Regenerate template snapshots

29e1c27b 06/08/2023 11:48 AM Mike Rochefort

Fixes #36189 - Add AlmaLinux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/almalinux/grubx64.efi path is missing. This causes the server
to refuse to boot.

To make it easier to use the AlmaLinux installation medium is added.

02dd9831 06/01/2023 07:40 AM Shimon Shtein

Fixes #36395 - move value setting to seed

c4b515d6 05/10/2023 07:35 AM Damon Maria

Fixes #36180 - iPXE provisioning template for Ubuntu autoinstall

6368162f 04/20/2023 03:47 AM Girija Soni

Fixes #36017 - Remove spacing for array type settings

0d2e222d 02/22/2023 02:45 PM Peter Koprda

Fixes #35701 - Export button should use selectable columns

5c3cfef8 01/30/2023 10:15 AM Leos Stejskal

Fixes #36014 - Kickstart default - remove @core group

The Core group is always selected, it is not necessary to
specify it in the %packages section.

f3af7ab4 01/22/2023 11:38 AM Leos Stejskal

Fixes #35840 - Install chrony on RHEL 7

c791f6c7 01/16/2023 12:01 PM Ondřej Ezr

Fixes #29939 - drop category column from settings

Settings table was holding category column to support old style of
settings, but it is now ready to be decomissioned as plugins were given
enough time.

acafe1aa 01/04/2023 02:38 PM Adam Ruzicka

Fixes #35894 - Properly detect setting changes

Previously we missed setting changes which changed a setting back to its
default value.

bcfa6ade 01/04/2023 02:38 PM Adam Ruzicka

Refs #34305 - Fix load_values test

a0dae9e5 12/05/2022 03:20 PM Marcel Kuehlhorn

Fixes #35286 - New PXEGrub2 template for Ubuntu Autoinstall

- Introduce new PXEGrub2 Autoinstall template
- Move network configuration out of PXELinux Autoinstall template to
new preseed_kernel_options_autoinstall snippet
- Add snapshot for preseed_kernel_options_autoinstall...

1117630b 12/03/2022 01:41 PM Ewoud Kohl van Wijngaarden

Refs #35796 - Reduce empty lines

In 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c an additional empty line was
generated which broke the snapshots. This takes it a step further and
also removes various other lines in the generated output.

Fixes: 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c

eaf0052b 12/01/2022 12:40 PM Bernhard Suttner

Fixes #35674 - Add more custom pre/post snippet hooks

5537d830 11/28/2022 01:57 PM Sayan Das

Refs #35530 - Dont use shellescape on the filename

cc7af718 11/04/2022 02:46 PM Leos Stejskal

Fixes #35088 - Remove GCE Compute resource code

All code related to GCE compute resource
is now in Foreman Google plugin

https://github.com/theforeman/foreman_google

5339e9fd 11/04/2022 12:53 PM Marcel Kühlhorn

Fixes #35397 - Preseed Autoinstall incorporate host_params

  • Param 'keyboard' to set default layout
  • Param 'lang' to set default locale
  • Adapt template snapshot accordingly

Co-authored-by: Bastian Schmidt <>
Co-authored-by: Evgeni Golov <>

d559505b 11/03/2022 10:48 AM Maria Agaphontzev

Fixes #35696 - add bios info to reported data facet

605fc8b1 10/31/2022 05:33 PM Bernhard Suttner

Fixes #35583 - Skip dhclient installation

The dhclient package isn't available on the minimal ISO image for >= EL8, therefore installation fails because it tries to install this package. The IP address is managed by network manager.

32884e54 10/31/2022 10:23 AM Oleh Fedorenko

Fixes #35473 - Add extlogin API endpoint

/users/extlogin endpoint is designed for UI interaction, thus
using this endpoint to create a session to be used via API will
fail with "Can't verify CSRF token authenticity" for any method
except GET. We need to have a separate endpoint to create a proper...

1b245d59 10/25/2022 01:37 PM Leos Stejskal

Fixes #35536 - Template input_resource macro & preview error (#9428)

02ea67ce 10/21/2022 05:28 PM Evgeni Golov

Fixes #35658 - don't fail parsing Windows facts without os_name

When Ansible runs on Windows without Admin privileges, it will not
report `ansible_os_name` and `ansible_distribution` facts, as those
can't be read without being Admin. Don't fail to parse facts in this...

950040e4 10/14/2022 08:55 AM Chris Roberts

Fixes #35619 - Add kernel_version to reported data facet for new host UI

874c0d92 10/07/2022 01:01 PM Bernhard Suttner

Fixes #35569 - set correct icons

30c41d67 10/05/2022 07:33 AM Adam Ruzicka

Fixes #35547 - Include REX pull in kickstart default (#9430)

  • Fixes #35547 - Include REX pull in kickstart default
  • Refs #35547 - Output the snippet verbatim
767fea26 10/04/2022 01:13 PM Adam Ruzicka

Refs #35530 - Alternative approach to save_to_file

save_to_macro generates a command using cat and a heredoc string.
However, if the content to be written contains a heredoc using the same
delimiter, save_to_macro's heredoc will be terminated by it, leading to...

38365d82 09/26/2022 02:32 PM Adam Ruzicka

Fixes #35530 - Make save_to_file macro safer (#9426)

  • Fixes #35530 - Make save_to_file macro safer

save_to_file does

cat <<EOF >$file
$content
EOF

but if `$content` contains a heredoc terminated with `EOF`, it
terminates the heredoc that save_to_file creates....

a321f97a 09/15/2022 09:49 AM Leos Stejskal

Fixes #35331 - Use Anaconda rhsm in kickstart for RHEL 9

06600bcc 09/09/2022 09:23 AM Pat Riehecky

Fixes #35137 - Permit setting puppet tag during install

6614d14b 09/09/2022 09:21 AM Pat Riehecky

Fixes #35177 - Option to switch to graphical kickstart

b382bbc9 09/02/2022 01:40 PM Jonas Trüstedt

Fixes #35166 - Enable static IP for Ubuntu Autoinstall

  • Make IP method flexible and enable to switch between DHCP and static
  • Make BOOTIF default for multi-network device setup
  • Remove unused parameters from options

Co-authored-by: Bastian Schmidt <>

afd05182 08/25/2022 09:30 AM Ewoud Kohl van Wijngaarden

Fixes #35420 - Drop boot_settings.rb for early settings

With Rails 7 require_relative no longer works in a Gemfile (maybe it's
Zeitwerk?). Currently we only support Rails 6.1 anyway and if we can't
use the mechanism for Rails 7 this mechanism should be removed....

387608cf 08/10/2022 08:17 AM Shimon Shtein

Refs #35274 - Revert "Make columns on host index page selectable (#9319)"

This reverts commit b1b46b6a17b21c8aec566ef846ab70a8b2aa931c.

eebd309f 08/03/2022 12:46 PM Leos Stejskal

Fixes #35306 - host_puppet_* template macros ignores host_param (#9334)

When host.puppet_server or host.puppet_ca_server returns
empty string we don't load the values from host parameters.

b1b46b6a 08/03/2022 08:54 AM Oleh Fedorenko

Fixes #35274 - Make columns on host index page selectable (#9319)

8d1e1444 08/02/2022 11:16 AM Ewoud Kohl van Wijngaarden

Fixes #35299 - Remove redundant mocha inclusion

Mocha is already included in test_helper, using the non-deprecated
version.

b7afdcd0 08/02/2022 11:15 AM Ewoud Kohl van Wijngaarden

Fixes #35301 - minitest 5 deprecation fixes

This possibly overlaps with _() as a translation method. value() is also
an alias that can be used but using the assert* methods is more
consistent with the rest of the codebase

db023da3 07/25/2022 11:47 AM Nofar Alfassi

Fixes #4007 - updating users email to be optional (#9279)

0c1f4041 07/12/2022 04:23 PM Garret Rumohr

Fixes #34975 - Removed ks=. is supplied by kernel options snippet (#9238)

  • Fixes #34975 - Removed ks= from template. It is supplied by kernel options snippet.
  • Refs #34975 - Update snapshots

Co-authored-by: garret <>
Co-authored-by: Oleh Fedorenko <>

38d2bf3c 07/12/2022 02:12 PM Ewoud Kohl van Wijngaarden

Fixes #35182 - Add Rocky Linux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/rocky/grubx64.efi path is missing. This causes the server to refuse
to boot.

To make it easier to use the Rocky Linux installation medium is added.

59048d86 07/12/2022 09:00 AM Ewoud Kohl van Wijngaarden

Fixes #35196 - Use assert_equal to match rendered templates

This allows the report to properly show up in Jenkins, rather than the
unhelpful message that it didn't match.

8fbfbca3 07/11/2022 07:52 AM Bastian Schmidt

Fixes #34941 - Enable Ubuntu Autoinstall smart proxy deployment

  • Use foreman_request_addr to reference correct Foreman/smart proxy port
  • Use kernel and boot file variables from medium provider instead of static paths

Co-authored-by: Evgeni Golov <>

6f724472 06/27/2022 03:41 PM Adam Ruzicka

Fixes #35014 - Rework Net::HTTP extension

143054a6 06/23/2022 01:25 PM Pat Riehecky

Fixes #32612 - Add some extra metadata to the default kickstart

fc8b9d39 06/22/2022 01:11 PM Oleh Fedorenko

Fixes #32881 - Expose previous application record revision through safemode (#9258)

713a1878 06/16/2022 06:10 AM Adam Ruzicka

Fixes #34969 - Set up REX pull on client setup (#9235)

- Import katello-pull-transport-migrate
- Setup rex pull on registration
- Setup rex pull during provisioning
- Pass config params to slots/fills in registration form

d8be09ae 06/09/2022 12:00 PM Nofar Alfassi

Fixes #34948 - drop missing owner notification

91e49941 05/30/2022 12:04 PM Bastian Schmidt

Fixes #34700 - autoinstall template enable root user

The `identity` field doesn't allow to add/edit root as a user.
Therefore, the user-data field must be used. Compare the Ubuntu
Autoinstall documentation:
https://ubuntu.com/server/docs/install/autoinstall-reference#identity...

de56ffb2 05/26/2022 10:58 AM Ondřej Ezr

Fixes #34305 - stop creating settings in DB (#9050)

With the setting DSL, we hold all the necessary values for settings in the memory.
We can now stop creating records for the settings in the database.

1f145b5f 05/25/2022 09:11 AM Bastian Schmidt

Fixes #34908 - Set hostname for Ubuntu Autoinstall

1cf4147a 05/24/2022 07:07 AM Leos Stejskal

Fixes #34526 - Switch Rails version to 6.1

Changes overview:
- Set default Rails version to 6.1
- Required dynfow >= 1.6.5
- Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml
- ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter...

0462f797 05/18/2022 01:08 PM Lukas Zapletal

Fixes #34702 - use warning instead of halt for SCSI issues

Signed-off-by: Lukas Zapletal <>

7a7ed8fb 05/08/2022 10:10 AM Leos Stejskal

Fixes #34866 - Settings - Like operator for name

  • Allow ~ operator for name
  • Fix issue with double quote in search
  • Raise exception for unsupported operators :and / :or
2f2ec138 04/14/2022 09:32 AM Bernhard Suttner

Fixes #34710 - Use foreman request address

f3002022 03/30/2022 12:47 PM Maria Agaphontzev

Refs #34495 - Katello erros from Breadcrumb switcher

5d9d6d9a 03/28/2022 12:48 PM Bernhard Suttner

Fixes #34658 - Harmonize preseed templates

add9562f 03/26/2022 11:48 AM Lukas Zapletal

Fixes #32572 - PBKDF2 password hashing support

Signed-off-by: Lukas Zapletal <>

74f6bdb8 03/15/2022 11:14 AM Ondřej Ezr

Refs #34558 - update snapshots

9b83dfe5 03/11/2022 10:58 AM Ondřej Ezr

Fixes #33782 - do not use fixtures for Settings

As we no longer require settings in DB, we may drop the fixtures for settings.

11febf2d 03/09/2022 09:05 PM Tomer Brisker

Refs #10413 - Remove unattended: false from tests

3253d649 03/09/2022 02:26 PM Ondřej Ezr

Fixes #34573 - encrypt DSL setting values

DSL setting values were not properly encrypted as the encryption flag has not been propagated into DB model.

db399691 03/07/2022 09:47 AM Sayan Das

Fixes #34525 - Call insights snippet by honoring host_registration_insights param during system build

0ed80f45 03/04/2022 11:52 AM Ondřej Ezr

Fixes #34339 - sanitize fqdn in tests

Tests were almost not using the fqdn defined in settings.yaml.test
That is quite confusing at first sight and we should not override this value by fixtures, only if overriden in the same test file.

a2adaca0 03/02/2022 04:17 PM Lukas Zapletal

Refs #34489 - update snapshot tests for Yast PXE

dd8ff395 03/02/2022 12:41 PM Lukas Zapletal

Fixes #34532 - disable EFI local chainloading by default

Signed-off-by: Lukas Zapletal <>

749e7f2d 03/01/2022 08:25 PM Lukas Zapletal

Fixes #32632 - initial verison of Ubuntu autoinstall templates

Signed-off-by: Lukas Zapletal <>

dea863a9 02/23/2022 11:37 AM Ewoud Kohl van Wijngaarden

Fixes #34450 - Normalize CentOS casing from facts

This aligns Chef and Salt with the other fact parsers. The Salt fact
parser logic is changed so it's easier to read.

221d255d 02/21/2022 11:00 AM Ondřej Ezr

Fixes #30122 - remove usage of controller level force_ssl

Foreman's use case for HTTP-only is provisioning. Many installers, like Red
Hat's Anaconda or Debian Preseed, either do not support it or make it very hard
to use HTTPS. This is especially hard since often a custom CA is used so the...

92ac0e94 02/10/2022 03:54 PM Ondřej Ezr

Fixes #34375 - allow passing empty attributes for facets (#9083)

Facets were rejecting empty attributes to not create empty facet.
Originally this was to fix an issue in 5d64eef2cba8e56ad39510c3bd1d724bd52762eb
Tho we want to pass empty attributes to facets that already exists....

d7440ee3 02/02/2022 01:22 PM Lukas Zapletal

Fixes #34330 - fix rhsm puppet parser for IPv6

Signed-off-by: Lukas Zapletal <>

c693cd93 01/31/2022 02:27 PM Ondřej Ezr

Fixes #34323 - use defaults from memory

This loads values from database only if the values are in the database.
If there is no value populated for the Setting, we want to read the default from memory.

c6fc10ea 01/31/2022 02:27 PM Ondřej Ezr

Refs #34323 - sanitize setting fixtures

Setting fixtures should not be used to override defaults for tests unless meant for every test.
If we mean to override the setting value for all tests, we should override value and not the default.

ef2ff068 01/30/2022 01:25 PM Adam Ruzicka

Fixes #34329 - Allow permissions to be excluded from default roles

aa8657bc 01/21/2022 05:12 PM Ondřej Ezr

Fixes #34006 - use rbac_registry for all plugin rbac

Before this change we have executed all the changes to the Roles and Permissions right away in the plugins.
This pushes all the changes into the rbac_registry and uses it to initialize the changes only after Rails are ready.

a59c8213 01/21/2022 05:12 PM Ondřej Ezr

Fixes #34010 - add a setup hook to RbacRegistry

RbacRegistry should hold all the information about the Plugin RBAC.
This method will be responsible for initializing in the database in the future.