Fixes #11031 - ignore identifiers of interfaces being destroyed

(cherry picked from commit 1e7822a586b6e4f288823df0b9419ef2749d6b8c)

Fixes #10915 - Deleting a host removes all host specific overrides

(cherry picked from commit 674755f43684f76e6b23ca499a57153aad3db5e2)

Fixes #10867 - OpenStack boot_from_volume is true only when checked

(cherry picked from commit 776cff93637b006cb69063fecf142e776acd1378)

Fixes #10607 - match bonds based on identifier only

(cherry picked from commit 7be20b248502eb8682008e1c6b03fef71da4f73d)

Fixes #10888 - skip attached_to updates if identifier was blank

(cherry picked from commit db6d6b8b7d0d2e90e27d4c23308e5db26abd3820)

fixes #10627 - apply host taxonomy scope to facts/report joins

Previous changes to perform a join onto hosts with authorisation result
in a query such as Report.joins(:hosts), which ignores any
default_scope on Host::Base. This commit explicitly passes taxonomy...

Fixes #10566 - allow identifier modifications that do not change interface type

(cherry picked from commit a6b8542a0e1a7eb0d71fdd1d328b224669e3010b)

fixes #10646 - disable NIC subnet taxonomy checks when feature's disabled

(cherry picked from commit d6a192531b7203b12f5e755a7b695435c423ece4)

fixes #10397 - parse Windows Local_Area_Connection interface name

(cherry picked from commit d07bcaf034909c0b6753e77bb80b6eade95a7b87)

fixes #10586 - make the 401 status comparison actually match.

(cherry picked from commit 3196ebaa009ca1d79e1330d36a0362b7ca04aade)

fixes #8597 - escape slashes for ptable URL parameters

(cherry picked from commit 053c032dba5b52593c0235d96d74cdd1aae65721)

fixes #9873 - generate unique alert mails for each user group member

To create distinct mails, new Mailer instances are required instead of using
the same one - else, the last message changes the previous ones. The recipient
list is now determined in the ReportImporter, and the MailNotification helps...

Fixes #10535 - building a token instead of creating it until host is saved

(cherry picked from commit c2ff4bd6874155459a51af070abb381fd59be262)

fixes #10482 - get external user group members only once during refresh

(cherry picked from commit 0fd7412faaa76787bf15ed1901ffc9eb4d6353fa)

fixes #10509 - add toggle for LDAP usergroup updating

(cherry picked from commit 19bf6b096c03b999a02c82b61dfe0694cbb21a9a)

Conflicts:
app/models/auth_sources/auth_source_ldap.rb

fixes #10493 - disable usergroup sync on login when $login is used

(cherry picked from commit 7891164bffb6746b13dde15a2d38f3371d0abab7)

Conflicts:
app/models/auth_sources/auth_source_ldap.rb

Fixes #9634 - creating a host with an interface and without os returns a validation message

(cherry picked from commit 93dbb7e77dc3502a5cfa6888a13212bed7e178f6)

Fixes #10379 - disables cloning if unattended mode is disabled

(cherry picked from commit 0f5c60f29626d02e91405db27bb057df34c7db39)

Fixes #9966 - More debug messages for matching nics from fog

(cherry picked from commit c796609085caeee03be4ec378b5311fd61ba6684)

Fixes #10212 - validate DNS name uniqueness of interfaces

(cherry picked from commit 60fdfb3851cad0ff347788c1f796d709693a8f27)

Fixes #5568 - Improves performance of trends:clean rake task

Perform trend counter dupe counting within the database rather than in the Ruby code.

(cherry picked from commit 040abfa32f326de7cd488f34f243377f76fd70ae)

Conflicts:
test/lib/tasks/trends_test.rb

fixes #10403 - resync names of unmanaged hosts to their primary NIC

MoveHostNicsToInterfaces previously ignored unmanaged hosts, but they
need migrating too. Updated the existing migration to migrate both,
then for existing hosts, add a new migration to ensure all primary NIC...

fixes #10298 - handle destroyed but present interfaces

When deleting a host and DHCP orchestration is removing reservations for NICs,
it generates a dhcp_record that contains next-server data. Determining the
next-server IP causes the primary interface to be fetched for DNS resolution,...

Fixes #8333 - correct matcher values with multi-key matchers

(cherry picked from commit a3d8204a4d7d2eb7355c149d602aa43e8de8aff4)

fixes #10343 - only log cache deletion failures when saving settings

(cherry picked from commit 83bd400ce6d69c8f946ff5ed31012ab073fcf1b1)

Conflicts:
test/unit/setting_test.rb

fixes #10342 - adding :host_parameters_attributes to except list in template_used()

(cherry picked from commit d4e53f27fefffc4a1b2b0f25f2d35accf5d4de6e)

fixes #7743 - ensure name is unique in scope of major and minor

(cherry picked from commit 59b230959ab24b3573eb87616805bf3218a2cb13)

Fixes #5554 - fixed hostgroup and fqdn validations in multiple matchers

(cherry picked from commit eb414b8bbdc7897f396d184996fac402b3277cef)

fixes #9773 - correctly render template URL

(cherry picked from commit f7174439285708c3010605230fec16797f3a0763)

fixes #8817 - look up reports with all joins from host scoped_search

This changes the optimisation in d50c799 which caused errors for users with
host filters referencing tables other than hosts.

When retrieving all reports joined with authorised hosts, the nested joins need...

fixes #10234 - Fix NIC taxonomies validation tests

Some of the tests in #9391 changed the way subnets should work regarding
taxonomies and some test data, this commit fixes that so tests are green
once again.

(cherry picked from commit 7678cac5ac26eb8ff2a35dedfc4acc189c815203)

Fixes #9391 - Added validation code to NIC, so it validates that host's location/org is compatible with the one set on NIC's subnet

(cherry picked from commit 8f695d94a2f32fea3363cc017fc59baf6ca15b17)

Fixes #10123 - Tests API v2 external user groups

The addition of a .refresh call after create, update and delete, caused
our tests to fail because of many failed calls to LDAP.
We can just expect the method to return true as we're not testing the
refresh functionality in these methods....

Fixes #9884 - refresh deleted external usergroups

(cherry picked from commit e780381933a7838af4be9a550942ef0f22608fd4)

fixes #5909 - return r/w resources from authorized scope

(cherry picked from commit 0d80512c3293895750ffda82489b719c38ec5612)

refs #10168 - fix test that created a duplicate primary interface

Subtle interaction between 4d5b979 and a5dc3e2, resulting in the test
that tried to add an interface to an unmanaged host duplicating the one
that was automatically added.

(cherry picked from commit 225cfa5bd0024954f8d4e15efeb3938c11a50552)

fixes #10168 - delegate fqdn/shortname to primary interface

(cherry picked from commit 4d5b979541902c2163d98ca8fd53d230445b60ac)

Fixes #10111 - Use a dummy primary interface for unmanaged hosts

Unmanaged hosts require a host interface due to delegation of networking
attributes, and some others like 'name'. Since unmanaged hosts do not
necessarily have an interface associated (unless created through puppet...

fixes #10020 - add next-server/filename attrs to provision NIC DHCP record

A host's DHCP record used to be constructed with PXE attributes in
Orchestration::DHCP, but moved to Nic::Managed during 43c4bd7. Nic::Managed
didn't add PXE attributes, so this commit adds these when provision? is set....

Fixes #10093 - VMware#create_vm calls clone_vm

Apply '.with_indifferent_access' to the args passed in to create_vm,
ensuring symbol test for args[:image_id] succeeds when args["image_id"]
is present.

(cherry picked from commit 140cfe262eac838e76eb27517bd0271beab9be15)

Fixes #9947 - restrict user taxonomies if none is set

(cherry picked from commit abe910f2a46f4ecc1f349263d0b4751ed46ff200)

Fixes #7615 - filter ignore current context

(cherry picked from commit 76fca93b0093e9b4174d1a888ffca9f3fcb886c9)

Fixes #9362 - Corrected CoreOS mediapath

(cherry picked from commit 9f858eb43200809f931321821880f1ae9ca9db54)

Fixes #8812 - Pass model type so search_for is called on Host

At least on version 1.6.1, the absence of this second parameter leads to a
runtime crash when it's time to validate if the current user (non-admin) is
allowed to perform a power operation on given a host via the APIv2....

Fixes #10002 - Add attribute ancestry to taxonomies API v2

(cherry picked from commit 1f47202ce4e70fd036437f1d81646b6b811bf02d)

fixes #9778 - return r/w host when finding and associating to CRs

(cherry picked from commit cd4c4ad907fdadae66576f64831204711748bef3)

Fixes #9967 - make sure User.current is isolated

(cherry picked from commit fbbda1282c4ea4f17bd12132aa61f4a66832e8b8)

Fixes #9926 - do not always set LDAP encryption method

(cherry picked from commit 5d5e0bb601ad75a514168a263a6a360c496cb2af)

Fixes #8890 - Allow selection of plaintext "encryption" method for root password

(cherry picked from commit 331ff165939399787022e77ad17778e2ac39c148)

Fixes #9618 - make identifier uniq per host

(cherry picked from commit f2d5f95539b5070f5c7aba37196c45346140357d)

Fixes #8727 - DHCP validation does not fail on discovered leases

(cherry picked from commit 37bb1b44a9753382c6858e22ac55031e9662c4e4)

Fixes #7378 - fixed API lookup keys filters

(cherry picked from commit bc68c48da5b718084c3e531e61e48124e8e00d36)

Fixes #9885 - pass verify_mode to net/ldap

(cherry picked from commit fc3faf6f4e8c1f0efd62e8c58687b3d30c69b67e)

fixes #7407 - puppet class parameters should be cloned in #clone

(cherry picked from commit 7691ab4a56a49118f6cf97ca7f6de1c932b99e2a)

fixes #9775 - always load Encryptable when key's missing, log runtime warning

a59972c3 causes Encryptable to be loaded before the encryption_key.rb
initialiser and the majority of the class was skipped as the key was undefined.

Now Encryptable always loads, but logs at runtime if the key is unavailable,...

fixes #9469 - redirect to reports#index on destroy

(cherry picked from commit 0b1dafbbef20e185a9e4fdda626796db4a6168bd)

Fixes #9434 - managed alias accepts only static boot mode subnet

(cherry picked from commit a45253c2b7c747b15506dddc4efa86396c6ef53f)

fixes #9795 - check if mail is enabled before sending a notification

(cherry picked from commit 7ca39b3442be76da89c2c52d8da0c2d6afb74af1)

Fixes #8779 - add vlanid to subnet ENC

(cherry picked from commit a899d97175c683bb648e3cbd34d0aebcae1252cf)

Fixes #9842 - rename the register method which deprecates the old one

(cherry picked from commit 0a30da74a18c21a0f8755fb45d904e4f0b4a52a5)

Fixes #9787 - correctly typecast default values

JSON and YAML default values were double typecasted, once by active
record and then by value_of_key method.

(cherry picked from commit a2468540b62942a2a9adfb428003d5308df7ab56)

Fixes #6454 - Display error message when user_data is needed but not set

(cherry picked from commit b99708ac7a1bb0e139505c2549c0f36fa5a65f83)

fixes #4424 - overriden attributes get overridden in the UI

(cherry picked from commit 0575b5b0a07c59c443bf2be663cb67d6a5e40f19)

Fixes #9631 - adds missing bond test

(cherry picked from commit b3bdb09208a3966cda8cf5828802fed5157b7e1c)

Fixes #9673 - treat YAML and JSON lookup keys as strings

(cherry picked from commit 25a7f806ed586bd32ee647f2acd8e5a0224cbbfb)

Fixes #9657 - merge NICs from compute profile in host create API

- updated api docs for hosts and interfaces
- host create/update api actions now merge interfaces from compute
profiles
- NIC type mapping extracted into a separate class
- return full host detail after host update...

Fixes #9678 - Can't update admin flag for users via API

find_resource needs to be defined prior to UsersMixin is included as it
requires the variable @user being set.

(cherry picked from commit 1b1b39861e485523b0cc0c6435fef30c38df7e07)

fixes #8358 - validate domain on host update

(cherry picked from commit cbe1391f48f37d4bf9a53091c668b6a91bc6ef83)

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Fixes #9615 - Adds inheriting_mac method

Using this method we can find out the MAC of interface to which this
interface is attached to. This can be used in provisioning template when
we check for real interface name.

(cherry picked from commit 5ad3c4f34b50fb1ac6d9f26e71e183813ab1c96f)

fixes #8878 - ensure domain fact is downcased prior to import

(cherry picked from commit 25a647eb04ac2d31af99c85e447d58d1de4185e6)

Fixes #9547 - DHCP is default subnet boot mode

(cherry picked from commit 9e5fad812a64055272b9cc650c2d387027638c71)

Fixes #9590 - make info test less fragile

(cherry picked from commit e24c3fbbe5d089f76b89f909b65b2bd2205a5035)

Refs #9500 - revert normalize_name tests

Current test "#normalize_hostname sets a domain based on name that contains its name if it's nil and such domain exists" is not testing anything because Domain.all does not return any domains to match (as .create was substituted on merge by .build)....

Fixes #9495 - Require identifier for managed bonds

(cherry picked from commit e329155b185e3be5863bfd79582b61a6ecc9ae9a)

Fixes #9497 - Require MAC for managed BMC

(cherry picked from commit 6a2fce1fa6a80865bb8292e76a8bd285e714a5c8)

Fixes #9427 - Return meaningful errors from subnets/freeip and parse the error response to the UI

(cherry picked from commit b9521a8dc7f4e61a011cabbfdfe78657bd3c24d2)

Fixes #9147 - move managed checks to the start of the DHCP/DNS/TFTP orchestration checks

(cherry picked from commit 5440d482b0087fe29b3fb4567e0ca73f2d3af221)

fixes #8331 - provide some tools for filtering mail

(cherry picked from commit a08e66ff1192e00d6dd8eafccd5bf5cd0e4183f9)

Fixes #9500 - matching uses the whole domain name

(cherry picked from commit ede6d4ea8b266e3a90fc6c639929be2b55be225c)

Fixes #9429 - identifier is required for Alias and VLAN

fixes #6655 - remove _ForemanSelectedhosts cookie on action submit

Refs #3809 - Remove classcheck cop

Refs #3809 - Remove various small cops

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

fixes #9358 - match unattended template requests against provision interface

fixes #8953 - update IPA userclass param on realm update

Fixes #9357 - Making description db types consistent across Foreman

refs #9138 - skip all interfaces UI tests, which fail randomly

fixes #9212 - using headless browser in order to run Capybara tests

fixes #9274 - hostgroup#clone clones config groups

fixes #9249 - associated_host fixed for all compute resources

Fixes #9186 - build interface if needed during facts import

Fixes #6884 - Installation media without $minor generate broken $version

$version is generated with the major version and a dot, producing paths
like foo.bar/x64/7. which don't exist. For CentOS at least we want to generate
a path without the dot. The default values for these media have been changed too.

fixes #9030 - Adds support to clone config template via api

Refs #3809 - Enable cop StringConversionInInterpolation

Refs #9138 - temporarily disable affected intermittent tests

Fixes #8052 - allows erb in array and hash params

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...