Fixes #37434 - Use nightly for develop manual links

Foreman has for the longest time had
https://theforeman.org/manuals/$next redirect to
https://theforeman.org/manuals/nightly in our Apache configuration. This
means that on every branching we need to modify this. It also doesn't...

Fixes #37463 - Fix permission handling for table prefs

Before this change non-admin users could create, but not update their
own table preferences as the default scope tried to check
various *_table_preferences permissions which don't exist at all.
Alternatively, we could introduce these permissions and grant the...

Fixes #37432 - Fix Style/GlobalStdStream cop

Fixes #36830 - transform_vars on preseed_path

Co-Authored-by: quartsize

Fixes #36691 - use 'connectefi scsi' by default

Co-Authored-by: Shimon Shtein <sshtein@redhat.com>
Co-Authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Fixes #37367 - Switch to 'network' directive instead of ifcfg

Fixes #36525 - kickstart's RHSM line only works on RHEL hosts

Fixes #36885 - Add Clevis/Tang disk encryption template

For disk encryption Clevis/Tang is often used. This commit introduces
partition templates for Kickstart and Autoinstall taking care of disk
encryption and a snippet responsible for binding the LUKS device via...

Fixes #37337 - Fix snapshot task and add Rocky 8 & 9

Fixes #37287 - Iterate on hashes when both key and value are used

This replaces the `hash.keys.each { |k| hash[k] }` and `hash.keys.sort`
patterns with `hash.each { |k, v| }` where it makes sense. This avoids
doing hash lookups when you already know the value anyway.

Fixes #37273 - Use delegation syntax for resource_scope

In Ruby 3 you need to explicitly delegate keyword arguments, or if you
don't care about Ruby 2.6 or prior then you can use the new delegation
syntax¹.

It deals with the difference in calling where. When calling `.where([])`...

Fixes #37065 - report_row now explicitly accepts kwargs
also adds a test which fails without the fix

Fixes #37132 - Fix sorting problem in os integration test

Fix Style/CommentAnnotation cop

Fixes #37150 - Race condition in edit smart proxy test

Fixes #37043 - Inheritance overrides host facets

Fixes #37179 - Clone hostgroup facets when cloning hostgroup

sort taxable_ids before comparing them

For some reason, taxable_ids and visible_dummies are sometimes sorted
differently, resulting in failed tests even tho the right taxonomies are
found, just in the wrong order.

Use assert_equal_arrays that sorts the arrays before comparing them.

Fixes #37011 - Apply latest Ubuntu Autoinstall userdata changes

• Add explicit fallback for offline installation
• Replace deprecated lock-passwd with lock_passwd
• Remove empty ssh keys array if none provided

Fixes #37184 - Report template generates incorrect kernel version

Refs #36502 - update snapshots after template change

Fixes #36891 - Provide a scope for email-notification-eligible users

Fixes #37168 - fix potential for duplicate html-id

Fixes #37092 - Use minitest_reporters_github in GHA

This is a specialized reporter to provide GitHub annotations on failure.
These annotations can be seen in the changes files tab.

Refs #37102 - Read real webpack manifest in test

In some test cases (like controller tests) the real manifest isn't
needed, but in integration tests they are.

Rails has deprecated controller tests in favor of integration tests, but
Foreman still has them. This modifies the fake read_webpack_manifest to...

Refs #36849 - Enable strict keyword argument matching

Fixes #37015 - Refactor OwnerClassifier

- Introduce `classify_owner` class method for owner classification.
- Implement private method for input validation.
- Add error handling to raise the necessary exceptions.
- Add deprecation warning to the `user_or_usergroup` method.

Fixes #37102 - webpack 5

Fixes #36972 - Make hammer accept unlimited as JWT life time

Refs #36849 - Update tests for documentation_url

Fixes #36160 - add display_name field to Host GraphQL type

Refs #36849 - Remove deprecated URI.{encode,decode}

These are dropped in Ruby 3.0

Refs #36849 - Fix Ruby 3 kwargs handling

Fixes #37019 - Correct release names in OS factories

run external kickstart and grub tests on GHA

Fixes #36917 - Create current user permissions API

Refs #32848 - Ensure the Foreman version is nightly in tests

This copies the behavior of the stable release test for nightly to avoid
breaking on stable branches.

Fixes #36869 - update hosts path with current_hosts_path

Fixes #36930 - Make invalid YAML test compatible with libyaml 0.2.x

The valid {a:test} is invalid with libyaml 0.1.x but is valid with
0.2.x. This changes the test to @@ which should still raise a
Psych::SyntaxError.

Fixes #36892 - Pass host results to REX slot;
allow root node permissions to be extended
Refs #36892 - improvements to regex & index layout

Fixes #35601 - Search in navigation

Fixes #32848 - Support linking to docs.theforeman.org

An effort is under way to use docs.theforeman.org as the primary
documentation source. It is already the official documentation source
for Katello, but until now it wasn't easily possible to (correctly) link...

Fixes #36867 - Add host delete & create
Add bulk modal with bulk params
add register/create buttons; fix links
address UX comments
Remove icon from delete action in the toolbar’s kebab
In the delete modal as a primary button use just “Delete”
(not delete host)...

Fixes #36880 - include LookupValue permissions in fixtures

fixes #36160 - Redefine append domain names setting

This PR aims to unify the format of host names stored in the database and the way they are displayed.
With this change, the name of the host is always going to be stored with the domain name appended.
The setting formerly named `append_domain_name_for_hosts` is now renamed to `display_fqdn_for_hosts`...

Fixes #36796 - Make host_facts_updated event visible

Fixes #36799 - Add Salt image path to ConfigReportsController

Fixes #36786 - Permit Symbol for YAML.safe_load report parser

Fixes #36723 - Remove Fedora/Red Hat Atomic related code

As far as I can see this has been EOL for a few years now. Red Hat
Atomic went EOL in 2021.

Fixes #36759 - only call allowed transpilers

CVE-2022-3874: OS command injection via ct_command and fcct_command

Instead of allowing to call any command by changing a setting, only
allow specific paths to ct/fcct. If the user needs a different path,
they can set it via settings.yaml.

Fixes #36715 - Speed up host fact retrieval

Fixes #36768: Prevent redirection to other hosts via HTTP referer header

Fixes #36466 - Allow gathering information on deleted records

Fixes #36699 - Reject invalid expiration dates for PATs

Previously invalid dates were silently discarded, resulting into PATs being
created without expiration dates.

Fixes #35124 - Fix preseed_kernel_options to work with full-host-bootdisk deployments

Update corresponding template snapshots.

Co-authored-by: Bastian Schmidt <schmidt@atix.de>

Refs #36677 - fix tests

Fixes #36661 - remove restore_plugins from test_helper

Fixes #36660 - drop value from settings dsl

also update plugin docs to use a seed instead of a migration if they
need a value

Fixes #36639 - Use Templates feature on IPv6

This now looks at, and prefers, the IPv6 subnet on the
provision_interface to determine the template proxy. This allows using
the Templates feature in pure IPv6 provisioning setups.

Fixes #36644 - Validate root_url before using it

Fixes #36651 - Support Minitest 5.19+

• This reverts commit 1c3a4155f286352e0abbf0d0b298e47e81c2d6c5.
  Thus un-pinning minitest again
• update minitest-spec-rails to 7.1+
  This contains a fix required for minitest 5.19+
• Update mocha to 2.1+ for minitest 5.19+ compat...

Fixes #36219 - use YAML.safe_load instead of YAML.load

as explained in this rubocop rule https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/YAMLLoad

Refs #30344 - review fixes

Fixes #30344 - use pf4 navigation

Fixes #36509 - Fix totalCount handling for GraphQL queries with first parameter

Fixes #35942 - pass from settings not encrypted

Fixes #36490 - Remove redundant ERB closing tag in coreos template

Refs #36490 - Regenerate template snapshots

Fixes #36189 - Add AlmaLinux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/almalinux/grubx64.efi path is missing. This causes the server
to refuse to boot.

To make it easier to use the AlmaLinux installation medium is added.

Fixes #36395 - move value setting to seed

Fixes #36370 - allow all providers in the graphql enum

Otherwise plugin-based providers are not allowed

Fixes #36180 - iPXE provisioning template for Ubuntu autoinstall

Fixes #36309 - Increase LDAP auth source password length limit

The database field is 255 characters long, but the encryption adds quite
a lot of fluff. From my testing, 69 characters is the longest password
than can fit in.

Both FreeIPA and openldap cli tools seem to support passwords...

Fixes #36097 - protect rendered template

Fixes #36017 - Remove spacing for array type settings

Fixes #35068 - Expired build token should return 401 instead of 412

Fixes #35949 - move select_multiple_puppet_proxy to the puppet plugin

Fixes #35701 - Export button should use selectable columns

Fixes #35978 - Update pf to 2022.16+ release

Updates foreman-js(patternfly) to have access to the name prop in Search

Fixes #36014 - Kickstart default - remove @core group

The Core group is always selected, it is not necessary to
specify it in the %packages section.

Fixes #35840 - Install chrony on RHEL 7

Fixes #29939 - drop category column from settings

Settings table was holding category column to support old style of
settings, but it is now ready to be decomissioned as plugins were given
enough time.

Fixes #35894 - Properly detect setting changes

Previously we missed setting changes which changed a setting back to its
default value.

Refs #34305 - Fix load_values test

Refs #32685 - Keep modulized model name in Global ID

Fixes #35550 - change autocomplete to be pf4

Fixes #35286 - New PXEGrub2 template for Ubuntu Autoinstall

- Introduce new PXEGrub2 Autoinstall template
- Move network configuration out of PXELinux Autoinstall template to
new preseed_kernel_options_autoinstall snippet
- Add snapshot for preseed_kernel_options_autoinstall...

Refs #35796 - Reduce empty lines

In 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c an additional empty line was
generated which broke the snapshots. This takes it a step further and
also removes various other lines in the generated output.

Fixes: 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c

Fixes #35674 - Add more custom pre/post snippet hooks

Refs #35530 - Dont use shellescape on the filename

Fixes #35088 - Remove GCE Compute resource code

All code related to GCE compute resource
is now in Foreman Google plugin

https://github.com/theforeman/foreman_google

Fixes #35397 - Preseed Autoinstall incorporate host_params

• Param 'keyboard' to set default layout
• Param 'lang' to set default locale
• Adapt template snapshot accordingly

Co-authored-by: Bastian Schmidt <schmidt@atix.de>
Co-authored-by: Evgeni Golov <evgeni@golov.de>

Fixes #35696 - add bios info to reported data facet

Fixes #35621 - Make power status a selectable column

Fixes #35583 - Skip dhclient installation

The dhclient package isn't available on the minimal ISO image for >= EL8, therefore installation fails because it tries to install this package. The IP address is managed by network manager.

Fixes #35473 - Add extlogin API endpoint

/users/extlogin endpoint is designed for UI interaction, thus
using this endpoint to create a session to be used via API will
fail with "Can't verify CSRF token authenticity" for any method
except GET. We need to have a separate endpoint to create a proper...

Fixes #35536 - Template input_resource macro & preview error (#9428)

Fixes #35658 - don't fail parsing Windows facts without os_name

When Ansible runs on Windows without Admin privileges, it will not
report `ansible_os_name` and `ansible_distribution` facts, as those
can't be read without being Admin. Don't fail to parse facts in this...

Fixes #35619 - Add kernel_version to reported data facet for new host UI

refs #35069 - ApplicationRecord.<=> undefined method 'name'

Fixes #35569 - set correct icons