Foreman » Installer

Pass the dhcp_key_name and dhcp_key_secret to the dhcp module

closes GH-186

Partial puppet lint fixes

Fixes #9321 - Add option to change or prevent option domain from being set in dhcpd.conf

Closes GH-149

Fixes #7263 - make sure the ip address from interfaces is valid

Fix indentation lint issue, remove commented code

Fixes #6751 - convert alias/VLAN interface names to fact expected value

Linting

Simplify proxydhcp inline templates

Prefix all dhcp parameters with dhcp_

Remove $dhcp_reverse

Remove a debug notify

This notify will mark the server as active every run and adds little value.

Create class parameter to override ethernet-device-based IP for the nameservers
- Based on Ewoud Kohl van Wijngaarden's original patch

Remove ntpservers call from dhcp code

- Clean up OS specific DHCP settings
- Fix a regression which breaks the DHCP config
I introduced this in c64274554ea54a0a2adb85561e949228731dd5a5

puppet-lint fixes

Parametrize params so that they can be overwritten

Following the pattern from puppet-puppet and puppet-foreman.

Give DHCP and DNS options to specify the bind interface

net-ping pulled in by proxy dependencies, no need to specify

Enable optional DHCP/DNS modules