Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #20590 - full ovirt cloud-init support

Currently, the cloud-init integration supports only a sub-set of
cloud-init commands. With `custom_script` support, one can pass
arbitrary cloud-init yaml to the managed host and make sure
the provisioned host will get it unchanged (which is not the case...

Revert "Fixes #22117 - Add support for number of sockets for ovirt"

This reverts commit 073046ccd8c469633e4ca1c345038b26bd156895.

Fixes #22117 - Add support for number of sockets for ovirt

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #22546 - CVE-2018-1097: Bump fog-ovirt for power action fix

Fixes #2828 - Report an error when trying to save ovirt resource

On both create and update, there was no exception handler to captured
given exception. That resulted in having an exception screen instead of
an error message.
The fix capture all of the given exceptions, and report them as an...

Fixes #22282 - Test oVirt connection before save

Fixes #10273 - Clone disk from template when preallocate marked

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #22079 - Fix Lint/UriRegexp cop

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #20528 - Remove direct connection to rbovirt client

fixes #5441 - Add instance_type support to oVirt provider

Fixes #21718 - Show errors properly when creating new oVirt CR

We try to retrieve available operating systems in an after_validation
hook. Trying to retrieve them makes no sense if the URL isn't
considered valid by us.

Fixes #20952 - Replace AC::Parameters Hash methods

Replaces any methods that used to be from Hash with the more limited
ActionController::Parameters API.

Fixes #19326 - create compute-resource - URL optional

Fixes #20452 - Keep password value after validation in ovirt CR

Fixes #20174 - handle no storage pool gracefully

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19236 - handle situation when host is destroyed oVirt

The issue was introduced in 4269abbd, where we replaced the
`OVIRT::OvirtException` error by `ActiveRecord::RecordNotFound` in
`find_vm_by_uuid method`, but we haven't updated the corresponding...

Fixes #12272 - Support multiple certificates in ovirt resource

Fixes #10539 - Add default names for ifaces for oVirt CR VMs

Fixes #2314 - fine grain for RAM selectors

Fixes #13047, #16291 - Upgrade datatables and move it to npm

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Turning on the AndOr cop

Fixes #8289 - handle user data in ovirt

Fixes #15345 - allow changing oVirt CA certificate

Fixes #15344 - recover from fingerprint error on validation

Fixes #15066 - operating systems and ovirt < 3.6

The operating systems endpoint was added in ovirt 3.6
https://bugzilla.redhat.com/show_bug.cgi?id=1050243. Older versions
were failing getting 404 when provisioning.

This patch adds a check for this case. We also cache the operating...

Fixes #15163 - use new oVirt CA cert endpoint

Fixes #10278 - don't replace . with - for oVirt VM anymore

The version that supports . in VM names (v3.1.0-18) has been around
for almost 4 years
now (https://github.com/oVirt/ovirt-engine/commit/540a75e0f7bc4b9ed879471d3d830d575c6d6060).

Time to move one and make the VM names in oVirt a bit nicer now.

Fixes #6959 - set operating system for RHEV/ovirt VMs

Backward compatible, but works best with https://github.com/abenari/rbovirt/pull/104

Fixes #10978 - fix possibility to assign networks in compute profile for ovirt

fixes #14415 - check CR availability with Fog, not SETTINGS

Simplifies the code for checking compute resource availability, which
can easily be determined with the registered Fog providers instead of
being stored in SETTINGS in app initialisation. Plugins should always be...

Fixes #13091 - Paginate VMs for supporting compute resources

Loading all VMs for the compute resource view can be a very heavy task,
which leads to timeouts when attempting to load all VMs for a compute
resource that has many hundreds or thousands of VMs. This patch allows...

Fixes #9932 - fix preallocate attribute mapping

Fixes #13040 - oVirt now autoloads SSL certificate

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

Refs #3809 - Enable Rails delegate cop

Fixes #10248 - cloning volume information for virtual machines

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

fixes #9240 - in case of hash with indifferent access, serialize as hash

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

fixes #9249 - associated_host fixed for all compute resources

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Fixes #8796 - Fix to_gb size calculation and constentize

Refs #3809 - Remove useless assignments

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Fixes #7522 - made CA textarea editable for oVirt/RHEV

Fixes #6476 - oVirt VM association with multiple interfaces

Fixes #6608 - expose disk usage info through available_storage_domains API

Fixes #6816 - pass oVirt quota as nil instead of "" to prevent server error

fixes #5197 - Preallocated disk support for oVirt

fixes #4612 show friendly CR names, fix typo in oVirt name

fixes #4422 Implement available_images for oVirt to populate new image form

fixes #4555 add ca certificate to ovirt

fixes #4581 Implement available_networks API for VMware

fixes #4245 - return HTTP body for oVirt SSL CA certificate

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4015 - support oVirt using templates like images

fixes #4222 Add capability to compute resource API to retrieve cluster,network,storage info on oVirt

fixes #4023 - API v2 - compute resources partials should should attribute alias names and not database column names

fixes #3867 - Wrong Compute Resource type shown on overview

fixes #3178 - add feature for compute profiles for hostgroups and hosts

fixes #3896 Retrieve OVirt CA certificate via same URL scheme as API URL by disabling SSL verification

fixes #2741 - rails 3 syntax

fixes #2288 - Add oVirt/RHEV Quota Support

fixes #1923 - matches vms on a compute resource to hosts

fixes #2809 - send host subject as xpi opt to prevent ssl connect errors

fixes #2411 - move STI models in /models and /lib/foreman/models to sub-folders