Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #22117 - Add support for number of sockets for ovirt

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #21580 - require rbvmomi

The compute resource for VMware was using rbvmomi classes wihout
explicitly requiring rbvmomi. That can cause issues in tests.

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #19990 - VMWare allow save vm w/o size_gb attr

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #20590 - full ovirt cloud-init support

Currently, the cloud-init integration supports only a sub-set of
cloud-init commands. With `custom_script` support, one can pass
arbitrary cloud-init yaml to the managed host and make sure
the provisioned host will get it unchanged (which is not the case...

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Revert "Fixes #22117 - Add support for number of sockets for ovirt"

This reverts commit 073046ccd8c469633e4ca1c345038b26bd156895.

Fixes #22117 - Add support for number of sockets for ovirt

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #23076 - Fix Style/TrailingCommaInHashLiteral cop

Fixes #22546 - CVE-2018-1097: Bump fog-ovirt for power action fix

Fixes #19857 - Fix Style/EachWithObject cop

Fixes #2828 - Report an error when trying to save ovirt resource

On both create and update, there was no exception handler to captured
given exception. That resulted in having an exception screen instead of
an error message.
The fix capture all of the given exceptions, and report them as an...

fixes #22902 - change suggested memory to 2GB

Fixes #22282 - Test oVirt connection before save

Fixes #10273 - Clone disk from template when preallocate marked

fixes #22454 - vmware: validate user data for customspec

Fixes #19889 - Fix Style/PerlBackrefs cop

Fixes #22329 - Fix Style/RandomWithOffset cop

Fixes #20807 - Remove deprecations for 1.18

fixes #5125 - list available vmware images

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

fixes #22062 - support vmware vmrc console

Fixes #22079 - Fix Lint/UriRegexp cop

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #20528 - Remove direct connection to rbovirt client

fixes #5441 - Add instance_type support to oVirt provider

Fixes #21718 - Show errors properly when creating new oVirt CR

We try to retrieve available operating systems in an after_validation
hook. Trying to retrieve them makes no sense if the URL isn't
considered valid by us.

Fixes #21675 - OpenStack create host tab fails to load

Currently the tab is not loading as there are a few methods that are not
being overridden properly by the FogExtension.

After fixing that and adding the metadata key the tab loads

Fixes #12054 - Openstack v3 support

Fixes #12216 - support http proxies for compute resources

fixes #20878 - vmware clone: rewrite boot order

Fixes #20952 - Replace AC::Parameters Hash methods

Replaces any methods that used to be from Hash with the more limited
ActionController::Parameters API.

Fixes #19326 - create compute-resource - URL optional

Fixes #20452 - Keep password value after validation in ovirt CR

Fixes #20373 - Add ESXi 6.5 to VMWare

fixes #4509 - VMWare: multiple scsi controllers

Fixes #20174 - handle no storage pool gracefully

fixes #19604 - vmware vSphere 6.5 GuestOsIdentifier

Fixes #19762 - upgrade to rubocop 0.49.1

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19459 - improve vm boot failure feedback

To be able to override the wait for vm ready we need to move
it to compute resource definition. Also improve Openstack one

Fixes #19377 - available_flavors for OpenStack

fixes GET /api/v2/compute_resources/:id/available_flavors resulting in
"Not implemented for OpenStack".

Fixes #19236 - handle situation when host is destroyed oVirt

The issue was introduced in 4269abbd, where we replaced the
`OVIRT::OvirtException` error by `ActiveRecord::RecordNotFound` in
`find_vm_by_uuid method`, but we haven't updated the corresponding...

Fixes #12272 - Support multiple certificates in ovirt resource

fixes #18064 - import host from compute resource

fixes #18815 - VMware vSphere Disk Mode support

fixes #18373 - vmware: do not pass automatic firmware to vm

Fixes #14716 - Added option to transform thin template to thick

Unfortunately, it's a single setting for all disks - you can't choose
which disks (inherited from templat) will be thin and which not.

For new disks, the logic remains the same - "thin" flag would be used.

fixes #18366 - vmware: delete vm only if created with errors

fixes #18216 - volume size editable for existing VMs one

fixes #13618 - cache expensive vmware api calls

Fixes #10539 - Add default names for ifaces for oVirt CR VMs

fixes #4166 - vmware: update cpus, memory for vms

Fixes #17015 - Adds Key pairs controller

Fixes #17641 - Use force when destroying VMs

There's no point in waiting several seconds for any guest utils to
shut down the VM when we want to get rid of it as quickly as
possible.

This also works around cases like where VMWare misdetects
the openvm-tools status.

Fixes #5483,#11106 - pass the virtualswitch value to fog

We can't pass the network id directly to the fog, but it accepts the
virtualswitch parameter, that we can use to point to the right value.

Also, it fixes another issue, where we used the vsphere network id to...

fixes #15610 - choose firmware for vsphere vms

Fixes #17535 - Associate host with multiple NICs to VMWare VM

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

Fixes #16619 - Set EC2 VPC instance private IP from primary NIC

fixes #17340 - assign IPv6 address to Rackspace CR hosts

fixes #16091 - Fixed association Foreman host with Compute VM

Fixes #2314 - fine grain for RAM selectors

Fixes #13047, #16291 - Upgrade datatables and move it to npm

Fixes #16144 - vmWare datacenter error in connection test

Fixes #15924 - Implement server groups and scheduler hints

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

Refs #3809 - Turning on the AndOr cop

fixes #15625 - vmware: add cdrom only when selected

Fixes #8289 - handle user data in ovirt

Fixes #15345 - allow changing oVirt CA certificate

Fixes #15372 - Merge the correct hash when adding new volumes

Use 'attr' passed into the method and not the attrs hash on the cr.

Fixes #15344 - recover from fingerprint error on validation

Fixes #15066 - operating systems and ovirt < 3.6

The operating systems endpoint was added in ovirt 3.6
https://bugzilla.redhat.com/show_bug.cgi?id=1050243. Older versions
were failing getting 404 when provisioning.

This patch adds a check for this case. We also cache the operating...

Fixes #15163 - use new oVirt CA cert endpoint

Fixes #15154 - Added more safety measures to libvirt

fixes #3910 - add cdrom drive support for vmware

Refs #3809 - Turning on some rubocop cops

fixes #14874 - do not run path replace during vmware clone

Fixes #10278 - don't replace . with - for oVirt VM anymore

The version that supports . in VM names (v3.1.0-18) has been around
for almost 4 years
now (https://github.com/oVirt/ovirt-engine/commit/540a75e0f7bc4b9ed879471d3d830d575c6d6060).

Time to move one and make the VM names in oVirt a bit nicer now.

Fixes #6959 - set operating system for RHEV/ovirt VMs

Backward compatible, but works best with https://github.com/abenari/rbovirt/pull/104

Fixes #10978 - fix possibility to assign networks in compute profile for ovirt

fixes #14415 - check CR availability with Fog, not SETTINGS

Simplifies the code for checking compute resource availability, which
can easily be determined with the registered Fog providers instead of
being stored in SETTINGS in app initialisation. Plugins should always be...

Fixes #14330 - Provide option in hammer to change display type for
libvirt compute resource

Fixes #14038 - pass corespersocket in VMWare image-based provisioning

fixes #14344 - add region to permitted Rackspace CR attributes

Fixes #13091 - Paginate VMs for supporting compute resources

Loading all VMs for the compute resource view can be a very heavy task,
which leads to timeouts when attempting to load all VMs for a compute
resource that has many hundreds or thousands of VMs. This patch allows...