Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

fixes #23909 - vsphere: prefer network search by key

Creating a new VMware image fails during provisioning with
"Could not match network interface". Searching for distributed
virtual switch via key BEFORE searching with the nic_attrs structure
resolves a false positive match when vCenter contains VDS migrated...

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23859 - Fix vm_exists? method

Fix related tests

Fixes #23859 - Queue orchestration compute

Fixes #23813 - Allow searching audits by type=auth_source

fixes #23686 - filter audits by settings type

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

fixes #21657 - remove facets when host is removed

Fixes #23195 - Audit associations on creation and destruction (#5455)

Also includes a bit of refactoring to the AuditAssociations module.

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19840 - Fix Rails/ReadWriteAttribute cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23098 - Allow searching on all audited models by type (#5395)

This automatically adds all the audited models in an after_initilize
block so that models defined in plugins are also included. All the
search related definitions for audit have been extracted to a seperate...

Fixes #6752 - log audit events (#5391)

Refs #22096 - Assign taxonomy to taxonomy audits (#5387)

Fixes #19857 - Fix Style/EachWithObject cop

Fixes #22918 - Audit all taxonomies assignments

We need to move all audited definitions to top of models because all
concerns can use audit_associations call which relies on audit being
already activated.

Fixes #22927 - method in audit_associations to get class

With this commit, we can override association_class method
in other plugins like Katello.

Fixes #22892 - allow extending audited associations

Fixes #22096 - Make Audits taxable (#5269)

Fixes #18854 - Search by usergroup on hosts (#5317)

Fixes #21120 - orchestration tasks are added only once (#5079)

Fixes #22493 - structured logging support

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #22199 - Audit has_many associations (#5187)

Fixes #22104 - adapt to Rails 5.1 change tracking

Fixes #22616 - Allow searching hosts by status as integer

Fixes #17083 - log skipped orchestration steps

Fixes #22556 - Correct host search for parent hostgroup

Currently, searching on a non-existant parent fails due to
`hostgroup.subtree_ids` throwing a NoMethodError when no matching
hostgroup is found. This is rescued by scoped search, causing the
search to run with no conditions instead....

Fixes #21465 - load owners from any context

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Fixes #22208, #21920 - Refactor password auditing (#5162)

Recent changes in Rails 5.1 and audited gem cause our method of auditing
passwords to break. This PR refactors password auditing, so that instead
of recording a change to attribute `password_changed`, we will now...

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #5790 - Add compute resource to hostgroup (#4593)

Fixes #22078 - Fix Rails/EnvironmentComparison cop

Fixes #19833 - Fix Rails/FindEach cop

Fixes #21851 - Remove deprecations for 1.17

Fixes #21120 - DHCP update no longer queued twice

Fixes #20667 - Reduce implicit searching on host index (#4768)

Fixes #21343 - support multiple orgs supported for non-admin users

• Fixes #21343 - support multiple orgs supported for non-admins

This adds a full support for taxonomies in API for non-admin users. It
fixes the issue with dirty associations module that only track _ids...

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #21675 - OpenStack create host tab fails to load

Currently the tab is not loading as there are a few methods that are not
being overridden properly by the FogExtension.

After fixing that and adding the metadata key the tab loads

fixes #21374 - audit host interfaces (#4929)

Fixes #21611 - Improve *_name lookup speed

Fixes #16835 - Allow implicit search with org_id

Previously, any resource with many taxonomies would fail when using
implicit search when passing organization_id parameter to the api. This
is due to scoped_search incorrectly adding the taxonomy table to search...

fixes #21394 - user login with access token api

Refs #21037 - address review comments

Fixes #21037 - use Host::Base as auditable_type

Otherwise, we are hitting "Invalid single-table inheritance type:
Host::Discovered is not a subclass of Host::Managed" when converting the
host from discovered to managed.

Fixes #15409 - Separated puppet facts from core

Fixes #20957 - Replace alias_method_chain with Module prepend

Deprecated in Rails 5.0 and will be removed in 5.1. Some instances of
classes overwriting existing methods can be handled with `super`, other
concerns or modules are changed to use prepend instead of include....

Fixes #20952 - Replace AC::Parameters Hash methods

Replaces any methods that used to be from Hash with the more limited
ActionController::Parameters API.

Fixes #20201 - Global HTTP proxy for outgoing requests

This introduce two new settings to proxy outgoing HTTP
requests and one to except certain hosts from it.

The extensions for Excon::Connection and Net::HTTP
allow setting a proxy on their requests.

Fixes #20949 - Replace deprecated AM::Errors usage

Fixes #20950 - Use 'distinct' in AR finders

Fixes #20708 - fix templates auditing

Templates were audited under parent class. This keeps separate audits
per template type and allows searching by provisioning_template and
partition_table names. It also fixes broken associations in
taxable_taxonomies table.

Fixes #19113 - use fog-ovirt method for rebooting

While fixing the waiting for stopped vm in reboot there.

Fixes #20248, #20327 - Respect context in CSV export

Since CSV export is done using an enumerator which is executed by a
different thread to the one that creates it, we need to manually pass in
the context (user, location, organization) to the enumerator.

Fixes #20384 - seed resources before admin exists

For seed scripts that executes before internal admin exist we need to
ignore creation permission check on resources that includes Authorizable
concern.

refs #19623 - fix if key method is not present for network

credit to jsherrill for the one line solution :)

Fixes #16884 - enforce granular filters even during save

Fixes #19677 - Add settings for local boot templates

Fixes #17360 - Prevent % string interpolation in scoped_search

Fixes #17918,#19354 - Smart class parameters appear in audits

Fixes #19828 - Fix Rails/Blank cop

I disabled the default UnlessPresent value since sometimes it's clearer
to use `unless attribute.present?` instead of `if attribute.blank?`.

Fixes #20165 - improve org/loc error messages

Fixes #19623 - add comparison to portkey for vmware networks

Fixes #20066 - added safe renderer to global params

fixes #19913 - fixes rubocop Style/ZeroLengthPredicate

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #19631 - ComputeResource with KeyPair can be removed

The concern for removing the compute resources with keypairs was trying
to destroy the compute resource too early. Also, this deletion already
happened because of the has_one :dependency => :destroy relation...

Fixes #15861 - increase size of audited_changes column

In mysql text type is limited to 64K, while in psql
there's no limit. Changeing type to MEDIUMTEXT,
which limited to 16MB, should solve this issue in mysql

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19612 - CVE-2017-7505 don't expose admin to taxed users

Fixes #19632 - changed shim and grub1 PXE names

Fixes #19459 - improve vm boot failure feedback

To be able to override the wait for vm ready we need to move
it to compute resource definition. Also improve Openstack one

refs #19534 - check EncryptValue class variables are defined

bed4594 added class variables to record logging state, but failed to
check it was defined before accessing them, causing exceptions when
decryption failed. Tests added for this new behaviour.

Fixes #19534 - removed excessive encryptor logging

Fixes #19534 - improved orchestration task logging

Fixes #19506 - reset cache after CR update

Fixes #19173 - build notification succeeds with expired token.

fixes #19419 - fix invalid syntax in aws fog extention

Fix invalid syntax in server.rb

Fixes #19374 - added check to fix double facet registration

fixes #19328 - autosign tasks have correct wording

fixes #18445 - always define eager_load_paths, use require_dep

Allows `eager_load!` to be called or enabled in any environment without
loading files under lib/ twice. Switches many `require` calls to Rails'
`require_dependency` to always use its dependency loader, so when eager...

fixes #19087 - create host built notification from Host#built

Comparing the host's installed_at timestamp is unreliable on MySQL
databases, as the timestamp field has a limited granularity. Under Rails
5 in a sub-second test, this field will not be changed....

fixes #19035 - rewrite TopbarSweeper without rails-observers

Moves from the observer object into two mixins, one on the model and one
on the top-level controllers to observe creates/updates/destroys on
monitored models. Replaces rails-observers as it lacks Rails 5 support.

Fixes #15374 - move progress_report_id to Host::Base

fixes #18064 - import host from compute resource

Fixes #18949 - info message about current user

Fixes #18952 - fix destroy of host without owner

The notifications failure caused the host not being deleted.
I don't think the notifications should interfere with the core
functionality of the objects.