Project

General

Profile

Statistics
| Branch: | Tag: | Revision:

# Date Author Comment
dd5091f4 03/11/2024 03:16 PM Adam Ruzicka

Refs #37224 - Force all Hosts to have a comment

The previous implementation of the update had two issues:
1) It only operated on ::Host::Managed
2) It silently failed if the host was invalid for any other reason

Fixes 4c7f36edf

4c7f36ed 03/06/2024 01:15 PM Adam Ruzicka

Fixes #37224 - Force Hosts to have a comment

To prevent the nil > empty string transition we would either have to:
check the incoming changes and discard the unwanted ones
- ignore these transitions when creating audits
- just force hosts to always have a comment...

a9b9b7d9 03/05/2024 06:25 PM Samir Jha

Fixes #37167 - Subscription entitlement report template

2198394b 01/03/2024 12:26 PM Oleh Fedorenko

Refs #36849 - Fix Ruby 3 kwargs handling

1c1d5e25 10/24/2023 06:59 PM Ian Ballou Fixes #36826 - Add Host - Installed Products report
  • Add system purpose role and usage to subscriptions entitlement report
a406cf2b 10/09/2023 09:42 AM Matěj Mudra

fixes #36160 - Redefine append domain names setting

This PR aims to unify the format of host names stored in the database and the way they are displayed.
With this change, the name of the host is always going to be stored with the domain name appended.
The setting formerly named `append_domain_name_for_hosts` is now renamed to `display_fqdn_for_hosts`...

4e205ba1 10/04/2023 07:06 AM Ewoud Kohl van Wijngaarden

Fixes #36723 - Remove Fedora/Red Hat Atomic related code

As far as I can see this has been EOL for a few years now. Red Hat
Atomic went EOL in 2021.

d430f3fb 09/28/2023 10:19 AM Evgeni Golov

Fixes #36759 - only call allowed transpilers

CVE-2022-3874: OS command injection via ct_command and fcct_command

Instead of allowing to call any command by changing a setting, only
allow specific paths to ct/fcct. If the user needs a different path,
they can set it via settings.yaml.

48173f49 08/29/2023 01:56 PM Nofar Alfassi

Fixes #36663 - Add permission to modify LookupValue resource

This is necessary when using gql to allow non-admin users
to modify lookup-key values.

31b23dd7 08/10/2023 11:35 AM Ewoud Kohl van Wijngaarden

Fixes #36659 - Drop CentOS 8 mirror

The CentOS 8 mirror is for CentOS Linux 8, but that's EOL and removed
from the mirrors.

75d8ea31 08/07/2023 02:07 PM Ian Ballou Fixes #36587 - rename Host - Applicable Errata report
  • ...and fix comment typos
29e1c27b 06/08/2023 11:48 AM Mike Rochefort

Fixes #36189 - Add AlmaLinux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/almalinux/grubx64.efi path is missing. This causes the server
to refuse to boot.

To make it easier to use the AlmaLinux installation medium is added.

02dd9831 06/01/2023 07:40 AM Shimon Shtein

Fixes #36395 - move value setting to seed

c791f6c7 01/16/2023 12:01 PM Ondřej Ezr

Fixes #29939 - drop category column from settings

Settings table was holding category column to support old style of
settings, but it is now ready to be decomissioned as plugins were given
enough time.

7f924234 01/10/2023 10:41 AM Adam Ruzicka

Fixes #35866 - Make RSS notification expire after 1 month

c3afd8f0 11/23/2022 01:14 PM Nofar Alfassi

Fixes #35642 - update the message in the new UI to display the host's creator

Add `creator_id` property to the Host model to save the user who created each host.
This property is used in the new host details UI to display the user who created the host.

d559505b 11/03/2022 10:48 AM Maria Agaphontzev

Fixes #35696 - add bios info to reported data facet

3146fd86 11/02/2022 12:38 PM Oleh Fedorenko

Fixes #35621 - Make power status a selectable column

96e99cd0 10/19/2022 01:13 PM Leos Stejskal

Fixes #35528 - Remove i386 from host architectures (#9424)

950040e4 10/14/2022 08:55 AM Chris Roberts

Fixes #35619 - Add kernel_version to reported data facet for new host UI

34709a37 09/21/2022 06:35 PM Ian Ballou

Fixes #35347 - purge old trends and foreman_docker references during upgrade (#9343)

ee9fe3a7 08/16/2022 07:08 PM Partha Aji

Fixes #35359 - Add cacert to http proxy (#9348)

This PR adds a cacert column to the http proxy and uses to this for
connecting to ec2 and other compute resources. This would also be used
by katello/other plugins when communicating to the CDN over a https...

94f42e32 08/10/2022 11:35 AM Matěj Mudra

Fixes #35151 - Add CentOS Stream 9 installation medium (#9346)

f28bc34c 08/02/2022 07:41 AM Shimon Shtein

Fixes #35132 - Make audits host detection regex more strict

db023da3 07/25/2022 11:47 AM Nofar Alfassi

Fixes #4007 - updating users email to be optional (#9279)

38d2bf3c 07/12/2022 02:12 PM Ewoud Kohl van Wijngaarden

Fixes #35182 - Add Rocky Linux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/rocky/grubx64.efi path is missing. This causes the server to refuse
to boot.

To make it easier to use the Rocky Linux installation medium is added.

d8be09ae 06/09/2022 12:00 PM Nofar Alfassi

Fixes #34948 - drop missing owner notification

de56ffb2 05/26/2022 10:58 AM Ondřej Ezr

Fixes #34305 - stop creating settings in DB (#9050)

With the setting DSL, we hold all the necessary values for settings in the memory.
We can now stop creating records for the settings in the database.

c2121663 05/19/2022 09:48 AM nofar

Refs #33672 - remove unnecessary timestamps from taxable_taxonomies table

edbd77ed 05/19/2022 07:41 AM Marek Hulán

Fixes #34396 - job report tweaks

This change adds few enhancements to the existing Job report. The report
is used with REX plugin, which has a button "Create Report" in job
detail page. Clicking that button takes user to the render report form
and fills in the job id input....

c367ccbc 05/18/2022 11:37 AM Nofar Alfassi

Fixes #33672 - drop unnecessary timestamps

73101ef9 03/22/2022 02:37 PM Leos Stejskal

Fixes #34661 - Registration migration with nil template

Fix for the issue in registration migration,
when template might not exist while migrating the db.

See https://github.com/theforeman/foreman/pull/8256#discussion_r824099694

bd88345f 03/04/2022 11:47 AM Leos Stejskal

Fixes #34513 - Undefined method 'format_errors' when db:seed fail

32250058 02/10/2022 02:33 PM Lukas Zapletal

Fixes #34409 - rename existing CentOS OSes to CentOS_Stream

Signed-off-by: Lukas Zapletal <>

a459f514 01/31/2022 01:10 PM Adam Ruzicka

Fixes #34351 - Allow Site manager role to be extended from plugins

9690f3ae 01/12/2022 11:30 AM Ewoud Kohl van Wijngaarden

Fixes #34236 - Drop require_ssl_smart_proxies setting

This defaults to true and setting it to false can create security
problems. Mandating client SSL certificates creates a more secure
environment.

Previously when require_ssl_smart_proxies was false, reverse DNS was...

4d294c5e 11/15/2021 01:00 PM Tomer Brisker

Refs #33909 - Reset User column information

While migrations shouldn't rely on any users existing in the DB, there
are some that currently do. If they try to use User.find_by_lower_login
they will currently error out since the method won't be defined yet.

46782f7f 11/15/2021 01:00 PM Tomer Brisker

Refs #33909 - Squash imap column conversion

490efe47 11/15/2021 01:00 PM Tomer Brisker

Refs #33909 - Remove useless User lookup

There is no need to lookup the admin user and use it to update the
http proxy fields.

05d7ec8c 11/15/2021 01:00 PM Tomer Brisker

Refs #33909 - Delete empty migrations

New installs will not run these empty migrations, and old installs will
only list that they have been executed when checking the `rake
db:migrate:status` with no file, which is harmless.

98514209 11/15/2021 01:00 PM Tomer Brisker

Fixes #33909 - Drop data migrations before Foreman 2.0

All data migrations only modify data on upgrades. On new installs they
are not required. Since we do not generally support upgrading multiple
releases, we can clean up old data migrations. This commit cleans up all...

46e6b1ef 11/15/2021 11:20 AM Tomer Brisker

Fixes #33906 - Drop fix_db_cache setting

This setting was introduced when the current permissions model was
introduced in Foreman 1.7 to allow recreating the user permissions cache
after the migration from the previous model. The setting has no other
uses....

fb46aca1 10/26/2021 10:38 AM Ondřej Ezr

Fixes #33607 - use setting DSL for Puppet category

dd900898 10/26/2021 10:38 AM Ondřej Ezr

Fixes #33601 - use setting DSL for Provisioning category

af897df3 10/26/2021 10:38 AM Ondřej Ezr

Fixes #33596 - use setting DSL for Notification category

ac91f07f 10/26/2021 10:38 AM Ondřej Ezr

Fixes #33595 - use setting DSL for Email category

233068a8 10/26/2021 10:38 AM Ondřej Ezr

Fixes #33589 - use setting DSL for Authentication category

7f01e1b3 10/21/2021 12:20 PM Adam Ruzicka

Fixes #32328 - Infrastructure roles

Introduces things needed to assign infrastructure roles to hosts.

A host can now have an infrastructure facet, which can be used to mark a
host as foreman instance by setting a flag on the facet. The facet can
also be used to establish a relationship between the host and a smart...

5e14256e 10/17/2021 09:13 AM Tomer Brisker

Refs #31060 - Move environment cleanup to rake task

8c3d16e0 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31060 - drop Environments migrations

Drops all migrations related to environments.
Removes all the relations to the environments.
Adds a migration to drop environments from Hostgroup and Host.

Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/41.

a18a518d 10/14/2021 01:00 PM Ondřej Ezr

Fixes #33541 - drop puppetclass migrations

Removes all migrations related to Puppetclass.

Added in plugin https://github.com/theforeman/foreman_puppet/pull/195

17d3fe68 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31096 - remove config group migrations

These migrations had been added to the plugin foreman_puppet_enc.
Details of addition https://github.com/theforeman/foreman_puppet_enc/pull/13

c41f1124 10/14/2021 01:00 PM Ondřej Ezr

Fixes #31732 - drop env from TemplateCombination migration

Drop environment relation from TemplateCombination migrations.

608e32be 09/24/2021 11:25 AM Ondřej Ezr

Fixes #32893 - use setting DSL for General category

This uses our new DSL to define the General settings, this showcases how
to use the new DSL and other categories should follow in the same
release.

813b605d 09/15/2021 07:58 AM Tomer Brisker

Fixes #33387 - Remove view_tasks permission

This permission was present since the permission model was implemented
in acfbc45886c4 but wasn't really used anywhere. Foreman tasks uses a
different `view_foreman_tasks` permission.

6363d0f3 07/19/2021 10:39 AM Ondřej Ezr

Refs #31059 - drop environments Host extensions

Removes uses of environment from Host

065582ae 07/19/2021 10:39 AM Shira Maximov

Fixes #31095 - Remove config groups model

Added to the plugin in https://github.com/theforeman/foreman_puppet_enc/pull/12

92eb6cee 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31235 - drop Puppetclass models

Drops Puppetclass models and their usage.
Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/81
Tests extracted in:
- hostgroup - https://github.com/theforeman/foreman_puppet_enc/pull/85

a69a9d4c 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31129 - drop Host classes API

Extracted in: https://github.com/theforeman/foreman_puppet_enc/pull/103

50c7469f 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31732 - drop environment in TemplateCombination model

Extract Environment from TemplateCombination matrix as temporary solutin.
This should probably get dropped if favor of some better solution like direct set on hostgroup.

Though this will need to be reflected in foreman_puppet_enc plugin....

340fefd5 07/19/2021 10:39 AM Ondřej Ezr

Fixes #30170 - drop smart class param permissions

Extraction details in https://github.com/theforeman/foreman_puppet_enc/pull/27
Forgotten Site Manager permissions in https://github.com/theforeman/foreman_puppet_enc/pull/95

c05b3687 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31014 - Drop PuppetLookupKey model

Drops unused model PuppetLookupKey.
Extracted in
- theforeman/foreman_puppet_enc#5
- https://github.com/theforeman/foreman_puppet_enc/pull/42 (test)

f9c84758 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31061 - drop Environment permissions

Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/47
Adding to default role in: https://github.com/theforeman/foreman_puppet_enc/pull/77

9919a2d3 07/19/2021 10:39 AM Shira Maximov

Fixes #31106 - drop config groups permissions

ba5d9e22 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31131 - drop Puppetclass permissions

Drop permissions to access Puppetclass resources.
Drop permissions to access information about puppetclasses on Host/Hostgroup.

Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/53
Permissions added to default role in https://github.com/theforeman/foreman_puppet_enc/pull/77.

85df2015 07/19/2021 10:39 AM Ondřej Ezr

Fixes #31056 - drop SmartProxy Puppet feature

Drops testing with puppet feature, Puppet Proxy status.
Puppet proxy multiple update on host.

Extracted in: https://github.com/theforeman/foreman_puppet_enc/pull/70

9499e273 07/14/2021 04:09 PM Leos Stejskal

Fixes #32959 - Unassign OS in registration migration

Operating systems cannot be assigned to registration templates,
so the migration file should also remove these associations.

c83d799e 06/22/2021 11:15 AM Lukas Zapletal

Fixes #32753 - Remote code execution through Sendmail

CVE-2021-3584: Sendmail location and arguments, available via Administer
- Settings, both accept arbitrary strings and pass them into shell.
By default, only Foreman super administrator can access settings....

2a0ad914 06/18/2021 12:31 PM Ondřej Ezr

Fixes #30394 - allow non-admins deal with untaxed filters

Prior this non-admin user would have to have assigned Role without
taxonomies (global role) to be able to manipulate filters.
This allows manipulating Filters to any User with Filter perms.

Filters with taxonomies mean they apply to taxonomy. But given they have...

81512f75 06/16/2021 08:16 AM Tomer Brisker

Fixes #30387 - Remove `view_bookmarks` permission

Users should always be able to see public bookmarks and their own
bookmarks, a permission is not needed for this case.

dcf11351 06/11/2021 02:55 PM Dominik Matoulek

Fixes #32166 - Merging Ignored Interfaces to Excluded Facts (#8560)

Improve the description of the settings to make it clear which should be applied to what use case.

122975dd 06/02/2021 09:27 AM Ondřej Ezr

Fixes #32673 - deduplicate records prior uniq index

In 84cb565af244f56029471700bb313d46c45e5fcf we've introduced unique
index in database, because there is a way in Rails to bypass uniqueness
validation, if the records are being introduced at the same time....

c2e5e4a3 05/27/2021 12:30 PM Dominik Matoulek

Fixes #32141 - Adding notif. about finish of rendering report (#8537)

Everyone uses a report templates for render important stuff from foreman
instance. Right know, the templates can take long time to render it and
when you don't want to send a report by email, you have to have open...

5c92f976 05/27/2021 09:38 AM Tomer Brisker

Fixes #32657 - Prevent duplicate templates

In certain race conditions when two seeds are executed at the same time,
some templates may be seeded twice. Since there is a unique name
validation in AR on templates, this renders such templates uneditable,
and in case they need updating during seeding, it also prevents the seed...

055489b7 05/20/2021 06:29 PM Lukas Zapletal

Fixes #27604 - added Fedora|Redhat CoreOS and IM

e49da576 05/13/2021 02:02 PM Romuald Conty

Fixes #31132 - Downcase MAC addresses

8137b14c 04/22/2021 03:12 PM Ondřej Ezr

Fixes #30862 - introduce SettingRegistry (#8002)

SettingRegistry keeps all the setting information as set of SettingPresenters in memory.
This registry should be the public API for accessing setting values and keeps all the information about settings.
That will allow dropping all information except `name` and `value` from database....

bf56104d 04/19/2021 02:18 PM Leos Stejskal

Fixes #31743 - Template macro install_packages (#8298)

For package installation on supported OS families: Red Hat, Debian & Suse.
In host registration users can now install packages
by setting the `host_packages` parameter.

Also if a snippet `host_init_config_post` is defined, it gets added to the registration script.

9d93ecea 04/08/2021 09:17 AM Dominik Matoulek

Fixes #32170 - Adding total_disk_size to host facets

This PR introduced new parameter to hosts facets. Parameter is a total
disk size that is included in Discovery plugin at own. However that
means that we have to maintain a two "facets like" codes at one time...

f5bfce8b 04/06/2021 01:57 PM Tomer Brisker

Fixes #32242 - Drop db_pending_migration setting

This setting was used in the past by the installer to determine whether
or not the database needs to be migrated, but that is no longer the
case.

8609ef84 03/18/2021 01:21 PM Ewoud Kohl van Wijngaarden

Fixes #30779 - Implement ActionDispatch::RemoteIp (#7960)

The ActionDispatch::RemoteIp middleware can provide the remote IP
correctly as a property of the request object. This looks at
X-Forwarded-For headers while stripping out reverse proxies and falls...

26a20e66 03/12/2021 04:40 PM Leos Stejskal

Fixes #31663 - Registration templates usability issues (#8256)

- New template kind 'Host initial configuration' for
host configuration after the registration.
- Registration templates (like 'Global Registration')
cannot be assigned to operating system...

6a06b63c 01/20/2021 11:24 AM Lukas Zapletal

Fixes #31571 - CentOS Stream installation media

d60d1cb1 01/15/2021 05:40 PM Marek Hulán

Fixes #31637 - nilify http proxy credentials

Recently a HTTP form password field changed and is disabled unless user
explicitly sets the password. From the HTML forms nature, if user does
not specify any value in the text field, server receives the value as an...

d7cf0967 12/24/2020 01:54 PM Shira Maximov

Fixes #31551 - remove ovirt_use_v4 from oVirt CR attributes

ef4f8259 12/04/2020 01:10 PM Lukas Zapletal

Fixes #31147 - extend StatusCalculator to use 64 bits

e801f761 11/06/2020 11:55 AM Tomer Brisker

Fixes #31258 - Don't fail migration if setting is hardcoded

If the puppetrun setting has been hardcoded in settings.yaml, it will be
marked as readonly causing the migration attempting to delete it to
fail. Since settings have no associations and we don't need callbacks to...

146c1a76 11/01/2020 12:32 PM Leos Stejskal

Fixes #31020 - Global Registration & REX setup parameter (#8104)

New Host parameter 'host_registration_remote_execution',
seeded with default value set to 'true'.
New parameter :setup_remote_execution for Global registration endpoint,
allowing users to enable/disable REX setup when registering host.

2f42ffc3 10/26/2020 11:02 AM Lukas Zapletal

Fixes #30820 - drop digest and use hash index instead

05e0aaf0 10/19/2020 12:23 PM Hesham Ahmed

Fixes #30535 - Use HTTP headers in puma

31b0d198 10/12/2020 03:45 PM Leos Stejskal

Fixes #30917 - Add Smart proxy feature 'Registration' (#8024)

cd4b1820 10/07/2020 08:33 PM Tomer Brisker

Fixes #29710 - Clean up .where conditions

Using methods such as `none`, `not`, `or`, or `all`, we can simplify
some `.where` calls in ways that weren't possible in some very old rails
versions.

2110556a 10/05/2020 06:20 PM Leos Stejskal

Fixes #30771 - Complete global registration flow (#8018)

The registration workflow implemented by a pair of new API endpoints.
The first endpoint allows user to get the Global Registration Template (GRT),
which contains generic instructions for any new machine. User must specify...

982d7a82 09/15/2020 02:56 PM Ondřej Ezr

Fixes #30847 - rebuild taxonomy_search (#7995)

As of 72209166fa58d3c5bc2b3629d98696edf7bd7250 there is more effective way to build a taxonomy_scope.
For all filters to benefit from that, we need to save the existing ones.

2a92b54c 08/25/2020 02:49 PM Shira Maximov

Fixes #30556 - Get an accurate err for invalid hosts in report (#7897)

27c0232d 08/03/2020 11:27 AM Ondřej Ezr

Fixes #30159 - drop Statistics backend

2f2e9266 07/18/2020 09:06 PM Dominik Matoulek

Fixes #29993 - Drop Puppetrun

b81286b3 07/17/2020 07:16 PM Lukas Zapletal

Fixes #28357 - BMC Subnet-Proxy association

75d69c35 07/12/2020 12:17 PM Ondřej Ezr

Fixes #30098 - Drop trends permissions

7895751c 07/12/2020 11:10 AM Ondřej Ezr

Refs #30098 - Drop trends models