Fixes #23962 - Fix Style/ExpandPathArguments cop

Refs #20891 - fix for new rubocop rules

Refs #23825 - Improve the rake task for tarballs

This introduces the name variable so that's the single line where it
differs from the smart-proxy task.

It also adds a check on the git archive tasks exit status.

Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #23825 - Add exporting to Rakefile.dist

The benefit is that you no longer need the full bundle stack installed.
We also output the generated filename for use in scripts.

Fixes #23952 - Include all asset paths when precompiling plugins (#5699)

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #22058 - refresh rubocop config and apply autofixes

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23843 - Exclude requests to local host from proxying

Fixes #23842 - Load factory_bot only when needed

By moving the factory_bot loading to when it's only needed we make it a
soft dependency. Production installs typically don't have factory_bot
installed which breaks rake tasks.

Fixes #23764: Ensure proper plugin asset generation for SCSS

If image-url or asset-url are used in SCSS then they are not properly
generated for plugins. This change has the nice side effect of
both simplifying the code and re-using the existing Rails and Sprockets...

Fixes #19968: Add a rake task to seed your database

This uses FactoryBot to seed the database with trivial hosts.
It allows developers to easily set up a bunch of hosts to get some
realistic database size.

Fixes #23142,#23503 - telemetry improvements

Fixes #21997 - make http_proxy extension excon >0.59 compatible (#5526)

excon 0.60 defines it's own "logger", which conflicts here.

Fixes #23635 - Centralize use of facter

We have a bundler group for facter. That implies it's optional but
before this change it wasn't With this change it's only required if no
domain and fqdn are set. This is still the default so in most cases it's
no difference, but at least we have centralized all use of facter to one...

Fixes #23577 - Configurable security token path

In production setups we prefer to store this file in /etc/foreman and a
symlink in the rails root.

Fixes #23646 - Remove storeconfig leftovers

In Foreman 1.1 sharing the database with Puppet's storeconfigs was
deprecated. We've given users sufficient time to migrate away from it
and possibly broke it along the way. I haven't checked.

fixes #23621 - passwords can be md5 hashed

Fixes #23587 - Verify webpack precompile is needed

Plugins like bastion do have a package.json but no webpack resources.

Fixes #15549 - Correct documentation for exports rake task

fixes #23387 - FOREMAN_RSS_LATEST_POSTS option now works

the rake task rss:create_notifications failed to
parse FOREMAN_RSS_LATEST_POSTS value correctly.

Fixes #23414 - Allow plugins to compile in production

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Refs #23147 - Fix style offences

Fixes #23295 - Robottelo tests reporting (#5464)

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #23147 - Allow plugins to compile production webpack assets

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23040 - Anonymize old audits (#5393)

Adds a rake task similar to audits:expire that instead of
deleting the entries anonymizes them.

Fixes #19848 - Set Style/Alias cop to prefer_alias_method

Fixes #23115 - session is used instead session_safe

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19839 - Fix Rails/Present cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #19909 - Fix Style/TrivialAccessors cop

Fixes #23077 - Fix Style/TrailingCommaInArrayLiteral cop

Fixes #23039 - Remove deleted LDAP users

Adds a rake task ldap:remove_deleted_users which checks all users
that authenticate via LDAP whether their users are valid and
deletes invalid ones.

Fixes #15634 - RancherOS support

New OS support.

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #19910 - Fix Style/UnlessElse cop

Fixes #19901 - Fix Style/SpecialGlobalVars cop

Fixes #22888 - remove code around dynflow db_pool_size

Remove the code in favor of the Dynfow, where we can handle all the
logic at one place.

Fixes #22764 - gc stat metric works on rails reload

Fixes #22158 - Add rake task to delete old audits (#5343)

Set the default period to 90 days or older.

Fixes #22493 - structured logging support

Refs #22310 - provide a script to set origin for existing reports

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

fixes #22575 - clean up test report

• Replace deprecated only_path with ignore_query

• Don't log to stdout for skipped tests

~_{* Don't override capture}~

~_{While this code might be helpful for debugging, leaving it in for}~
~_{every test run clutters up the test report.}~...

Fixes #22806 - rails now boot without telementry deps

Fixes #17316 - templates feature is subnet association

Refs #18675 - Optionally load prometheus exporter

In case the bundler group telemetry is not installed, we should handle
that.

This moves the middleware loading to better match the other middleware.

Fixes #18675 - telemetry foreman API

Fixes #21204 - introduced global_setting helper function (#4891)

Fixes #22613 - Drop Rails <5.1 ParseError

Refs #22354 - Don't instance_eval at every instance creation

Before this patch, we were defining the methods at every instance
creation. This means potential performance issues, as defining new
methods causes the method lookup cache to get dropped.

I needed to move the time for loading the silencer a bit later so that...

Fixes #19244 - added clean interfaces rake task

Fixes #22354 - Make SilencedLogger thread safe

Fixes #19801 - Enable Lint/AssignmentInCondition cop

Fixes #19889 - Fix Style/PerlBackrefs cop

fixes #22271 - rake console works with rails 5.1 (#5175)

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19881 - Fix Style/Not cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #19902 - Fix Style/StringLiteralsInInterpolation cop

Fixes #19849 - Configure Style/AndOr cop

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #20536 - sprockets3 syntax in plugin_assets.rake

sprockets 3 deprecates the use of environment.register_engine. We should
instead register a transformer as per the migration guide
(https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#registering-all-versions-of-sprockets-in-processors)

Fixes #19853 - Fix Style/ColonMethodCall cop

Fixes #19797 - fix Layout/SpaceInsideStringInterpolation cop

Fixes #19795 - Fix Layout/SpaceInsideParens cop

Fixes #19788 - fix Layout/SpaceAroundBlockParameters cop

Fixes #19769 - Fix Layout/CommentIndentation cop

Fixes #19780 - fix Layout/IndentationWidth cop

Fixes #21851 - Remove deprecations for 1.17

Fixes #22016 - update rubocop to 0.52

• Refs #22016 - make rubocop 0.51 pass

• Fixes #22016 - update rubocop to 0.52

Fixes #19820, #19822, #19824 - Fix some performance cops

Fixes #21991 - add Rails 5.1 ParseError exception

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #21103 - Replace 'false' AR callback results with throw

Fixes #18292 - Make notifications from an RSS feed (#4240)

This adds a task to connect to an RSS feed, by default the one from our
community blog. The idea is to make this run every night with 'cron' on
every Foreman installation to keep people updated about changes, and...

refs #21394 - user login with access token api

Fixes #21342 - fix core roles seeding

Core roles should always be up to date based on what's defined in seed
files. Users have no other way to update locked roles in newer Foreman
versions.

Fixes #18422 - Expose dynflow worker pool size in config

Fixes #21269 - fixed dns_lookup with address resolution

Fixes #19706 - don't treat DHCP leases as conflicts

Fixes #20559 - print rails log for test failures

Fixes #21010 - add higher granularity and reorder seeds

Fixes #20201 - Global HTTP proxy for outgoing requests

This introduce two new settings to proxy outgoing HTTP
requests and one to except certain hosts from it.

The extensions for Excon::Connection and Net::HTTP
allow setting a proxy on their requests.

Fixes #20950 - Use 'distinct' in AR finders

Fixes #20956 - Don't pass class constants to AR conditions

Fixes #20920 - Prevent boot issue with Rake.application

Refs #16740 - migration templates to use param macros

Fixes #13599 - Wrapped exception truncate moved to client

Removed message truncation from server side, and moved it to client
side - the message is truncated with ellipsis. On mouse over full
message is presented as popover.

This commit required a small change to `data-ajax-url` handler in client...

Fixes #20737 - add default description to roles