Fixes #36691 - use 'connectefi scsi' by default

Co-Authored-by: Shimon Shtein <sshtein@redhat.com>
Co-Authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Fixes #37367 - Switch to 'network' directive instead of ifcfg

Fixes #36525 - kickstart's RHSM line only works on RHEL hosts

Fixes #36885 - Add Clevis/Tang disk encryption template

For disk encryption Clevis/Tang is often used. This commit introduces
partition templates for Kickstart and Autoinstall taking care of disk
encryption and a snippet responsible for binding the LUKS device via...

Fixes #37337 - Fix snapshot task and add Rocky 8 & 9

Fixes #37065 - report_row now explicitly accepts kwargs
also adds a test which fails without the fix

Fixes #37011 - Apply latest Ubuntu Autoinstall userdata changes

• Add explicit fallback for offline installation
• Replace deprecated lock-passwd with lock_passwd
• Remove empty ssh keys array if none provided

Fixes #37184 - Report template generates incorrect kernel version

Refs #36502 - update snapshots after template change

Fixes #37019 - Correct release names in OS factories

Fixes #36723 - Remove Fedora/Red Hat Atomic related code

As far as I can see this has been EOL for a few years now. Red Hat
Atomic went EOL in 2021.

Fixes #36759 - only call allowed transpilers

CVE-2022-3874: OS command injection via ct_command and fcct_command

Instead of allowing to call any command by changing a setting, only
allow specific paths to ct/fcct. If the user needs a different path,
they can set it via settings.yaml.

Fixes #35124 - Fix preseed_kernel_options to work with full-host-bootdisk deployments

Update corresponding template snapshots.

Co-authored-by: Bastian Schmidt <schmidt@atix.de>

Refs #36677 - fix tests

Fixes #36639 - Use Templates feature on IPv6

This now looks at, and prefers, the IPv6 subnet on the
provision_interface to determine the template proxy. This allows using
the Templates feature in pure IPv6 provisioning setups.

Fixes #36490 - Remove redundant ERB closing tag in coreos template

Refs #36490 - Regenerate template snapshots

Fixes #36189 - Add AlmaLinux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/almalinux/grubx64.efi path is missing. This causes the server
to refuse to boot.

To make it easier to use the AlmaLinux installation medium is added.

Fixes #36180 - iPXE provisioning template for Ubuntu autoinstall

Fixes #36014 - Kickstart default - remove @core group

The Core group is always selected, it is not necessary to
specify it in the %packages section.

Fixes #35840 - Install chrony on RHEL 7

Fixes #35286 - New PXEGrub2 template for Ubuntu Autoinstall

- Introduce new PXEGrub2 Autoinstall template
- Move network configuration out of PXELinux Autoinstall template to
new preseed_kernel_options_autoinstall snippet
- Add snapshot for preseed_kernel_options_autoinstall...

Refs #35796 - Reduce empty lines

In 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c an additional empty line was
generated which broke the snapshots. This takes it a step further and
also removes various other lines in the generated output.

Fixes: 699b7a3b4e9069237031b2dfbee8dba2bbaadf8c

Fixes #35674 - Add more custom pre/post snippet hooks

Refs #35530 - Dont use shellescape on the filename

Fixes #35397 - Preseed Autoinstall incorporate host_params

• Param 'keyboard' to set default layout
• Param 'lang' to set default locale
• Adapt template snapshot accordingly

Co-authored-by: Bastian Schmidt <schmidt@atix.de>
Co-authored-by: Evgeni Golov <evgeni@golov.de>

Fixes #35583 - Skip dhclient installation

The dhclient package isn't available on the minimal ISO image for >= EL8, therefore installation fails because it tries to install this package. The IP address is managed by network manager.

Fixes #35536 - Template input_resource macro & preview error (#9428)

Fixes #35547 - Include REX pull in kickstart default (#9430)

• Fixes #35547 - Include REX pull in kickstart default

• Refs #35547 - Output the snippet verbatim

Refs #35530 - Alternative approach to save_to_file

save_to_macro generates a command using cat and a heredoc string.
However, if the content to be written contains a heredoc using the same
delimiter, save_to_macro's heredoc will be terminated by it, leading to...

Fixes #35530 - Make save_to_file macro safer (#9426)

• Fixes #35530 - Make save_to_file macro safer

save_to_file does

cat <<EOF >$file
$content
EOF

but if `$content` contains a heredoc terminated with `EOF`, it
terminates the heredoc that save_to_file creates....

Fixes #35331 - Use Anaconda rhsm in kickstart for RHEL 9

Fixes #35137 - Permit setting puppet tag during install

Fixes #35177 - Option to switch to graphical kickstart

Fixes #35166 - Enable static IP for Ubuntu Autoinstall

• Make IP method flexible and enable to switch between DHCP and static
• Make BOOTIF default for multi-network device setup
• Remove unused parameters from options

Co-authored-by: Bastian Schmidt <schmidt@atix.de>

Fixes #35306 - host_puppet_* template macros ignores host_param (#9334)

When host.puppet_server or host.puppet_ca_server returns
empty string we don't load the values from host parameters.

Fixes #34975 - Removed ks=. is supplied by kernel options snippet (#9238)

• Fixes #34975 - Removed ks= from template. It is supplied by kernel options snippet.

• Refs #34975 - Update snapshots

Co-authored-by: garret <garret@foreman8.rumohr.me>
Co-authored-by: Oleh Fedorenko <ofedoren@redhat.com>

Fixes #35182 - Add Rocky Linux UEFI provisioning support

In pxegrub2_chainload.erb various paths are tried, but the
/EFI/rocky/grubx64.efi path is missing. This causes the server to refuse
to boot.

To make it easier to use the Rocky Linux installation medium is added.

Fixes #34941 - Enable Ubuntu Autoinstall smart proxy deployment

• Use foreman_request_addr to reference correct Foreman/smart proxy port
• Use kernel and boot file variables from medium provider instead of static paths

Co-authored-by: Evgeni Golov <evgeni@golov.de>

Fixes #32612 - Add some extra metadata to the default kickstart

Fixes #32881 - Expose previous application record revision through safemode (#9258)

Fixes #34969 - Set up REX pull on client setup (#9235)

- Import katello-pull-transport-migrate
- Setup rex pull on registration
- Setup rex pull during provisioning
- Pass config params to slots/fills in registration form

Fixes #34700 - autoinstall template enable root user

The `identity` field doesn't allow to add/edit root as a user.
Therefore, the user-data field must be used. Compare the Ubuntu
Autoinstall documentation:
https://ubuntu.com/server/docs/install/autoinstall-reference#identity...

Fixes #34908 - Set hostname for Ubuntu Autoinstall

Fixes #34702 - use warning instead of halt for SCSI issues

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #34658 - Harmonize preseed templates

Refs #34558 - update snapshots

Fixes #33782 - do not use fixtures for Settings

As we no longer require settings in DB, we may drop the fixtures for settings.

Fixes #34525 - Call insights snippet by honoring host_registration_insights param during system build

Fixes #34339 - sanitize fqdn in tests

Tests were almost not using the fqdn defined in settings.yaml.test
That is quite confusing at first sight and we should not override this value by fixtures, only if overriden in the same test file.

Refs #34489 - update snapshot tests for Yast PXE

Fixes #34532 - disable EFI local chainloading by default

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #32632 - initial verison of Ubuntu autoinstall templates

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Refs #34323 - sanitize setting fixtures

Setting fixtures should not be used to override defaults for tests unless meant for every test.
If we mean to override the setting value for all tests, we should override value and not the default.

Fixes #31027 - transpiler macros for CoreOS family

Fixes #34213 - truthy? and falsy? template helpers

Template helpers for checking if a value is truthy or falsy

Fixes #34214 - use host_param_true? to detect puppet6-repo

Fixes #32919 - Add Salt Autosign grain to minion configuration

• Use host function .derive_salt_grains to get host_params['salt_grains'] and autosign key
• Makes foreman incompatible with previous foreman_salt versions

Co-authored-by: Evgeni Golov <evgeni@golov.de>

Fixes #33811 - Inheritance of root password for Hosts

Hostgroups are used for handle and easily modify passwords for Hosts. But prior this change we stored the password on create time to the Host even if it was inherited from Hostgroup.
When you've changed Hostgroup for Host, the root password was intanct and thus it used password from the old Hostgroup....

Fixes #32602 - enables puppet 7 agent support

Co-authored by @ikonia - Matt Darcy

Fixes #31947 - add grub2/ks validation to jenkins rake task

Fixes #33034 - add a description to all provisioning templates

This PR udpates all the templates metadata to provide at least minimal
description that is then stored in the DB and shown in the edit form.

Co-authored-by: Timo Goebel <mail@timogoebel.name>...

Fixes #32678 - katello_ca_consumer in registration template

Move `rhsm_reconfigure` script from `katello_consumer.rpm` to
`global_registration` template so the `rpm` is not needed anymore

Migrated script is without support of RHEL5 and older
`subscription-manager` versions (0.96 and bellow)

Fixes #33426 - changing virtual in ks fixed

Fixes #33092 - Restart network on EL8

Fixes #31049 - Introduce server CA file setting

Fixes #32822 - Job templates and resource picker

New `resource` user input type for templates with
template macro `input_resource` returning the resource object

Fixes #33033 - shell_escape template macro

New template macro `shell_escape` using
Ruby's `Shellwords.shellescape` for safe shell strings.

Use `shell_escape` for user input variables
in registration templates (`global` & `host_init`)

Fixes #32540 - host_param_(true|false)? cleanup

let the `default_value` denote what we "read" by default from the host
(in the case the host doesn't have the param) and then compare it with
`true`/`false` (depending on the func) as done with the existing...

Fixes #31059 - regenerate snapshots without environment

Fixes #31235 - drop Puppetclass models

Drops Puppetclass models and their usage.
Extracted in https://github.com/theforeman/foreman_puppet_enc/pull/81
Tests extracted in:
- hostgroup - https://github.com/theforeman/foreman_puppet_enc/pull/85

Fixes #31056 - drop SmartProxy Puppet feature

Drops testing with puppet feature, Puppet Proxy status.
Puppet proxy multiple update on host.

Extracted in: https://github.com/theforeman/foreman_puppet_enc/pull/70

Fixes #32918 - Host registration - Update packages

New parameter `update_packages` for update of
all packages on the host when registered

Refs #32981 - add snapshot tests for debian and ubuntu

Fixes #32490 - proper permission for ansible (#8630)

The file `/root/ansible_provisioning_call.sh` needs to be runnable.

Co-authored-by: Aldrey Galindo <aldreygalindo@gmail.com>

Fixes #28221 - Adding passing of template scope for snippet rendering

In current implementation templates can be much complex by snippet.
Reusable pieces of template code that should be in the same scope like
their templates but they are not. This PR tries to solve that.

Fixes #32486 - Fedora34/RHEL9 deprecated kernel boot parameters

Fixes #31978 - fix the automated provisioning of Fedora

Fedora does not have redhat-lsb-core package available and the installer
fails, interactively asking the user if the package should be ignored.
We should skip this package for Fedora in the default template....

Fixes #32681 - avoid naked echo statements in grub (#8564)

Fixes #31407 - prevent spaces for snapshot test files

Fixes #31370 - multi-host stub template snapshots (#8149)

Our snapshot template render test and generator only supports one host stub (ipv4 single NIC redhat OS). In order to test more ERB codepaths, we need a way to create snapshots against multiple host stubs (e.g. IPv6, dualstack, static IPv4 or IPv6, debian family). In order to do that, template metadata can be extended to define list of host stubs to create and test snapshots against....

Fixes #32394 - Use grub_pass macro instead of variable

The default Kickstart template uses obsolete @grub_pass variable
which are not being set anywhere. Maybe it's due to typo or else.
I suggest to use macro instead so it's possible to set the password
via host params and do not clone the template for this purpose only.

Fixes #31399 - snapshot tests exclude plugins

Fixes #31946 - support for S390x

On S390 kernel and initramdisk are at a different path and with different names: images/kernel.img and images/initrd.img. Foreman operating system model must reflect that in order to download Anaconda installer to TFTP.

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Refs #32372 - correct remaining paths

bb4633bcd4facc339a8099f4a8e89312323d8b61 refactored the atomic kickstart but
used an incorrect path for logs in the %pre section. This corrects it.

Fixes #32372 - Correct path for logs in kickstart

bb4633bcd4facc339a8099f4a8e89312323d8b61 refactored the kickstart but
used an incorrect path for logs in the %pre section. This corrects it.

Fixes #31743 - Template macro install_packages (#8298)

For package installation on supported OS families: Red Hat, Debian & Suse.
In host registration users can now install packages
by setting the `host_packages` parameter.

Also if a snippet `host_init_config_post` is defined, it gets added to the registration script.

Fixes #32092 - add puppet safe guard

Hides puppetserver and puppet environment behind macros, that can alter
implementation much more easily and even be patched from plugin.

Fixes #31750 - :foreman_server_ca_cert macro & not existing file (#8294)

Fixes #31064 - sequence helper macro (#8072)

Fixes #31758 - Unterminated single quote in chainloader pxeboot template breaks grub2 parser

Changes wording from can't to cannot to remove unterminated single quote.

fixes #31633 - Introducing format_time macro

There is no way how to show Unix timestamp in pretty way in reports. This macro solves the problem.

Fixes #31573 - drop IPAPPEND2 and use BOOTIF with 01 prefix

Fixes #31454 - extract eject cdrom into snippet

Fixes #28521 - log location, pre/post, dynamic layout

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Fixes #31348 - raw params in foreman_url support

Fixes #31082 - Add Insights snippet to the Kickstart templates (#8092)

Fixes #31020 - Global Registration & REX setup parameter (#8104)

New Host parameter 'host_registration_remote_execution',
seeded with default value set to 'true'.
New parameter :setup_remote_execution for Global registration endpoint,
allowing users to enable/disable REX setup when registering host.

Fixes #31067 - improve error message for ESP chainload

Fixes #30998 - Global Registration - Secure connection (#8047)

The global registration endpoint template now deployes the CA
certificate of the Foreman to a temp file. This certificate is then used
by subsequent curl calls to ensure the Foreman server authenticity. The...

Fixes #31015 - Add macros to deal with json and yaml in safemode