Fixes #23705 - Do not associate ptable snippets

Fixes #24167 - Remove legacy_puppet_hostname setting

Fixes #24122 - Remove limit from LookupValue value

Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #21007 - new unattended action 'failed'

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Refs #22984 - fix the type for all templates

Fixes #23376 - subnet.vlanid size is 4 bytes

Fixes #23679 - Nil error in migrate_template_to_parameters_macros (#5606)

Fixes #23635 - Centralize use of facter

We have a bundler group for facter. That implies it's optional but
before this change it wasn't With this change it's only required if no
domain and fqdn are set. This is still the default so in most cases it's
no difference, but at least we have centralized all use of facter to one...

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #22809 - Turn VM attributes to hash (#5403)

Fixes #19839 - Fix Rails/Present cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

fixes #21694 - Add MTU to subnet

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #22624 - User selectable columns model + api

Adding initial bindings to user selectable columns. This model + api is
going to be used in work related Katello plugin's subscription pages.
The main intesnt of this PR is to provide a basic model where a user can...

Fixes #22984 - Migrate templates auditable_type

https://github.com/theforeman/foreman/pull/4778 Changed `Ptable`
& `ProvisioningTemplate` `auditable_type` this commit adds the
missing migration.

Fixes #15286 - New API for auth sources (#4865)

Fixes #22875 - Fix digest limits

Fixes #22721 - Rename setting to trusted_hosts

The setting trusted_puppetmaster_hosts is used to allow hosts to submit
stuff to the facts/reports API endpoint.
The name made sense a long time ago, but these days other plugins and
any user can submit stuff to this API to generate...

Refs #17316 - Ensure the proxy exists before assigning tftp

If the subnet.tftp proxy didn't exist, the migration fails with

undefined method `has_feature?' for nil:NilClass'

so we rather make sure it exists before trying to set the template
proxy to nil.

Fixes #17316 - templates feature is subnet association

Fixes #22310 - Implement report scanner to identify origin (#5186)

Fixes #22382 - Remove ldap_filter 255 chars limit

Fixes #22339 - normalize empty values for User.timezone

Otherwise, we would need to deal with two values for the browser's
timezone. Less variants is better in this case.

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #1916 - Subnet vlan id should be integer

Fixes #21926 - Ensure uniqueness on image names and uuids (#5081)

Image names should be unique per CR and OS. UUID uniqueness is already
enforced by ActiveRecord but not in the DB, which could cause conflicts
in multi-proccess environments. Also cleaned up a bit of the image tests...

Fixes #21748 - Removed gravatar images

As gravatar urls use MD5 hashes

Fixes #5790 - Add compute resource to hostgroup (#4593)

Fixes #22111 - add taxonomy indexes to hosts

Fixes #19788 - fix Layout/SpaceAroundBlockParameters cop

Fixes #22068 - Add version column to auditable_index

Audits table queries cause high load in large deployments.

Foreman regularly does queries like this:
SELECT MAX AS max_id FROM `audits` WHERE `audits`.`auditable_id` = 7555 AND `audits`.`auditable_type` = 'LookupKey';...

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #21100 - set DB migration compatibility to 4.2

Put all existing DB migrations into 4.2 compatibility mode as they don't
specify null => true on timestamp columns etc.

Fixes #21766 - Enforce uniquness of TaxableTaxonomy in DB

Fixes #21669 - Use $major on CentOS media, $version deprecated

As we can see, CentOS fixed their repos so that
http://mirror.centos.org/centos/7 returns the latest version we need for
vmlinuz, etc..
For a long time they only offered these files under specific version...

Fixes #12054 - Openstack v3 support

fixes #18004 - increase fact value size

fixes #21394 - user login with access token api

Fixes #21342 - fix core roles seeding

Core roles should always be up to date based on what's defined in seed
files. Users have no other way to update locked roles in newer Foreman
versions.

Fixes #12216 - support http proxies for compute resources

Fixes #21206 - Fix templates taxonomies migration

In 0969b62, we added a migration to change the type of taxable
taxonomies. Unfortunatelly, it was not working right
as migratios don't run with any user and Ptable.all returned
empty set. We need to make sure to unscope when loading the data.

Fixes #21037 - use Host::Base as auditable_type

Otherwise, we are hitting "Invalid single-table inheritance type:
Host::Discovered is not a subclass of Host::Managed" when converting the
host from discovered to managed.

Fixes #21010 - add higher granularity and reorder seeds

Fixes #20955 - Remove conditions to {destroy, delete}_all calls

Fixes #20950 - Use 'distinct' in AR finders

Refs #16740 - migration templates to use param macros

Refs #20708 - reset default templates type

Fixes #20708 - fix templates auditing

Templates were audited under parent class. This keeps separate audits
per template type and allows searching by provisioning_template and
partition_table names. It also fixes broken associations in
taxable_taxonomies table.

Fixes #20737 - add default description to roles

Fixes #20608 - Adding index for ssh_keys

Adds a index :user_id to ssh_keys

Fixes #16112 - support for netgroups in LDAP auth source

Fixes #17918,#19354 - Smart class parameters appear in audits

Fixes #20143 - changed kind for Preseed default PXEGrub2 (#4630)

• Fixes #20143 - changed kind for Preseed default PXEGrub2

• Refs #20033 - renamed contents of templates seeds

Fixes #20033 - load seed data just once

fixes #19913 - fixes rubocop Style/ZeroLengthPredicate

Fixes #19934 - Don't limit smart class parameter order length

Fixes #15861 - increase size of audited_changes column

In mysql text type is limited to 64K, while in psql
there's no limit. Changeing type to MEDIUMTEXT,
which limited to 16MB, should solve this issue in mysql

Fixes #16159 - Rename mail alerts to not be Puppet specific

Right now, under 'my account', users get emails with alerts about the
status of their hosts regarding configuration management (e.g: if there
was an error, get an alert, or get a weekly summary of all hosts...

Fixes #19125 - Add description to hostgroup

Fixes #13772 - orchestration now uses app logger

Fixes #19169 - remove image password from audit

Fixes #19148 - Add description field to subnets

Fixes #18954 - Add CSV export to facts table

fixes #18940 - adds caching to notification api calls.

this implementation reduce the notification fetching time on
my production system from avg response times of 80ms to 20ms,
and siginficantly reducing server load (db, cpu etc)

it also removes total counts from the implementation, as that was not...

Fixes #18639 - lock all templates we seed

Fixes #18001 - Add plugin permissions to core's roles

Fixes #18893 - Improve latest events widget performance

fixes #18476 - users have ssh keys

fixes #18681 - moves polymorphic subject into notification object

also adds host build, destroyed and missing owner UI notifications

Fixes #18767 - keep cloning info

Fixes #14492 - Unify delete and minimize for dashboard widgets

Originally the idea was for the buttons to have a different effect on
the widgets, however with changes introduced later on these differences
have been reduced to being insignificant.

Fixes #18726 - Set null to true on migrations for Rails 5

Fixes #18426 - Add actions to notification entries

This adds support for the notifications to display actions. In case no
actions are provided, the dropdown kebab isn't shown. The actions
possible right now only include GET links.

Fixes #16982 - Scope properly when no taxonomies are set

The default scope for hosts and other objects did not restrict
properly by taxonomies. An user without organizations or
locations, could do anything it's permissions allow to.
The list of hosts was unrestricted and showed hosts in...

Fixes #16204 - Singularize ExternalUsergroups for permissions

fixes #18481 - host index page loads faster

Fixes #18440 - removes dead code and obsolete permission

Fixes #18321 - added migration for builtin roles

fixes #13618 - cache expensive vmware api calls

fixes #17545 - adds UI notification support

- Initial data model for notification support, based on manageiq design.
- addes notification JSON endpoints.

fixes #18130 - add autoincrement for bigint id columns

fixes #18136 - add indices for reports type column

fixes #17899 - Delete instead of destroy orphaned records

fixes #13810 - increase value range for id columns

Fixes #17850 - Prevent 414 on architecture/usergroup

These two fields had been modified using change_column in other
migrations which removed the limit on 'name'. This causes a 414 if
you create a very long name and try to edit the field.

After the change, the limit is restored so very long names are...

Fixes #17810 - Deleting smart class parameters with puppetclass

Fixes #17666 - prevent migration failures on counter cache

Removal of counter cache causes migrations relying on the
`reset_counters` method to fail. The migrations are changed to not
update the counters (which are now removed anyways).

Refs #1556 - Remove puppet docroot setting from db and tests

Fixes #16739 - unify parameters permissions

Fixes #6492 - ipmi_boot permission renamed to ipmi_boot_hosts

Authorizer expects permission names to follow a convention
'action'_'controller'. However this permission was not following it, and
this prevented the permission from being applied properly.

Before this fix, only admins could call ipmi_boot. I've also added a...

Fixes #13870 - encrypt specific settings values in db

Fixes #14277 - Added description field to users